From fdbdaa19821ff1ad399b15f19001a60209ed40e9 Mon Sep 17 00:00:00 2001 From: Daniel Hartung <22015466+dhartung@users.noreply.github.com> Date: Wed, 11 Sep 2019 20:57:12 +0200 Subject: [PATCH] Not all players support xxxSubtitleOffset --- src/components/playback/playbackmanager.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/components/playback/playbackmanager.js b/src/components/playback/playbackmanager.js index a82078c956..ada0c019fc 100644 --- a/src/components/playback/playbackmanager.js +++ b/src/components/playback/playbackmanager.js @@ -1643,7 +1643,9 @@ define(['events', 'datetime', 'appSettings', 'itemHelper', 'pluginManager', 'pla self.disableShowingSubtitleOffset = function(player) { player = player || self._currentPlayer; - player.disableShowingSubtitleOffset(); + if (player.disableShowingSubtitleOffset) { + player.disableShowingSubtitleOffset(); + } } self.isShowingSubtitleOffsetEnabled = function(player) { @@ -1658,12 +1660,16 @@ define(['events', 'datetime', 'appSettings', 'itemHelper', 'pluginManager', 'pla self.setSubtitleOffset = function (value, player) { player = player || self._currentPlayer; - player.setSubtitleOffset(value); + if (player.setSubtitleOffset) { + player.setSubtitleOffset(value); + } }; self.getPlayerSubtitleOffset = function(player) { player = player || self._currentPlayer; - return player.getSubtitleOffset(); + if (player.getPlayerSubtitleOffset) { + return player.getSubtitleOffset(); + } } self.canHandleOffsetOnCurrentSubtitle = function(player) {