mirrors/jellyfin-web
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00
Code Activity

fix: eslint no-shadow errors

Browse source
This commit is contained in:
Aimekram 2022-10-16 16:04:37 +02:00
parent 6a93a2eb29
commit 832b9eaf4d
30 changed files with 273 additions and 271 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/controllers/dashboard/encodingsettings.js
View file

@ -289,8 +289,8 @@ import alert from '../../components/alert';
libraryMenu.setTabs('playback', 0, getTabs);
const page = this;
ApiClient.getNamedConfiguration('encoding').then(function (config) {
ApiClient.getSystemInfo().then(function (systemInfo) {
loadPage(page, config, systemInfo);
ApiClient.getSystemInfo().then(function (fetchedSystemInfo) {
loadPage(page, config, fetchedSystemInfo);
});
});
});

16
src/controllers/itemDetails/index.js
View file

@ -770,7 +770,7 @@ function renderLinks(page, item) {
}
}
function renderDetailImage(elem, item, imageLoader) {
function renderDetailImage(elem, item, loader) {
const itemArray = [];
itemArray.push(item);
const cardHtml = cardBuilder.getCardsHtml(itemArray, {
@ -787,7 +787,7 @@ function renderDetailImage(elem, item, imageLoader) {
});
elem.innerHTML = cardHtml;
imageLoader.lazyChildren(elem);
loader.lazyChildren(elem);
// Avoid breaking the design by preventing focus of the poster using the keyboard.
elem.querySelector('a, button').tabIndex = -1;
@ -1881,28 +1881,28 @@ export default function (view, params) {
return params.serverId ? ServerConnections.getApiClient(params.serverId) : ApiClient;
}
function reload(instance, page, params) {
function reload(instance, page, pageParams) {
loading.show();
const apiClient = getApiClient();
Promise.all([getPromise(apiClient, params), apiClient.getCurrentUser()]).then(([item, user]) => {
Promise.all([getPromise(apiClient, pageParams), apiClient.getCurrentUser()]).then(([item, user]) => {
currentItem = item;
reloadFromItem(instance, page, params, item, user);
reloadFromItem(instance, page, pageParams, item, user);
}).catch((error) => {
console.error('failed to get item or current user: ', error);
});
}
function splitVersions(instance, page, apiClient, params) {
function splitVersions(instance, page, apiClient, pageParams) {
confirm('Are you sure you wish to split the media sources into separate items?', 'Split Media Apart').then(function () {
loading.show();
apiClient.ajax({
type: 'DELETE',
url: apiClient.getUrl('Videos/' + params.id + '/AlternateSources')
url: apiClient.getUrl('Videos/' + pageParams.id + '/AlternateSources')
}).then(function () {
loading.hide();
reload(instance, page, params);
reload(instance, page, pageParams);
});
});
}

22
src/controllers/movies/moviecollections.js
View file

@ -206,8 +206,8 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
return getPageData(tabContent).view;
};
const initPage = (tabContent) => {
tabContent.querySelector('.btnSort').addEventListener('click', function (e) {
const initPage = (tabElement) => {
tabElement.querySelector('.btnSort').addEventListener('click', function (e) {
libraryBrowser.showSortMenu({
items: [{
name: globalize.translate('Name'),
@ -226,26 +226,26 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
id: 'PremiereDate,SortName'
}],
callback: function () {
getQuery(tabContent).StartIndex = 0;
reloadItems(tabContent);
getQuery(tabElement).StartIndex = 0;
reloadItems(tabElement);
},
query: getQuery(tabContent),
query: getQuery(tabElement),
button: e.target
});
});
const btnSelectView = tabContent.querySelector('.btnSelectView');
const btnSelectView = tabElement.querySelector('.btnSelectView');
btnSelectView.addEventListener('click', (e) => {
libraryBrowser.showLayoutMenu(e.target, this.getCurrentViewStyle(), 'List,Poster,PosterCard,Thumb,ThumbCard'.split(','));
});
btnSelectView.addEventListener('layoutchange', function (e) {
const viewStyle = e.detail.viewStyle;
getPageData(tabContent).view = viewStyle;
libraryBrowser.saveViewSetting(getSavedQueryKey(tabContent), viewStyle);
getQuery(tabContent).StartIndex = 0;
getPageData(tabElement).view = viewStyle;
libraryBrowser.saveViewSetting(getSavedQueryKey(tabElement), viewStyle);
getQuery(tabElement).StartIndex = 0;
onViewStyleChange();
reloadItems(tabContent);
reloadItems(tabElement);
});
tabContent.querySelector('.btnNewCollection').addEventListener('click', () => {
tabElement.querySelector('.btnNewCollection').addEventListener('click', () => {
import('../../components/collectionEditor/collectionEditor').then(({default: collectionEditor}) => {
const serverId = ApiClient.serverInfo().Id;
new collectionEditor({

14
src/controllers/movies/movies.js
View file

@ -166,11 +166,11 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
return html;
};
const initPage = (tabContent) => {
const initPage = (tabElement) => {
itemsContainer.fetchData = fetchData;
itemsContainer.getItemsHtml = getItemsHtml;
itemsContainer.afterRefresh = afterRefresh;
const alphaPickerElement = tabContent.querySelector('.alphaPicker');
const alphaPickerElement = tabElement.querySelector('.alphaPicker');
if (alphaPickerElement) {
alphaPickerElement.addEventListener('alphavaluechanged', function (e) {
@ -190,19 +190,19 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
valueChangeEvent: 'click'
});
tabContent.querySelector('.alphaPicker').classList.add('alphabetPicker-right');
tabElement.querySelector('.alphaPicker').classList.add('alphabetPicker-right');
alphaPickerElement.classList.add('alphaPicker-fixed-right');
itemsContainer.classList.add('padded-right-withalphapicker');
}
const btnFilter = tabContent.querySelector('.btnFilter');
const btnFilter = tabElement.querySelector('.btnFilter');
if (btnFilter) {
btnFilter.addEventListener('click', () => {
this.showFilterMenu();
});
}
const btnSort = tabContent.querySelector('.btnSort');
const btnSort = tabElement.querySelector('.btnSort');
if (btnSort) {
btnSort.addEventListener('click', function (e) {
@ -248,7 +248,7 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
});
});
}
const btnSelectView = tabContent.querySelector('.btnSelectView');
const btnSelectView = tabElement.querySelector('.btnSelectView');
btnSelectView.addEventListener('click', (e) => {
libraryBrowser.showLayoutMenu(e.target, this.getCurrentViewStyle(), 'Banner,List,Poster,PosterCard,Thumb,ThumbCard'.split(','));
});
@ -260,7 +260,7 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
itemsContainer.refreshItems();
});
tabContent.querySelector('.btnShuffle').addEventListener('click', shuffle);
tabElement.querySelector('.btnShuffle').addEventListener('click', shuffle);
};
let itemsContainer = tabContent.querySelector('.itemsContainer');

18
src/controllers/movies/movietrailers.js
View file

@ -206,12 +206,12 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
return getPageData(tabContent).view;
};
const initPage = (tabContent) => {
const alphaPickerElement = tabContent.querySelector('.alphaPicker');
const itemsContainer = tabContent.querySelector('.itemsContainer');
const initPage = (tabElement) => {
const alphaPickerElement = tabElement.querySelector('.alphaPicker');
const itemsContainer = tabElement.querySelector('.itemsContainer');
alphaPickerElement.addEventListener('alphavaluechanged', function (e) {
const newValue = e.detail.value;
const query = getQuery(tabContent);
const query = getQuery(tabElement);
if (newValue === '#') {
query.NameLessThan = 'A';
delete query.NameStartsWith;
@ -227,14 +227,14 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
valueChangeEvent: 'click'
});
tabContent.querySelector('.alphaPicker').classList.add('alphabetPicker-right');
tabElement.querySelector('.alphaPicker').classList.add('alphabetPicker-right');
alphaPickerElement.classList.add('alphaPicker-fixed-right');
itemsContainer.classList.add('padded-right-withalphapicker');
tabContent.querySelector('.btnFilter').addEventListener('click', () => {
tabElement.querySelector('.btnFilter').addEventListener('click', () => {
this.showFilterMenu();
});
tabContent.querySelector('.btnSort').addEventListener('click', function (e) {
tabElement.querySelector('.btnSort').addEventListener('click', function (e) {
libraryBrowser.showSortMenu({
items: [{
name: globalize.translate('Name'),
@ -259,10 +259,10 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
id: 'PremiereDate,SortName'
}],
callback: function () {
getQuery(tabContent).StartIndex = 0;
getQuery(tabElement).StartIndex = 0;
reloadItems();
},
query: getQuery(tabContent),
query: getQuery(tabElement),
button: e.target
});
});

18
src/controllers/music/musicalbums.js
View file

@ -210,9 +210,9 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
return getPageData().view;
};
const initPage = (tabContent) => {
const alphaPickerElement = tabContent.querySelector('.alphaPicker');
const itemsContainer = tabContent.querySelector('.itemsContainer');
const initPage = (tabElement) => {
const alphaPickerElement = tabElement.querySelector('.alphaPicker');
const itemsContainer = tabElement.querySelector('.itemsContainer');
alphaPickerElement.addEventListener('alphavaluechanged', function (e) {
const newValue = e.detail.value;
@ -233,15 +233,15 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
valueChangeEvent: 'click'
});
tabContent.querySelector('.alphaPicker').classList.add('alphabetPicker-right');
tabElement.querySelector('.alphaPicker').classList.add('alphabetPicker-right');
alphaPickerElement.classList.add('alphaPicker-fixed-right');
itemsContainer.classList.add('padded-right-withalphapicker');
tabContent.querySelector('.btnFilter').addEventListener('click', () => {
tabElement.querySelector('.btnFilter').addEventListener('click', () => {
this.showFilterMenu();
});
tabContent.querySelector('.btnSort').addEventListener('click', (e) => {
tabElement.querySelector('.btnSort').addEventListener('click', (e) => {
libraryBrowser.showSortMenu({
items: [{
name: globalize.translate('Name'),
@ -274,7 +274,7 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
});
});
const btnSelectView = tabContent.querySelector('.btnSelectView');
const btnSelectView = tabElement.querySelector('.btnSelectView');
btnSelectView.addEventListener('click', (e) => {
libraryBrowser.showLayoutMenu(e.target, this.getCurrentViewStyle(), 'List,Poster,PosterCard'.split(','));
});
@ -288,8 +288,8 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
reloadItems();
});
tabContent.querySelector('.btnPlayAll').addEventListener('click', playAll);
tabContent.querySelector('.btnShuffle').addEventListener('click', shuffle);
tabElement.querySelector('.btnPlayAll').addEventListener('click', playAll);
tabElement.querySelector('.btnShuffle').addEventListener('click', shuffle);
};
initPage(tabContent);

24
src/controllers/music/musicartists.js
View file

@ -190,13 +190,13 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
return getPageData(tabContent).view;
};
const initPage = (tabContent) => {
const alphaPickerElement = tabContent.querySelector('.alphaPicker');
const itemsContainer = tabContent.querySelector('.itemsContainer');
const initPage = (tabElement) => {
const alphaPickerElement = tabElement.querySelector('.alphaPicker');
const itemsContainer = tabElement.querySelector('.itemsContainer');
alphaPickerElement.addEventListener('alphavaluechanged', function (e) {
const newValue = e.detail.value;
const query = getQuery(tabContent);
const query = getQuery(tabElement);
if (newValue === '#') {
query.NameLessThan = 'A';
delete query.NameStartsWith;
@ -205,31 +205,31 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
delete query.NameLessThan;
}
query.StartIndex = 0;
reloadItems(tabContent);
reloadItems(tabElement);
});
this.alphaPicker = new AlphaPicker({
element: alphaPickerElement,
valueChangeEvent: 'click'
});
tabContent.querySelector('.alphaPicker').classList.add('alphabetPicker-right');
tabElement.querySelector('.alphaPicker').classList.add('alphabetPicker-right');
alphaPickerElement.classList.add('alphaPicker-fixed-right');
itemsContainer.classList.add('padded-right-withalphapicker');
tabContent.querySelector('.btnFilter').addEventListener('click', () => {
tabElement.querySelector('.btnFilter').addEventListener('click', () => {
this.showFilterMenu();
});
const btnSelectView = tabContent.querySelector('.btnSelectView');
const btnSelectView = tabElement.querySelector('.btnSelectView');
btnSelectView.addEventListener('click', (e) => {
libraryBrowser.showLayoutMenu(e.target, this.getCurrentViewStyle(), 'List,Poster,PosterCard'.split(','));
});
btnSelectView.addEventListener('layoutchange', function (e) {
const viewStyle = e.detail.viewStyle;
getPageData(tabContent).view = viewStyle;
libraryBrowser.saveViewSetting(getSavedQueryKey(tabContent), viewStyle);
getQuery(tabContent).StartIndex = 0;
getPageData(tabElement).view = viewStyle;
libraryBrowser.saveViewSetting(getSavedQueryKey(tabElement), viewStyle);
getQuery(tabElement).StartIndex = 0;
onViewStyleChange();
reloadItems(tabContent);
reloadItems(tabElement);
});
};

4
src/controllers/music/musicrecommended.js
View file

@ -226,7 +226,7 @@ import Dashboard from '../../utils/dashboard';
loadSuggestionsTab(view, tabContent, params.topParentId);
}
function enableScrollX() {
function enableScrollXmobile() {
return browser.mobile;
}
@ -362,7 +362,7 @@ import Dashboard from '../../utils/dashboard';
const containers = tabContent.querySelectorAll('.itemsContainer');
for (let i = 0, length = containers.length; i < length; i++) {
setScrollClasses(containers[i], enableScrollX());
setScrollClasses(containers[i], enableScrollXmobile());
}
};

14
src/controllers/music/songs.js
View file

@ -159,11 +159,11 @@ export default function (view, params, tabContent) {
return getPageData(tabContent).view;
};
function initPage(tabContent) {
tabContent.querySelector('.btnFilter').addEventListener('click', function () {
function initPage(tabElement) {
tabElement.querySelector('.btnFilter').addEventListener('click', function () {
self.showFilterMenu();
});
tabContent.querySelector('.btnSort').addEventListener('click', function (e) {
tabElement.querySelector('.btnSort').addEventListener('click', function (e) {
libraryBrowser.showSortMenu({
items: [{
name: globalize.translate('OptionTrackName'),
@ -197,14 +197,14 @@ export default function (view, params, tabContent) {
id: 'Random,SortName'
}],
callback: function () {
getQuery(tabContent).StartIndex = 0;
reloadItems(tabContent);
getQuery(tabElement).StartIndex = 0;
reloadItems(tabElement);
},
query: getQuery(tabContent),
query: getQuery(tabElement),
button: e.target
});
});
tabContent.querySelector('.btnShuffle').addEventListener('click', shuffle);
tabElement.querySelector('.btnShuffle').addEventListener('click', shuffle);
}
initPage(tabContent);

18
src/controllers/shows/episodes.js
View file

@ -190,11 +190,11 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
return getPageData(tabContent).view;
};
function initPage(tabContent) {
tabContent.querySelector('.btnFilter').addEventListener('click', function () {
function initPage(tabElement) {
tabElement.querySelector('.btnFilter').addEventListener('click', function () {
self.showFilterMenu();
});
tabContent.querySelector('.btnSort').addEventListener('click', function (e) {
tabElement.querySelector('.btnSort').addEventListener('click', function (e) {
libraryBrowser.showSortMenu({
items: [{
name: globalize.translate('Name'),
@ -222,22 +222,22 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
id: 'Runtime,SeriesSortName,SortName'
}],
callback: function () {
reloadItems(tabContent);
reloadItems(tabElement);
},
query: getQuery(tabContent),
query: getQuery(tabElement),
button: e.target
});
});
const btnSelectView = tabContent.querySelector('.btnSelectView');
const btnSelectView = tabElement.querySelector('.btnSelectView');
btnSelectView.addEventListener('click', function (e) {
libraryBrowser.showLayoutMenu(e.target, self.getCurrentViewStyle(), 'List,Poster,PosterCard'.split(','));
});
btnSelectView.addEventListener('layoutchange', function (e) {
const viewStyle = e.detail.viewStyle;
getPageData(tabContent).view = viewStyle;
libraryBrowser.saveViewSetting(getSavedQueryKey(tabContent), viewStyle);
getPageData(tabElement).view = viewStyle;
libraryBrowser.saveViewSetting(getSavedQueryKey(tabElement), viewStyle);
onViewStyleChange();
reloadItems(tabContent);
reloadItems(tabElement);
});
}

32
src/controllers/shows/tvshows.js
View file

@ -219,13 +219,13 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
return getPageData(tabContent).view;
};
const initPage = (tabContent) => {
const alphaPickerElement = tabContent.querySelector('.alphaPicker');
const itemsContainer = tabContent.querySelector('.itemsContainer');
const initPage = (tabElement) => {
const alphaPickerElement = tabElement.querySelector('.alphaPicker');
const itemsContainer = tabElement.querySelector('.itemsContainer');
alphaPickerElement.addEventListener('alphavaluechanged', function (e) {
const newValue = e.detail.value;
const query = getQuery(tabContent);
const query = getQuery(tabElement);
if (newValue === '#') {
query.NameLessThan = 'A';
delete query.NameStartsWith;
@ -234,21 +234,21 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
delete query.NameLessThan;
}
query.StartIndex = 0;
reloadItems(tabContent);
reloadItems(tabElement);
});
this.alphaPicker = new AlphaPicker({
element: alphaPickerElement,
valueChangeEvent: 'click'
});
tabContent.querySelector('.alphaPicker').classList.add('alphabetPicker-right');
tabElement.querySelector('.alphaPicker').classList.add('alphabetPicker-right');
alphaPickerElement.classList.add('alphaPicker-fixed-right');
itemsContainer.classList.add('padded-right-withalphapicker');
tabContent.querySelector('.btnFilter').addEventListener('click', () => {
tabElement.querySelector('.btnFilter').addEventListener('click', () => {
this.showFilterMenu();
});
tabContent.querySelector('.btnSort').addEventListener('click', function (e) {
tabElement.querySelector('.btnSort').addEventListener('click', function (e) {
libraryBrowser.showSortMenu({
items: [{
name: globalize.translate('Name'),
@ -276,24 +276,24 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer';
id: 'PremiereDate,SortName'
}],
callback: function () {
getQuery(tabContent).StartIndex = 0;
reloadItems(tabContent);
getQuery(tabElement).StartIndex = 0;
reloadItems(tabElement);
},
query: getQuery(tabContent),
query: getQuery(tabElement),
button: e.target
});
});
const btnSelectView = tabContent.querySelector('.btnSelectView');
const btnSelectView = tabElement.querySelector('.btnSelectView');
btnSelectView.addEventListener('click', (e) => {
libraryBrowser.showLayoutMenu(e.target, this.getCurrentViewStyle(), 'Banner,List,Poster,PosterCard,Thumb,ThumbCard'.split(','));
});
btnSelectView.addEventListener('layoutchange', function (e) {
const viewStyle = e.detail.viewStyle;
getPageData(tabContent).view = viewStyle;
libraryBrowser.saveViewSetting(getSavedQueryKey(tabContent), viewStyle);
getQuery(tabContent).StartIndex = 0;
getPageData(tabElement).view = viewStyle;
libraryBrowser.saveViewSetting(getSavedQueryKey(tabElement), viewStyle);
getQuery(tabElement).StartIndex = 0;
onViewStyleChange();
reloadItems(tabContent);
reloadItems(tabElement);
});
};