From 90290d30dba221d27757ca8d7ced8617c448561f Mon Sep 17 00:00:00 2001
From: dkanada <dkanada@users.noreply.github.com>
Date: Sat, 9 Mar 2019 11:37:40 +0900
Subject: [PATCH] fix some other code clarity issues

---
 src/components/apphost.js           |  1 +
 src/dashboard/dashboardgeneral.js   |  9 +++------
 src/dashboard/livetvtuner.js        | 17 ++++++++++-------
 src/scripts/notificationsettings.js | 14 +++++++-------
 src/scripts/plugincatalogpage.js    | 13 +++++++------
 5 files changed, 28 insertions(+), 26 deletions(-)

diff --git a/src/components/apphost.js b/src/components/apphost.js
index 619cd298b7..9cffd2d8a4 100644
--- a/src/components/apphost.js
+++ b/src/components/apphost.js
@@ -143,6 +143,7 @@ define(["appSettings", "browser", "events", "htmlMediaHelper"], function(appSett
         features.push("displaylanguage");
         features.push("otherapppromotions");
         features.push("targetblank");
+        // allows users to connect to more than one server
         //features.push("multiserver");
         browser.orsay || browser.tizen || browser.msie || !(browser.firefox || browser.ps4 || browser.edge || cueSupported()) || features.push("subtitleappearancesettings");
         browser.orsay || browser.tizen || features.push("subtitleburnsettings");
diff --git a/src/dashboard/dashboardgeneral.js b/src/dashboard/dashboardgeneral.js
index cf9d58f3dd..c2f48a2803 100644
--- a/src/dashboard/dashboardgeneral.js
+++ b/src/dashboard/dashboardgeneral.js
@@ -10,8 +10,8 @@ define(["jQuery", "loading", "fnchecked", "emby-checkbox", "emby-textarea", "emb
         page.querySelector("#txtCachePath").value = config.CachePath || "";
         $("#txtMetadataPath", page).val(config.MetadataPath || "");
         $("#txtMetadataNetworkPath", page).val(config.MetadataNetworkPath || "");
-        $("#selectLocalizationLanguage", page).html(languageOptions.map(function(l) {
-            return '<option value="' + l.Value + '">' + l.Name + "</option>"
+        $("#selectLocalizationLanguage", page).html(languageOptions.map(function(language) {
+            return '<option value="' + language.Value + '">' + language.Name + "</option>"
         })).val(config.UICulture);
         currentLanguage = config.UICulture;
         if (systemInfo.CanSelfUpdate) {
@@ -43,10 +43,7 @@ define(["jQuery", "loading", "fnchecked", "emby-checkbox", "emby-textarea", "emb
             config.CachePath = form.querySelector("#txtCachePath").value;
             config.MetadataPath = $("#txtMetadataPath", form).val();
             config.MetadataNetworkPath = $("#txtMetadataNetworkPath", form).val();
-            var requiresReload = false;
-            if (config.UICulture !== currentLanguage) {
-                requiresReload = true;
-            }
+            var requiresReload = (config.UICulture !== currentLanguage);
             config.EnableAutomaticRestart = $("#chkEnableAutomaticRestart", form).checked();
             config.EnableAutoUpdate = $("#chkEnableAutomaticServerUpdates", form).checked();
             ApiClient.updateServerConfiguration(config).then(function() {
diff --git a/src/dashboard/livetvtuner.js b/src/dashboard/livetvtuner.js
index 1cc806d05b..8d27093af1 100644
--- a/src/dashboard/livetvtuner.js
+++ b/src/dashboard/livetvtuner.js
@@ -8,12 +8,14 @@ define(["globalize", "loading", "libraryMenu", "dom", "emby-input", "emby-button
     function fillTypes(view, currentId) {
         ApiClient.getJSON(ApiClient.getUrl("LiveTv/TunerHosts/Types")).then(function(types) {
             var selectType = view.querySelector(".selectType");
-            selectType.innerHTML = types.map(function(t) {
-                return '<option value="' + t.Id + '">' + t.Name + "</option>";
+            var html = "";
+            html += types.map(function(tuner) {
+                return '<option value="' + tuner.Id + '">' + tuner.Name + "</option>";
             }).join("");
-            selectType.innerHTML += '<option value="other">';
-            selectType.innerHTML += globalize.translate("TabOther");
-            selectType.innerHTML += "</option>";
+            html += '<option value="other">';
+            html += globalize.translate("TabOther");
+            html += "</option>";
+            selectType.innerHTML = html;
 
             selectType.disabled = null != currentId;
             selectType.value = "";
@@ -39,9 +41,10 @@ define(["globalize", "loading", "libraryMenu", "dom", "emby-input", "emby-button
         var selectType = view.querySelector(".selectType");
         var type = info.Type || "";
         if (info.Source && isM3uVariant(info.Source)) {
-            selectType.value = info.Source;
-            onTypeChange.call(selectType);
+            type = info.Source;
         }
+        selectType.value = type;
+        onTypeChange.call(selectType);
         view.querySelector(".txtDevicePath").value = info.Url || "";
         view.querySelector(".txtFriendlyName").value = info.FriendlyName || "";
         view.querySelector(".txtUserAgent").value = info.UserAgent || "";
diff --git a/src/scripts/notificationsettings.js b/src/scripts/notificationsettings.js
index 317abce620..b167ca00e4 100644
--- a/src/scripts/notificationsettings.js
+++ b/src/scripts/notificationsettings.js
@@ -7,10 +7,10 @@ define(["loading", "libraryMenu", "globalize", "listViewStyle", "emby-linkbutton
             var html = "";
             var lastCategory = "";
             var showHelp = true;
-            html += list.map(function(i) {
+            html += list.map(function(notification) {
                 var itemHtml = "";
-                if (i.Category !== lastCategory) {
-                    lastCategory = i.Category;
+                if (notification.Category !== lastCategory) {
+                    lastCategory = notification.Category;
                     if (lastCategory) {
                         itemHtml += "</div>";
                         itemHtml += "</div>";
@@ -18,7 +18,7 @@ define(["loading", "libraryMenu", "globalize", "listViewStyle", "emby-linkbutton
                     itemHtml += '<div class="verticalSection verticalSection-extrabottompadding">';
                     itemHtml += '<div class="sectionTitleContainer" style="margin-bottom:1em;">';
                     itemHtml += '<h2 class="sectionTitle">';
-                    itemHtml += i.Category;
+                    itemHtml += notification.Category;
                     itemHtml += "</h2>";
                     if (showHelp) {
                         showHelp = false;
@@ -29,14 +29,14 @@ define(["loading", "libraryMenu", "globalize", "listViewStyle", "emby-linkbutton
                     itemHtml += "</div>";
                     itemHtml += '<div class="paperList">';
                 }
-                itemHtml += '<a class="listItem listItem-border" is="emby-linkbutton" data-ripple="false" href="notificationsetting.html?type=' + i.Type + '">';
-                if (i.Enabled) {
+                itemHtml += '<a class="listItem listItem-border" is="emby-linkbutton" data-ripple="false" href="notificationsetting.html?type=' + notification.Type + '">';
+                if (notification.Enabled) {
                     itemHtml += '<i class="listItemIcon md-icon">notifications_active</i>';
                 } else {
                     itemHtml += '<i class="listItemIcon md-icon" style="background-color:#999;">notifications_off</i>';
                 }
                 itemHtml += '<div class="listItemBody">';
-                itemHtml += '<div class="listItemBodyText">' + i.Name + "</div>";
+                itemHtml += '<div class="listItemBodyText">' + notification.Name + "</div>";
                 itemHtml += "</div>";
                 itemHtml += '<button type="button" is="paper-icon-button-light"><i class="md-icon">mode_edit</i></button>';
                 itemHtml += "</a>";
diff --git a/src/scripts/plugincatalogpage.js b/src/scripts/plugincatalogpage.js
index f18c56f2f0..b399ba098a 100644
--- a/src/scripts/plugincatalogpage.js
+++ b/src/scripts/plugincatalogpage.js
@@ -59,15 +59,19 @@ define(["loading", "libraryMenu", "globalize", "cardStyle", "emby-linkbutton", "
             return 0;
         });
 
-        var i__q;
         var length;
         var plugin;
         var currentCategory;
         var html = "";
 
         var hasOpenTag = false;
-        for (currentCategory = null, false === options.showCategory && (html += '<div class="itemsContainer vertical-wrap">', hasOpenTag = true), i__q = 0, length = availablePlugins.length; i__q < length; i__q++) {
-            plugin = availablePlugins[i__q];
+        currentCategory = null;
+        if (options.showCategory === false) {
+            html += '<div class="itemsContainer vertical-wrap">';
+            hasOpenTag = true;
+        }
+        for (var i = 0; i < availablePlugins.length; i++) {
+            plugin = availablePlugins[i];
             var category = plugin.categoryDisplayName;
 
             if (category != currentCategory) {
@@ -77,16 +81,13 @@ define(["loading", "libraryMenu", "globalize", "cardStyle", "emby-linkbutton", "
                         html += "</div>";
                         html += "</div>";
                     }
-
                     html += '<div class="verticalSection">';
                     html += '<h2 class="sectionTitle sectionTitle-cards">' + category + "</h2>";
                     html += '<div class="itemsContainer vertical-wrap">';
                     hasOpenTag = true;
                 }
-
                 currentCategory = category;
             }
-
             html += getPluginHtml(plugin, options, installedPlugins);
         }