From 93d63330fd4e8555733c930ebb5b51c7d256a494 Mon Sep 17 00:00:00 2001 From: "Joshua M. Boniface" Date: Tue, 30 May 2023 10:39:27 -0400 Subject: [PATCH] Fix conditional formatting and add fallback --- src/controllers/dashboard/plugins/add/index.js | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/controllers/dashboard/plugins/add/index.js b/src/controllers/dashboard/plugins/add/index.js index 8bca658a37..0792494f79 100644 --- a/src/controllers/dashboard/plugins/add/index.js +++ b/src/controllers/dashboard/plugins/add/index.js @@ -67,11 +67,14 @@ function renderPackage(pkg, installedPlugins, page) { $('#developer', page).text(pkg.owner); // This is a hack; the repository name and URL should be part of the global values // for the plugin, not each individual version. So we just use the top (latest) - // version to get this information. -if (pkg.versions.length) { - $('#repositoryName', page).text(pkg.versions[0].repositoryName); - $('#repositoryUrl', page).text(pkg.versions[0].repositoryUrl); - } + // version to get this information. If it's missing (no versions), then say so. + if (pkg.versions.length) { + $('#repositoryName', page).text(pkg.versions[0].repositoryName); + $('#repositoryUrl', page).text(pkg.versions[0].repositoryUrl); + } else { + $('#repositoryName', page).text('Unknown (no versions)'); + $('#repositoryUrl', page).text('Unknown (no versions)'); + } if (installedPlugin) { const currentVersionText = globalize.translate('MessageYouHaveVersionInstalled', '' + installedPlugin.Version + '');