mirrors/jellyfin-web
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00
Code Activity

Merge pull request #3348 from thornbill/fix-react-emby-select

Browse source 
Fix unstyled emby-select field when rendered with React
This commit is contained in:
Bill Thornton 2022-01-20 00:33:34 -05:00 • committed by GitHub
commit 984aa39c4a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/components/dashboard/users/SelectSyncPlayAccessElement.tsx
View file

@ -3,7 +3,7 @@ import globalize from '../../../scripts/globalize';
const createSelectElement = ({ className, id, label }) => ({
__html: `<select
className="${className}"
class="${className}"
is="emby-select"
id="${id}"
label="${label}"

6
src/elements/emby-select/emby-select.js
View file

@ -138,15 +138,15 @@ import 'webcomponents.js/webcomponents-lite';
label.innerHTML = this.getAttribute('label') || '';
label.classList.add('selectLabel');
label.htmlFor = this.id;
this.parentNode.insertBefore(label, this);
this.parentNode?.insertBefore(label, this);
if (this.classList.contains('emby-select-withcolor')) {
this.parentNode.insertAdjacentHTML('beforeend', '<div class="selectArrowContainer"><div style="visibility:hidden;display:none;">0</div><span class="selectArrow material-icons keyboard_arrow_down"></span></div>');
this.parentNode?.insertAdjacentHTML('beforeend', '<div class="selectArrowContainer"><div style="visibility:hidden;display:none;">0</div><span class="selectArrow material-icons keyboard_arrow_down"></span></div>');
}
};
EmbySelectPrototype.setLabel = function (text) {
const label = this.parentNode.querySelector('label');
const label = this.parentNode?.querySelector('label');
label.innerHTML = text;
};