From 9b05dab27e64ec30485180111ac42845b531ca39 Mon Sep 17 00:00:00 2001 From: "Brian C. Arnold" Date: Sun, 25 Apr 2021 20:31:19 -0400 Subject: [PATCH] Added ability to burn in all subtitles, including SRT. --- .../subtitlesettings.template.html | 1 + src/scripts/browserDeviceProfile.js | 32 ++++++++++--------- 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a/src/components/subtitlesettings/subtitlesettings.template.html b/src/components/subtitlesettings/subtitlesettings.template.html index 2884b26efd..b335bb3e34 100644 --- a/src/components/subtitlesettings/subtitlesettings.template.html +++ b/src/components/subtitlesettings/subtitlesettings.template.html @@ -28,6 +28,7 @@ +
${BurnSubtitlesHelp}
diff --git a/src/scripts/browserDeviceProfile.js b/src/scripts/browserDeviceProfile.js index 7bc2f6a6b7..a9382be44d 100644 --- a/src/scripts/browserDeviceProfile.js +++ b/src/scripts/browserDeviceProfile.js @@ -944,21 +944,23 @@ import browser from './browser'; // Subtitle profiles // External vtt or burn in profile.SubtitleProfiles = []; - if (supportsTextTracks()) { - profile.SubtitleProfiles.push({ - Format: 'vtt', - Method: 'External' - }); - } - if (options.enableSsaRender !== false && (!options.isRetry && appSettings.get('subtitleburnin') !== 'allcomplexformats')) { - profile.SubtitleProfiles.push({ - Format: 'ass', - Method: 'External' - }); - profile.SubtitleProfiles.push({ - Format: 'ssa', - Method: 'External' - }); + if (!options.isRetry && appSettings.get('subtitleburnin') !== 'all') { + if (supportsTextTracks()) { + profile.SubtitleProfiles.push({ + Format: 'vtt', + Method: 'External' + }); + } + if (options.enableSsaRender !== false && appSettings.get('subtitleburnin') !== 'allcomplexformats') { + profile.SubtitleProfiles.push({ + Format: 'ass', + Method: 'External' + }); + profile.SubtitleProfiles.push({ + Format: 'ssa', + Method: 'External' + }); + } } profile.ResponseProfiles = [];