From 9f302dbf7207c179de9dba2cfe805fe551de7abf Mon Sep 17 00:00:00 2001 From: Dmitry Lyzo Date: Thu, 24 Feb 2022 18:37:32 +0300 Subject: [PATCH] Make title of ratingbutton state-dependent --- src/elements/emby-ratingbutton/emby-ratingbutton.js | 10 ++++++---- src/strings/en-us.json | 1 + 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/elements/emby-ratingbutton/emby-ratingbutton.js b/src/elements/emby-ratingbutton/emby-ratingbutton.js index 5e279616e4..de42531891 100644 --- a/src/elements/emby-ratingbutton/emby-ratingbutton.js +++ b/src/elements/emby-ratingbutton/emby-ratingbutton.js @@ -88,10 +88,12 @@ import ServerConnections from '../../components/ServerConnections'; button.setAttribute('data-likes', (likes === null ? '' : likes)); } + + setTitle(button, isFavorite); } - function setTitle(button) { - button.title = globalize.translate('Favorite'); + function setTitle(button, isFavorite) { + button.title = isFavorite ? globalize.translate('Favorite') : globalize.translate('AddToFavorites'); const text = button.querySelector('.button-text'); if (text) { @@ -141,9 +143,9 @@ import ServerConnections from '../../components/ServerConnections'; setState(this, likes, isFavorite, false); bindEvents(this); + } else { + setTitle(this); } - - setTitle(this); }; EmbyRatingButtonPrototype.detachedCallback = function () { diff --git a/src/strings/en-us.json b/src/strings/en-us.json index b28f9d60f8..d59708cf7e 100644 --- a/src/strings/en-us.json +++ b/src/strings/en-us.json @@ -6,6 +6,7 @@ "AddedOnValue": "Added {0}", "AdditionalNotificationServices": "Browse the plugin catalog to install additional notification services.", "AddToCollection": "Add to collection", + "AddToFavorites": "Add to favorites", "AddToPlaylist": "Add to playlist", "AddToPlayQueue": "Add to play queue", "AgeValue": "({0} years old)",