From 0e3f6fa77b8872943ef495e9d488a3e04750397e Mon Sep 17 00:00:00 2001 From: Carlo Colombo Date: Fri, 9 Feb 2024 22:31:12 +0100 Subject: [PATCH 1/2] subtitles offset keybinding --- src/components/subtitlesync/subtitlesync.js | 15 +++++++++++++++ src/controllers/playback/video/index.js | 6 ++++++ 2 files changed, 21 insertions(+) diff --git a/src/components/subtitlesync/subtitlesync.js b/src/components/subtitlesync/subtitlesync.js index 57ae63cb8c..aae73957e5 100644 --- a/src/components/subtitlesync/subtitlesync.js +++ b/src/components/subtitlesync/subtitlesync.js @@ -151,6 +151,21 @@ class SubtitleSync { subtitleSyncContainer.classList.add('hide'); } } + + update(offset) { + this.toggle(); + + const value = parseFloat(subtitleSyncSlider.value) + offset; + subtitleSyncSlider.updateOffset(value); + } + + incrementOffset() { + this.update(+subtitleSyncSlider.step); + } + + decrementOffset() { + this.update(-subtitleSyncSlider.step); + } } export default SubtitleSync; diff --git a/src/controllers/playback/video/index.js b/src/controllers/playback/video/index.js index fbe4c3cecb..3019e2bacd 100644 --- a/src/controllers/playback/video/index.js +++ b/src/controllers/playback/video/index.js @@ -1340,6 +1340,12 @@ export default function (view) { case 'PageDown': playbackManager.previousChapter(currentPlayer); break; + case 'g': + subtitleSyncOverlay?.decrementOffset(); + break; + case 'h': + subtitleSyncOverlay?.incrementOffset(); + break; } } From 92e5d692ea92c060f31b87ec36d27ec485ac9eeb Mon Sep 17 00:00:00 2001 From: Bill Thornton Date: Fri, 16 Aug 2024 11:06:26 -0400 Subject: [PATCH 2/2] Add uppercase variants Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com> --- src/controllers/playback/video/index.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/controllers/playback/video/index.js b/src/controllers/playback/video/index.js index 3019e2bacd..2f0067ddce 100644 --- a/src/controllers/playback/video/index.js +++ b/src/controllers/playback/video/index.js @@ -1341,9 +1341,11 @@ export default function (view) { playbackManager.previousChapter(currentPlayer); break; case 'g': + case 'G': subtitleSyncOverlay?.decrementOffset(); break; case 'h': + case 'H': subtitleSyncOverlay?.incrementOffset(); break; }