From 50d7ce860c57ab7490ccaa2e1f3533a12da42765 Mon Sep 17 00:00:00 2001
From: venkat_karasani <venkatnadhkarasani@gmail.com>
Date: Mon, 8 Jul 2024 17:12:28 -0500
Subject: [PATCH 1/2] cleanup: Remove the intermediate notifications dashboard
 page.

---
 .../drawer/sections/AdvancedDrawerSection.tsx |  9 -----
 src/apps/dashboard/routes/_asyncRoutes.ts     |  1 -
 src/apps/dashboard/routes/_redirects.ts       |  1 -
 src/apps/dashboard/routes/notifications.tsx   | 34 -------------------
 4 files changed, 45 deletions(-)
 delete mode 100644 src/apps/dashboard/routes/notifications.tsx

diff --git a/src/apps/dashboard/components/drawer/sections/AdvancedDrawerSection.tsx b/src/apps/dashboard/components/drawer/sections/AdvancedDrawerSection.tsx
index 97993a76cc..5718825d3d 100644
--- a/src/apps/dashboard/components/drawer/sections/AdvancedDrawerSection.tsx
+++ b/src/apps/dashboard/components/drawer/sections/AdvancedDrawerSection.tsx
@@ -1,5 +1,4 @@
 import Article from '@mui/icons-material/Article';
-import EditNotifications from '@mui/icons-material/EditNotifications';
 import ExpandLess from '@mui/icons-material/ExpandLess';
 import ExpandMore from '@mui/icons-material/ExpandMore';
 import Extension from '@mui/icons-material/Extension';
@@ -64,14 +63,6 @@ const AdvancedDrawerSection = () => {
                     <ListItemText primary={globalize.translate('TabLogs')} />
                 </ListItemLink>
             </ListItem>
-            <ListItem disablePadding>
-                <ListItemLink to='/dashboard/notifications'>
-                    <ListItemIcon>
-                        <EditNotifications />
-                    </ListItemIcon>
-                    <ListItemText primary={globalize.translate('Notifications')} />
-                </ListItemLink>
-            </ListItem>
             <ListItem disablePadding>
                 <ListItemLink to='/dashboard/plugins' selected={false}>
                     <ListItemIcon>
diff --git a/src/apps/dashboard/routes/_asyncRoutes.ts b/src/apps/dashboard/routes/_asyncRoutes.ts
index caf155b9e0..9e31c2b5c8 100644
--- a/src/apps/dashboard/routes/_asyncRoutes.ts
+++ b/src/apps/dashboard/routes/_asyncRoutes.ts
@@ -2,7 +2,6 @@ import { AsyncRouteType, type AsyncRoute } from 'components/router/AsyncRoute';
 
 export const ASYNC_ADMIN_ROUTES: AsyncRoute[] = [
     { path: 'activity', type: AsyncRouteType.Dashboard },
-    { path: 'notifications', type: AsyncRouteType.Dashboard },
     { path: 'users', type: AsyncRouteType.Dashboard },
     { path: 'users/access', type: AsyncRouteType.Dashboard },
     { path: 'users/add', type: AsyncRouteType.Dashboard },
diff --git a/src/apps/dashboard/routes/_redirects.ts b/src/apps/dashboard/routes/_redirects.ts
index 009aa65914..d5dc9177d4 100644
--- a/src/apps/dashboard/routes/_redirects.ts
+++ b/src/apps/dashboard/routes/_redirects.ts
@@ -21,7 +21,6 @@ export const REDIRECTS: Redirect[] = [
     { from: 'metadataimages.html', to: '/dashboard/libraries/metadata' },
     { from: 'metadatanfo.html', to: '/dashboard/libraries/nfo' },
     { from: 'networking.html', to: '/dashboard/networking' },
-    { from: 'notificationsettings.html', to: '/dashboard/notifications' },
     { from: 'playbackconfiguration.html', to: '/dashboard/playback/resume' },
     { from: 'repositories.html', to: '/dashboard/plugins/repositories' },
     { from: 'scheduledtask.html', to: '/dashboard/tasks/edit' },
diff --git a/src/apps/dashboard/routes/notifications.tsx b/src/apps/dashboard/routes/notifications.tsx
deleted file mode 100644
index 7642ee033b..0000000000
--- a/src/apps/dashboard/routes/notifications.tsx
+++ /dev/null
@@ -1,34 +0,0 @@
-import Alert from '@mui/material/Alert/Alert';
-import Box from '@mui/material/Box/Box';
-import Button from '@mui/material/Button/Button';
-import React from 'react';
-import { Link } from 'react-router-dom';
-
-import Page from 'components/Page';
-import globalize from 'scripts/globalize';
-
-const NotificationsPage = () => (
-    <Page
-        id='notificationSettingPage'
-        title={globalize.translate('Notifications')}
-        className='mainAnimatedPage type-interior'
-    >
-        <div className='content-primary'>
-            <h2>{globalize.translate('Notifications')}</h2>
-
-            <Alert severity='info'>
-                <Box sx={{ marginBottom: 2 }}>
-                    {globalize.translate('NotificationsMovedMessage')}
-                </Box>
-                <Button
-                    component={Link}
-                    to='/dashboard/plugins/add?name=Webhook&guid=71552a5a5c5c4350a2aeebe451a30173'
-                >
-                    {globalize.translate('GetThePlugin')}
-                </Button>
-            </Alert>
-        </div>
-    </Page>
-);
-
-export default NotificationsPage;

From 63556e5103b8d38f1d971e5cad224eae184e1117 Mon Sep 17 00:00:00 2001
From: venkat_karasani <venkatnadhkarasani@gmail.com>
Date: Thu, 11 Jul 2024 12:05:57 -0500
Subject: [PATCH 2/2] removed the unused translations from en-us.json

---
 src/strings/en-us.json | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/strings/en-us.json b/src/strings/en-us.json
index 6c6846c289..ffdcd9bfc2 100644
--- a/src/strings/en-us.json
+++ b/src/strings/en-us.json
@@ -325,7 +325,6 @@
     "General": "General",
     "Genre": "Genre",
     "Genres": "Genres",
-    "GetThePlugin": "Get the Plugin",
     "GoHome": "Go Home",
     "GoogleCastUnsupported": "Google Cast Unsupported",
     "GridView": "Grid View",
@@ -1147,8 +1146,6 @@
     "Normal": "Normal",
     "NoSubtitleSearchResultsFound": "No results found.",
     "NoSubtitlesHelp": "Subtitles will not be loaded by default. They can still be turned on manually during playback.",
-    "Notifications": "Notifications",
-    "NotificationsMovedMessage": "The notifications functionality has moved to the Webhook plugin.",
     "NumLocationsValue": "{0} folders",
     "Off": "Off",
     "OnApplicationStartup": "On application startup",