diff --git a/src/components/activitylog.js b/src/components/activitylog.js index bc5ab586c1..bc7d13696d 100644 --- a/src/components/activitylog.js +++ b/src/components/activitylog.js @@ -97,7 +97,7 @@ import alert from './alert'; } instance.items = result.Items; - renderList(elem, apiClient, result, startIndex, limit); + renderList(elem, apiClient, result); }); } diff --git a/src/components/appFooter/appFooter.js b/src/components/appFooter/appFooter.js index 5f16e7c7fb..3aaab8fe54 100644 --- a/src/components/appFooter/appFooter.js +++ b/src/components/appFooter/appFooter.js @@ -10,10 +10,10 @@ function render() { } class appFooter { - constructor(options) { + constructor() { const self = this; - self.element = render(options); + self.element = render(); self.add = function (elem) { self.element.appendChild(elem); }; @@ -33,4 +33,4 @@ class appFooter { } } -export default new appFooter({}); +export default new appFooter(); diff --git a/src/components/backdrop/backdrop.js b/src/components/backdrop/backdrop.js index c91645b574..9403038ae6 100644 --- a/src/components/backdrop/backdrop.js +++ b/src/components/backdrop/backdrop.js @@ -47,7 +47,7 @@ import ServerConnections from '../ServerConnections'; backdropImage.classList.add('backdropImageFadeIn'); parent.appendChild(backdropImage); - if (!enableAnimation(backdropImage)) { + if (!enableAnimation()) { if (existingBackdropImage && existingBackdropImage.parentNode) { existingBackdropImage.parentNode.removeChild(existingBackdropImage); } diff --git a/src/components/homeScreenSettings/homeScreenSettings.js b/src/components/homeScreenSettings/homeScreenSettings.js index 02d0114b30..65bfca1f0a 100644 --- a/src/components/homeScreenSettings/homeScreenSettings.js +++ b/src/components/homeScreenSettings/homeScreenSettings.js @@ -275,12 +275,12 @@ import template from './homeScreenSettings.template.html'; return html; } - function renderPerLibrarySettings(context, user, userViews, userSettings, apiClient) { + function renderPerLibrarySettings(context, user, userViews) { const elem = context.querySelector('.perLibrarySettings'); let html = ''; for (let i = 0, length = userViews.length; i < length; i++) { - html += getPerLibrarySettingsHtml(userViews[i], user, userSettings, apiClient); + html += getPerLibrarySettingsHtml(userViews[i], user); } elem.innerHTML = html; @@ -297,7 +297,7 @@ import template from './homeScreenSettings.template.html'; Promise.all([promise1, promise2]).then(responses => { renderViewOrder(context, user, responses[0]); - renderPerLibrarySettings(context, user, responses[0].Items, userSettings, apiClient); + renderPerLibrarySettings(context, user, responses[0].Items); renderViews(context, user, responses[1]); diff --git a/src/components/homesections/homesections.js b/src/components/homesections/homesections.js index e67f9d7825..83703fc905 100644 --- a/src/components/homesections/homesections.js +++ b/src/components/homesections/homesections.js @@ -140,17 +140,17 @@ import ServerConnections from '../ServerConnections'; if (section === 'latestmedia') { loadRecentlyAdded(elem, apiClient, user, userViews); } else if (section === 'librarytiles' || section === 'smalllibrarytiles' || section === 'smalllibrarytiles-automobile' || section === 'librarytiles-automobile') { - loadLibraryTiles(elem, apiClient, user, userSettings, 'smallBackdrop', userViews, allSections); + loadLibraryTiles(elem, apiClient, user, userSettings, 'smallBackdrop', userViews); } else if (section === 'librarybuttons') { loadlibraryButtons(elem, apiClient, user, userSettings, userViews); } else if (section === 'resume') { - loadResumeVideo(elem, apiClient, userId); + loadResumeVideo(elem, apiClient); } else if (section === 'resumeaudio') { - loadResumeAudio(elem, apiClient, userId); + loadResumeAudio(elem, apiClient); } else if (section === 'activerecordings') { - loadLatestLiveTvRecordings(elem, true, apiClient, userId); + loadLatestLiveTvRecordings(elem, true, apiClient); } else if (section === 'nextup') { - loadNextUp(elem, apiClient, userId); + loadNextUp(elem, apiClient); } else if (section === 'onnow' || section === 'livetv') { return loadOnNow(elem, apiClient, user); } else { diff --git a/src/components/maintabsmanager.js b/src/components/maintabsmanager.js index 995cb5615a..4c5c379ac4 100644 --- a/src/components/maintabsmanager.js +++ b/src/components/maintabsmanager.js @@ -142,7 +142,7 @@ import '../elements/emby-button/emby-button'; tabsElem = tabsContainerElem.querySelector('[is="emby-tabs"]'); - configureSwipeTabs(view, tabsElem, getTabContainersFn); + configureSwipeTabs(view, tabsElem); tabsElem.addEventListener('beforetabchange', function (e) { const tabContainers = getTabContainersFn(); diff --git a/src/components/metadataEditor/metadataEditor.js b/src/components/metadataEditor/metadataEditor.js index f0c3fdc263..49c8eb886f 100644 --- a/src/components/metadataEditor/metadataEditor.js +++ b/src/components/metadataEditor/metadataEditor.js @@ -42,7 +42,7 @@ import template from './metadataEditor.template.html'; toast(globalize.translate('MessageItemSaved')); loading.hide(); - closeDialog(true); + closeDialog(); } const apiClient = getApiClient(); @@ -319,7 +319,7 @@ import template from './metadataEditor.template.html'; bindAll(context.querySelectorAll('.btnCancel'), 'click', function (event) { event.preventDefault(); - closeDialog(false); + closeDialog(); }); context.querySelector('.btnMore').addEventListener('click', function (e) { @@ -1066,15 +1066,15 @@ import template from './metadataEditor.template.html'; currentContext = dlg; - init(dlg, ServerConnections.getApiClient(serverId)); + init(dlg); reload(dlg, itemId, serverId); } export default { show: function (itemId, serverId) { - return new Promise(function (resolve, reject) { - return show(itemId, serverId, resolve, reject); + return new Promise(function (resolve) { + return show(itemId, serverId, resolve); }); }, @@ -1091,7 +1091,7 @@ import template from './metadataEditor.template.html'; currentContext = elem; - init(elem, ServerConnections.getApiClient(serverId)); + init(elem); reload(elem, itemId, serverId); focusManager.autoFocus(elem); diff --git a/src/components/multiSelect/multiSelect.js b/src/components/multiSelect/multiSelect.js index c39690cb89..265ebfec8a 100644 --- a/src/components/multiSelect/multiSelect.js +++ b/src/components/multiSelect/multiSelect.js @@ -440,13 +440,13 @@ import confirm from '../confirm/confirm'; deltaY = 100; } if (deltaX >= 5 || deltaY >= 5) { - onMouseOut(e); + onMouseOut(); } } } - function onTouchEnd(e) { - onMouseOut(e); + function onTouchEnd() { + onMouseOut(); } function onMouseDown(e) { diff --git a/src/components/notifications/notifications.js b/src/components/notifications/notifications.js index 17104cf9bd..e74d5c6f05 100644 --- a/src/components/notifications/notifications.js +++ b/src/components/notifications/notifications.js @@ -77,7 +77,7 @@ function showNotification(options, timeoutMs, apiClient) { resetRegistration(); if (serviceWorkerRegistration) { - showPersistentNotification(title, options, timeoutMs); + showPersistentNotification(title, options); return; } diff --git a/src/components/playback/playbackmanager.js b/src/components/playback/playbackmanager.js index 9f97626e56..2673f5c841 100644 --- a/src/components/playback/playbackmanager.js +++ b/src/components/playback/playbackmanager.js @@ -2048,7 +2048,7 @@ class PlaybackManager { return player.play(options); } - function playWithIntros(items, options, user) { + function playWithIntros(items, options) { let playStartIndex = options.startIndex || 0; let firstItem = items[playStartIndex]; @@ -2065,7 +2065,7 @@ class PlaybackManager { } if (firstItem.MediaType === 'Photo' || firstItem.MediaType === 'Book') { - return playOther(items, options, user); + return playOther(items, options); } const apiClient = ServerConnections.getApiClient(firstItem.ServerId); diff --git a/src/components/recordingcreator/recordingeditor.js b/src/components/recordingcreator/recordingeditor.js index 5472244656..19cec8d88e 100644 --- a/src/components/recordingcreator/recordingeditor.js +++ b/src/components/recordingcreator/recordingeditor.js @@ -79,7 +79,7 @@ function reload(context, id) { const apiClient = ServerConnections.getApiClient(currentServerId); apiClient.getLiveTvTimer(id).then(function (result) { - renderTimer(context, result, apiClient); + renderTimer(context, result); loading.hide(); }); } diff --git a/src/components/recordingcreator/recordingfields.js b/src/components/recordingcreator/recordingfields.js index 35f92d02ea..7ebb2fa9ef 100644 --- a/src/components/recordingcreator/recordingfields.js +++ b/src/components/recordingcreator/recordingfields.js @@ -55,7 +55,7 @@ function fetchData(instance) { instance.TimerId = program.TimerId; instance.Status = program.Status; instance.SeriesTimerId = program.SeriesTimerId; - loadData(options.parent, program, apiClient); + loadData(options.parent, program); }); } diff --git a/src/components/remotecontrol/remotecontrol.js b/src/components/remotecontrol/remotecontrol.js index 543c453071..f38a92b293 100644 --- a/src/components/remotecontrol/remotecontrol.js +++ b/src/components/remotecontrol/remotecontrol.js @@ -727,12 +727,12 @@ export default function () { }); context.querySelector('.btnAudioTracks').addEventListener('click', function (e) { if (currentPlayer && lastPlayerState && lastPlayerState.NowPlayingItem) { - showAudioMenu(context, currentPlayer, e.target, lastPlayerState.NowPlayingItem); + showAudioMenu(context, currentPlayer, e.target); } }); context.querySelector('.btnSubtitles').addEventListener('click', function (e) { if (currentPlayer && lastPlayerState && lastPlayerState.NowPlayingItem) { - showSubtitleMenu(context, currentPlayer, e.target, lastPlayerState.NowPlayingItem); + showSubtitleMenu(context, currentPlayer, e.target); } }); context.querySelector('.btnStop').addEventListener('click', function () { @@ -946,7 +946,7 @@ export default function () { }; self.onShow = function () { - onShow(dlg, window.location.hash); + onShow(dlg); }; self.destroy = function () { diff --git a/src/components/search/searchfields.js b/src/components/search/searchfields.js index 0b5de52576..b3d5ed86af 100644 --- a/src/components/search/searchfields.js +++ b/src/components/search/searchfields.js @@ -89,7 +89,7 @@ import template from './searchfields.template.html'; class SearchFields { constructor(options) { this.options = options; - embed(options.element, this, options); + embed(options.element, this); } focus() { this.options.element.querySelector('.searchfields-txtSearch').focus(); diff --git a/src/components/search/searchresults.js b/src/components/search/searchresults.js index 7a9f1d49f7..78d222623b 100644 --- a/src/components/search/searchresults.js +++ b/src/components/search/searchresults.js @@ -603,7 +603,7 @@ import template from './searchresults.template.html'; class SearchResults { constructor(options) { this.options = options; - embed(options.element, this, options); + embed(options.element, this); } search(value) { const apiClient = ServerConnections.getApiClient(this.options.serverId); diff --git a/src/components/subtitleuploader/subtitleuploader.js b/src/components/subtitleuploader/subtitleuploader.js index 76b595dbb9..500b1706bb 100644 --- a/src/components/subtitleuploader/subtitleuploader.js +++ b/src/components/subtitleuploader/subtitleuploader.js @@ -161,9 +161,9 @@ function showEditor(options, resolve) { } export function show(options) { - return new Promise(function (resolve, reject) { + return new Promise(function (resolve) { hasChanges = false; - showEditor(options, resolve, reject); + showEditor(options, resolve); }); } diff --git a/src/components/syncPlay/ui/players/NoActivePlayer.js b/src/components/syncPlay/ui/players/NoActivePlayer.js index 92d58b2583..fe13d28439 100644 --- a/src/components/syncPlay/ui/players/NoActivePlayer.js +++ b/src/components/syncPlay/ui/players/NoActivePlayer.js @@ -176,7 +176,7 @@ class NoActivePlayer extends SyncPlay.Players.GenericPlayer { if (typeof commandHandler === 'function') { commandHandler(command, player); } else { - defaultAction(command, player); + defaultAction(command); } } diff --git a/src/components/tunerPicker.js b/src/components/tunerPicker.js index 74b1a767bb..ceffc06076 100644 --- a/src/components/tunerPicker.js +++ b/src/components/tunerPicker.js @@ -163,8 +163,7 @@ function tunerPicker() { scrollHelper.centerFocus.on(dlg.querySelector('.formDialogContent'), false); } - const apiClient = ServerConnections.getApiClient(options.serverId); - discoverDevices(dlg, apiClient); + discoverDevices(dlg); if (layoutManager.tv) { scrollHelper.centerFocus.off(dlg.querySelector('.formDialogContent'), false); diff --git a/src/controllers/dashboard/dashboard.js b/src/controllers/dashboard/dashboard.js index 16a5b6a40d..0a04cab682 100644 --- a/src/controllers/dashboard/dashboard.js +++ b/src/controllers/dashboard/dashboard.js @@ -224,11 +224,11 @@ import confirm from '../../components/confirm/confirm'; loading.hide(); } - function pollForInfo(view, apiClient, forceUpdate) { + function pollForInfo(view, apiClient) { apiClient.getSessions({ ActiveWithinSeconds: 960 }).then(function (sessions) { - renderInfo(view, sessions, forceUpdate); + renderInfo(view, sessions); }); apiClient.getScheduledTasks().then(function (tasks) { renderRunningTasks(view, tasks); @@ -745,14 +745,14 @@ import confirm from '../../components/confirm/confirm'; function onPackageInstalling(evt, apiClient) { if (apiClient.serverId() === serverId) { - pollForInfo(view, apiClient, true); + pollForInfo(view, apiClient); reloadSystemInfo(view, apiClient); } } function onPackageInstallationCompleted(evt, apiClient) { if (apiClient.serverId() === serverId) { - pollForInfo(view, apiClient, true); + pollForInfo(view, apiClient); reloadSystemInfo(view, apiClient); } } diff --git a/src/controllers/dashboard/metadatanfo.js b/src/controllers/dashboard/metadatanfo.js index 311ff54567..b0af868582 100644 --- a/src/controllers/dashboard/metadatanfo.js +++ b/src/controllers/dashboard/metadatanfo.js @@ -31,7 +31,7 @@ import alert from '../../components/alert'; config.EnableExtraThumbsDuplication = form.querySelector('#chkEnableExtraThumbs').checked; ApiClient.updateNamedConfiguration(metadataKey, config).then(function () { Dashboard.processServerConfigurationUpdateResult(); - showConfirmMessage(config); + showConfirmMessage(); }); }); return false; diff --git a/src/controllers/dashboard/users/useredit.js b/src/controllers/dashboard/users/useredit.js index cbf8c3f4b5..c45f0c9af3 100644 --- a/src/controllers/dashboard/users/useredit.js +++ b/src/controllers/dashboard/users/useredit.js @@ -146,7 +146,7 @@ import toast from '../../../components/toast/toast'; } ApiClient.updateUser(user).then(function () { ApiClient.updateUserPolicy(user.Id, user.Policy).then(function () { - onSaveComplete(page, user); + onSaveComplete(); }); }); } diff --git a/src/controllers/dashboard/users/userlibraryaccess.js b/src/controllers/dashboard/users/userlibraryaccess.js index da569a5e79..0f68133d89 100644 --- a/src/controllers/dashboard/users/userlibraryaccess.js +++ b/src/controllers/dashboard/users/userlibraryaccess.js @@ -118,7 +118,7 @@ import toast from '../../../components/toast/toast'; user.Policy.BlockedChannels = null; user.Policy.BlockedMediaFolders = null; ApiClient.updateUserPolicy(user.Id, user.Policy).then(function () { - onSaveComplete(page); + onSaveComplete(); }); } diff --git a/src/controllers/dashboard/users/userparentalcontrol.js b/src/controllers/dashboard/users/userparentalcontrol.js index d455861c14..86af9a2377 100644 --- a/src/controllers/dashboard/users/userparentalcontrol.js +++ b/src/controllers/dashboard/users/userparentalcontrol.js @@ -176,7 +176,7 @@ import toast from '../../../components/toast/toast'; user.Policy.AccessSchedules = getSchedulesFromPage(page); user.Policy.BlockedTags = getBlockedTagsFromPage(page); ApiClient.updateUserPolicy(user.Id, user.Policy).then(function () { - onSaveComplete(page); + onSaveComplete(); }); } diff --git a/src/controllers/dashboard/users/userprofilespage.js b/src/controllers/dashboard/users/userprofilespage.js index 0b01907952..7b91692600 100644 --- a/src/controllers/dashboard/users/userprofilespage.js +++ b/src/controllers/dashboard/users/userprofilespage.js @@ -146,14 +146,14 @@ import cardBuilder from '../../../components/cardbuilder/cardBuilder'; return ''; } - function getUserSectionHtml(users, addConnectIndicator) { + function getUserSectionHtml(users) { return users.map(function (u__q) { - return getUserHtml(u__q, addConnectIndicator); + return getUserHtml(u__q); }).join(''); } function renderUsers(page, users) { - page.querySelector('.localUsers').innerHTML = getUserSectionHtml(users, true); + page.querySelector('.localUsers').innerHTML = getUserSectionHtml(users); } function loadData(page) { diff --git a/src/controllers/livetvstatus.js b/src/controllers/livetvstatus.js index 5d49e57c36..397aa50871 100644 --- a/src/controllers/livetvstatus.js +++ b/src/controllers/livetvstatus.js @@ -296,7 +296,7 @@ function onDevicesListClick(e) { $(document).on('pageinit', '#liveTvStatusPage', function () { const page = this; $('.btnAddDevice', page).on('click', function () { - addDevice(this); + addDevice(); }); $('.formAddDevice', page).on('submit', function () { submitAddDeviceForm(page); diff --git a/src/controllers/movies/moviesrecommended.js b/src/controllers/movies/moviesrecommended.js index 918698b860..31b19a5a2f 100644 --- a/src/controllers/movies/moviesrecommended.js +++ b/src/controllers/movies/moviesrecommended.js @@ -222,7 +222,7 @@ import Dashboard from '../../scripts/clientUtils'; const userId = ApiClient.getCurrentUserId(); loadResume(tabContent, userId, parentId); loadLatest(tabContent, userId, parentId); - loadSuggestions(tabContent, userId, parentId); + loadSuggestions(tabContent, userId); } function getTabs() { diff --git a/src/controllers/music/musicalbums.js b/src/controllers/music/musicalbums.js index b9c8161b6f..101debd2a4 100644 --- a/src/controllers/music/musicalbums.js +++ b/src/controllers/music/musicalbums.js @@ -112,7 +112,7 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer'; } window.scrollTo(0, 0); - updateFilterControls(page); + updateFilterControls(); let html; const pagingHtml = libraryBrowser.getQueryPagingHtml({ startIndex: query.StartIndex, @@ -304,7 +304,7 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer'; this.renderTab = function () { reloadItems(tabContent); - updateFilterControls(tabContent); + updateFilterControls(); }; this.destroy = function () {}; diff --git a/src/controllers/playback/video/index.js b/src/controllers/playback/video/index.js index d981153b7d..77ca253812 100644 --- a/src/controllers/playback/video/index.js +++ b/src/controllers/playback/video/index.js @@ -426,7 +426,7 @@ import { appRouter } from '../../../components/appRouter'; if (state.NowPlayingItem) { isEnabled = true; updatePlayerStateInternal(event, player, state); - updatePlaylist(player); + updatePlaylist(); enableStopOnBack(true); } } diff --git a/src/elements/emby-tabs/emby-tabs.js b/src/elements/emby-tabs/emby-tabs.js index be80aa55d5..9f259fe00a 100644 --- a/src/elements/emby-tabs/emby-tabs.js +++ b/src/elements/emby-tabs/emby-tabs.js @@ -19,8 +19,8 @@ import '../../assets/css/scrollstyles.scss'; return null; } - function removeActivePanelClass(tabs, index) { - const tabPanel = getTabPanel(tabs, index); + function removeActivePanelClass() { + const tabPanel = getTabPanel(); if (tabPanel) { tabPanel.classList.remove('is-active'); } @@ -48,10 +48,10 @@ import '../../assets/css/scrollstyles.scss'; } })); if (previousIndex != null && previousIndex !== index) { - removeActivePanelClass(tabs, previousIndex); + removeActivePanelClass(); } - const newPanel = getTabPanel(tabs, index); + const newPanel = getTabPanel(); if (newPanel) { // animate new panel ? diff --git a/src/plugins/sessionPlayer/plugin.js b/src/plugins/sessionPlayer/plugin.js index 0d93f4d235..a165cd54c8 100644 --- a/src/plugins/sessionPlayer/plugin.js +++ b/src/plugins/sessionPlayer/plugin.js @@ -101,7 +101,7 @@ function processUpdatedSessions(instance, sessions, apiClient) { if (session) { normalizeImages(session, apiClient); - const eventNames = getChangedEvents(instance.lastPlayerData, session); + const eventNames = getChangedEvents(instance.lastPlayerData); instance.lastPlayerData = session; for (let i = 0, length = eventNames.length; i < length; i++) {