mirrors/jellyfin-web
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00
Code Activity

Remove redundant variable assignments

Browse source
This commit is contained in:
MrTimscampi 2020-07-30 19:42:30 +02:00
parent e7180e2633
commit a395e6b3d3
6 changed files with 10 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/components/appRouter.js
View file

@ -231,8 +231,7 @@ define(['loading', 'globalize', 'events', 'viewManager', 'skinManager', 'backdro
max /= 8; max /= 8;
max *= 1000000; max *= 1000000;
max *= 0.7; max *= 0.7;
max = parseInt(max); return parseInt(max, 10);
return max;
} }
} }
/* eslint-enable compat/compat */ /* eslint-enable compat/compat */

4
src/components/cardbuilder/chaptercardbuilder.js
View file

@ -104,9 +104,7 @@ import browser from 'browser';
const cardBoxCssClass = 'cardBox'; const cardBoxCssClass = 'cardBox';
const cardScalableClass = 'cardScalable'; const cardScalableClass = 'cardScalable';
const html = `<button type="button" class="${className}"${dataAttributes}><div class="${cardBoxCssClass}"><div class="${cardScalableClass}"><div class="cardPadder-${shape}"></div>${cardImageContainer}</div><div class="innerCardFooter">${nameHtml}</div></div></div></button>`; return `<button type="button" class="${className}"${dataAttributes}><div class="${cardBoxCssClass}"><div class="${cardScalableClass}"><div class="cardPadder-${shape}"></div>${cardImageContainer}</div><div class="innerCardFooter">${nameHtml}</div></div></div></button>`;
return html;
} }
export function buildChapterCards(item, chapters, options) { export function buildChapterCards(item, chapters, options) {

8
src/components/playback/playbackmanager.js
View file

@ -887,9 +887,7 @@ define(['events', 'datetime', 'appSettings', 'itemHelper', 'pluginManager', 'pla
} }
} }
targets = targets.sort(sortPlayerTargets); return targets.sort(sortPlayerTargets);
return targets;
}); });
}); });
}; };
@ -3390,8 +3388,8 @@ define(['events', 'datetime', 'appSettings', 'itemHelper', 'pluginManager', 'pla
PlaybackManager.prototype.getSubtitleUrl = function (textStream, serverId) { PlaybackManager.prototype.getSubtitleUrl = function (textStream, serverId) {
var apiClient = connectionManager.getApiClient(serverId); var apiClient = connectionManager.getApiClient(serverId);
var textStreamUrl = !textStream.IsExternalUrl ? apiClient.getUrl(textStream.DeliveryUrl) : textStream.DeliveryUrl;
return textStreamUrl; return !textStream.IsExternalUrl ? apiClient.getUrl(textStream.DeliveryUrl) : textStream.DeliveryUrl;
}; };
PlaybackManager.prototype.stop = function (player) { PlaybackManager.prototype.stop = function (player) {

11
src/controllers/itemDetails/index.js
View file

@ -38,7 +38,7 @@ define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSetti
} }
function getContextMenuOptions(item, user, button) { function getContextMenuOptions(item, user, button) {
var options = { return {
item: item, item: item,
open: false, open: false,
play: false, play: false,
@ -53,8 +53,6 @@ define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSetti
user: user, user: user,
share: true share: true
}; };
return options;
} }
function getProgramScheduleHtml(items) { function getProgramScheduleHtml(items) {
@ -357,9 +355,8 @@ define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSetti
}); });
html.push('<a style="color:inherit;" class="button-link" is="emby-linkbutton" href="' + href + '">' + artist.Name + '</a>'); html.push('<a style="color:inherit;" class="button-link" is="emby-linkbutton" href="' + href + '">' + artist.Name + '</a>');
} }
html = html.join(' / ');
return html; return html.join(' / ');
} }
/** /**
@ -1729,7 +1726,7 @@ define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSetti
} }
function getVideosHtml(items) { function getVideosHtml(items) {
var html = cardBuilder.getCardsHtml({ return cardBuilder.getCardsHtml({
items: items, items: items,
shape: 'autooverflow', shape: 'autooverflow',
showTitle: true, showTitle: true,
@ -1738,8 +1735,6 @@ define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSetti
centerText: true, centerText: true,
showRuntime: true showRuntime: true
}); });
return html;
} }
function renderSpecials(page, item, user) { function renderSpecials(page, item, user) {

4
src/scripts/dom.js
View file

@ -183,11 +183,9 @@
width = height * (16.0 / 9.0); width = height * (16.0 / 9.0);
} }
const closest = standardWidths.sort(function (a, b) { return standardWidths.sort(function (a, b) {
return Math.abs(width - a) - Math.abs(width - b); return Math.abs(width - a) - Math.abs(width - b);
})[0]; })[0];
return closest;
} }
/** /**

4
src/scripts/libraryMenu.js
View file

@ -604,12 +604,10 @@ define(['dom', 'layoutManager', 'inputManager', 'connectionManager', 'events', '
var icon = i.icon || imageHelper.getLibraryIcon(i.CollectionType); var icon = i.icon || imageHelper.getLibraryIcon(i.CollectionType);
var itemId = i.Id; var itemId = i.Id;
const linkHtml = `<a is="emby-linkbutton" data-itemid="${itemId}" class="lnkMediaFolder navMenuOption" href="${getItemHref(i, i.CollectionType)}"> return `<a is="emby-linkbutton" data-itemid="${itemId}" class="lnkMediaFolder navMenuOption" href="${getItemHref(i, i.CollectionType)}">
<span class="material-icons navMenuOptionIcon ${icon}"></span> <span class="material-icons navMenuOptionIcon ${icon}"></span>
<span class="sectionName navMenuOptionText">${i.Name}</span> <span class="sectionName navMenuOptionText">${i.Name}</span>
</a>`; </a>`;
return linkHtml;
}).join(''); }).join('');
libraryMenuOptions.innerHTML = html; libraryMenuOptions.innerHTML = html;
var elem = libraryMenuOptions; var elem = libraryMenuOptions;