From a6ae6b7c2dff807fffa558e4e7d2e2a29cc05eb5 Mon Sep 17 00:00:00 2001
From: Luke Pulverenti <luke.pulverenti@gmail.com>
Date: Fri, 5 Jul 2013 20:19:44 -0400
Subject: [PATCH] added error handling to image tag generation

---
 dashboard-ui/css/librarybrowser.css      |  7 ++--
 dashboard-ui/edititemmetadata.html       | 41 ++++++++++++------------
 dashboard-ui/library.html                |  2 +-
 dashboard-ui/scripts/addpluginpage.js    |  2 +-
 dashboard-ui/scripts/edititemmetadata.js | 24 ++++++++++++++
 5 files changed, 50 insertions(+), 26 deletions(-)

diff --git a/dashboard-ui/css/librarybrowser.css b/dashboard-ui/css/librarybrowser.css
index eec60d034b..5ab21f8bbe 100644
--- a/dashboard-ui/css/librarybrowser.css
+++ b/dashboard-ui/css/librarybrowser.css
@@ -195,6 +195,10 @@
 }
 
 .starRating + .rottentomatoesicon {
+    margin-left: 1em;
+}
+
+.smallPosterTileItem .starRating + .rottentomatoesicon {
     margin-left: .5em;
 }
 
@@ -621,9 +625,6 @@ a.itemTag:hover {
     color: #fff;
 }
 
-.mediaInfoDetails {
-}
-
 .mediaInfoLabel {
     color: #bbb;
     margin-right: 3px;
diff --git a/dashboard-ui/edititemmetadata.html b/dashboard-ui/edititemmetadata.html
index 3868eb39b1..a7fb7f8cb7 100644
--- a/dashboard-ui/edititemmetadata.html
+++ b/dashboard-ui/edititemmetadata.html
@@ -59,7 +59,7 @@
                                     <label id="lblIndexNumber" for="txtIndexNumber">Number:</label>
                                     <input type="number" id="txtIndexNumber" name="txtIndexNumber" data-mini="true" pattern="[0-9]*" />
                                 </div>
-                                <div data-role="fieldcontain">
+                                <div id="fldCommunityRating" style="display: none;" data-role="fieldcontain">
                                     <label for="txtCommunityRating">Community rating:</label>
                                     <input type="number" id="txtCommunityRating" name="txtCommunityRating" step=".1" data-mini="true" />
                                 </div>
@@ -80,22 +80,22 @@
                                     <textarea name="txtOverview" id="txtOverview" data-mini="true" data-role="fieldcontain"></textarea>
                                 </div>
                                 <div data-role="fieldcontain">
-                                    <label for="txtPremiereDate">Release date:</label>
+                                    <label id="lblPremiereDate" for="txtPremiereDate">Release date:</label>
                                     <input type="date" id="txtPremiereDate" name="txtPremiereDate" data-mini="true" />
                                 </div>
-                                <div data-role="fieldcontain" id="fldEndDate" style="display: none;">
-                                    <label for="txtEndDate">End date:</label>
-                                    <input type="date" id="txtEndDate" name="txtEndDate" data-mini="true" />
-                                </div>
                                 <div data-role="fieldcontain">
-                                    <label for="txtProductionYear">Year:</label>
+                                    <label id="lblYear" for="txtProductionYear">Year:</label>
                                     <input type="number" id="txtProductionYear" name="txtProductionYear" data-mini="true" />
                                 </div>
+                                <div data-role="fieldcontain" id="fldEndDate" style="display: none;">
+                                    <label id="lblEndDate" for="txtEndDate">End date:</label>
+                                    <input type="date" id="txtEndDate" name="txtEndDate" data-mini="true" />
+                                </div>
                                 <div data-role="fieldcontain" id="fldAirDays" style="display: none;">
                                     <label for="selectAirDays">Air Days:</label>
                                     <div data-role="editableListviewContainer" style="width: 78%; display: inline-block;">
                                         <div>
-                                            <select name="selectAirDays" Id="selectAirDays" data-mini="true">
+                                            <select name="selectAirDays" id="selectAirDays" data-mini="true">
                                                 <option value=''></option>
                                                 <option value='Monday'>Monday</option>
                                                 <option value='Tuesday'>Tuesday</option>
@@ -104,22 +104,22 @@
                                                 <option value='Friday'>Friday</option>
                                                 <option value='Saturday'>Saturday</option>
                                                 <option value='Sunday'>Sunday</option>
-                                            </select>  
-                                            <a data-role="button" data-theme="b" data-inline="true" data-mini="true" data-icon="plus"  onclick="EditItemMetadataPage.addElementToEditableListview(this,EditItemMetadataPage.sortDaysOfTheWeek)">Add</a>
+                                            </select>
+                                            <a data-role="button" data-theme="b" data-inline="true" data-mini="true" data-icon="plus" onclick="EditItemMetadataPage.addElementToEditableListview(this,EditItemMetadataPage.sortDaysOfTheWeek)">Add</a>
                                         </div>
                                         <ul data-role="listview" data-inset="true" data-split-icon="delete" id="listAirDays"></ul>
                                     </div>
-                                    
+
                                 </div>
                                 <div data-role="fieldcontain" id="fldAirTime" style="display: none;">
                                     <label for="txtAirTime">Air Time:</label>
                                     <input type="time" id="txtAirTime" name="txtAirTime" data-mini="true" />
                                 </div>
-                                <div data-role="fieldcontain">
+                                <div data-role="fieldcontain" id="fldOfficialRating" style="display: none;">
                                     <label for="selectOfficialRating">Official rating:</label>
                                     <select name="selectOfficialRating" id="selectOfficialRating" data-mini="true"></select>
                                 </div>
-                                <div data-role="fieldcontain">
+                                <div data-role="fieldcontain" id="fldCustomRating" style="display: none;">
                                     <label for="selectCustomRating">Custom rating:</label>
                                     <select name="selectCustomRating" id="selectCustomRating" data-mini="true"></select>
                                 </div>
@@ -145,21 +145,21 @@
                                 </div>
                             </div>
                         </div>
-                        <div data-role="collapsible">
+                        <div data-role="collapsible" id="genresCollapsible" style="display: none;">
                             <h3>Genres</h3>
                             <div data-role="editableListviewContainer">
                                 <div data-role="fieldcontain">
-                                    <input type="text" data-mini="true" />    
-                                    <a data-role="button" data-theme="b" data-inline="true" data-mini="true" data-icon="plus"  onclick="EditItemMetadataPage.addElementToEditableListview(this)">Add</a>
+                                    <input type="text" data-mini="true" />
+                                    <a data-role="button" data-theme="b" data-inline="true" data-mini="true" data-icon="plus" onclick="EditItemMetadataPage.addElementToEditableListview(this)">Add</a>
                                 </div>
                                 <ul data-role="listview" data-inset="true" data-split-icon="delete" id="listGenres"></ul>
                             </div>
                         </div>
-                        <div data-role="collapsible">
+                        <div data-role="collapsible" id="studiosCollapsible" style="display: none;">
                             <h3>Studios</h3>
                             <div data-role="editableListviewContainer">
                                 <div data-role="fieldcontain">
-                                    <input type="text" data-mini="true" />    
+                                    <input type="text" data-mini="true" />
                                     <a data-role="button" data-theme="b" data-inline="true" data-mini="true" data-icon="plus" onclick="EditItemMetadataPage.addElementToEditableListview(this)">Add</a>
                                 </div>
                                 <ul data-role="listview" data-inset="true" data-split-icon="delete" id="listStudios"></ul>
@@ -169,7 +169,7 @@
                             <h3>Tags</h3>
                             <div data-role="editableListviewContainer">
                                 <div data-role="fieldcontain">
-                                    <input type="text" data-mini="true" />    
+                                    <input type="text" data-mini="true" />
                                     <a data-role="button" data-theme="b" data-inline="true" data-mini="true" data-icon="plus" onclick="EditItemMetadataPage.addElementToEditableListview(this)">Add</a>
                                 </div>
                                 <ul data-role="listview" data-inset="true" data-split-icon="delete" id="listTags"></ul>
@@ -216,11 +216,10 @@
                             <h3>Internet Provider Settings</h3>
                             <div>
                                 <div data-role="fieldcontain">
-                                    <input type="checkbox" name="enableInternetProviders" id="enableInternetProviders" onchange="EditItemMetadataPage.setProviderSettingsContainerVisibility(this)"/>
+                                    <input type="checkbox" name="enableInternetProviders" id="enableInternetProviders" onchange="EditItemMetadataPage.setProviderSettingsContainerVisibility(this)" />
                                     <label for="enableInternetProviders">Enable internet metadata providers for this item.</label>
                                 </div>
                                 <div id="providerSettingsContainer" style="display: none">
-                                    
                                 </div>
                             </div>
                         </div>
diff --git a/dashboard-ui/library.html b/dashboard-ui/library.html
index 7d97b3acf5..3aadb835b6 100644
--- a/dashboard-ui/library.html
+++ b/dashboard-ui/library.html
@@ -32,7 +32,7 @@
                     </div>
                 </div>
                 <p>Read <a href="https://github.com/MediaBrowser/MediaBrowser/wiki/Library-Structure" target="_blank">media library wiki.</a></p>
-                <p>Configure images by <a href="index.html">browsing and editing.</a></p>
+                <p>Configure images and change sort orders by <a href="itemlist.html">browsing and editing.</a></p>
             </div>
         </div>
         <div data-role="popup" id="popupEnterText" class="ui-corner-all popup">
diff --git a/dashboard-ui/scripts/addpluginpage.js b/dashboard-ui/scripts/addpluginpage.js
index 2feb2c6f66..1ed2acc338 100644
--- a/dashboard-ui/scripts/addpluginpage.js
+++ b/dashboard-ui/scripts/addpluginpage.js
@@ -168,7 +168,7 @@
 
             var color = pkg.tileColor || "#2572EB";
             var img = pkg.previewImage ? pkg.previewImage : pkg.thumbImage;
-            $('#pPreviewImage', page).show().html("<img src='" + img + "' style='max-width: 100%;border-radius:10px;-moz-box-shadow: 0 0 20px 3px " + color + ";-webkit-box-shadow: 0 0 20px 3px " + color + ";box-shadow: 0 0 20px 3px " + color + ";' />");
+            $('#pPreviewImage', page).show().html("<img src='" + img + "' style='max-width: 100%;-moz-box-shadow: 0 0 20px 3px " + color + ";-webkit-box-shadow: 0 0 20px 3px " + color + ";box-shadow: 0 0 20px 3px " + color + ";' />");
         } else {
             $('#pPreviewImage', page).hide().html("");
         }
diff --git a/dashboard-ui/scripts/edititemmetadata.js b/dashboard-ui/scripts/edititemmetadata.js
index ebf75f25d4..05e5a22e54 100644
--- a/dashboard-ui/scripts/edititemmetadata.js
+++ b/dashboard-ui/scripts/edititemmetadata.js
@@ -165,6 +165,30 @@
             $('#fldMusicBrainzReleaseGroupId', page).hide();
         }
 
+        if (item.Type == "Person" || item.Type == "Genre" || item.Type == "Studio" || item.Type == "GameGenre" || item.Type == "MusicGenre") {
+            $('#fldCommunityRating', page).hide();
+            $('#fldOfficialRating', page).hide();
+            $('#fldCustomRating', page).hide();
+            $('#genresCollapsible', page).hide();
+            $('#studiosCollapsible', page).hide();
+        } else {
+            $('#fldCommunityRating', page).show();
+            $('#fldOfficialRating', page).show();
+            $('#fldCustomRating', page).show();
+            $('#genresCollapsible', page).show();
+            $('#studiosCollapsible', page).show();
+        }
+
+        if (item.Type == "Person") {
+            $('#lblPremiereDate', page).html('Date of birth');
+            $('#lblYear', page).html('Birth year');
+            $('#lblEndDate', page).html('Death date');
+        } else {
+            $('#lblPremiereDate', page).html('Release date');
+            $('#lblYear', page).html('Year');
+            $('#lblEndDate', page).html('End date');
+        }
+
         if (item.MediaType == "Video") {
             $('#fldOriginalAspectRatio', page).show();
         } else {