From 8334a7de3368965b23a777f45b7c71c63a5a9d86 Mon Sep 17 00:00:00 2001 From: Dmitry Lyzo Date: Sat, 15 Oct 2022 23:26:25 +0300 Subject: [PATCH 1/3] fix button group position on ItemDetails page --- src/assets/css/librarybrowser.scss | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/assets/css/librarybrowser.scss b/src/assets/css/librarybrowser.scss index 319c629fe5..254127231e 100644 --- a/src/assets/css/librarybrowser.scss +++ b/src/assets/css/librarybrowser.scss @@ -810,6 +810,14 @@ padding-left: 32.45vw; } +.layout-tv [dir="rtl"] .detailPagePrimaryContainer { + padding-right: 32.45vw; +} + +.layout-tv [dir="ltr"] .detailPagePrimaryContainer { + padding-left: 32.45vw; +} + .layout-desktop .detailRibbon { margin-top: -7.2em; height: 7.2em; From 39879baefec90919ab86adf3e1e53f980bcfa174 Mon Sep 17 00:00:00 2001 From: Dmitry Lyzo Date: Sun, 16 Oct 2022 00:06:54 +0300 Subject: [PATCH 2/3] fix HTML escaping --- src/components/listview/listview.js | 2 +- src/controllers/itemDetails/index.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/listview/listview.js b/src/components/listview/listview.js index d6c34172f8..eaa526dbd4 100644 --- a/src/components/listview/listview.js +++ b/src/components/listview/listview.js @@ -149,7 +149,7 @@ import ServerConnections from '../ServerConnections'; elem.classList.add('listItemBodyText'); - elem.innerHTML = '' + text + ''; + elem.innerHTML = '' + escapeHtml(text) + ''; html += elem.outerHTML; } diff --git a/src/controllers/itemDetails/index.js b/src/controllers/itemDetails/index.js index 1de235ffe3..6e238a7045 100644 --- a/src/controllers/itemDetails/index.js +++ b/src/controllers/itemDetails/index.js @@ -1068,7 +1068,7 @@ function renderTagline(page, item) { if (item.Taglines && item.Taglines.length) { taglineElement.classList.remove('hide'); - taglineElement.innerHTML = '' + item.Taglines[0] + ''; + taglineElement.innerHTML = '' + escapeHtml(item.Taglines[0]) + ''; } else { taglineElement.classList.add('hide'); } From 2b8d0de344d0f67b8544c6115b6c880c6ead7459 Mon Sep 17 00:00:00 2001 From: Dmitry Lyzo Date: Sun, 16 Oct 2022 00:08:31 +0300 Subject: [PATCH 3/3] fix listview and actionsheet items --- src/components/listview/listview.scss | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/components/listview/listview.scss b/src/components/listview/listview.scss index 9270331252..33a5ceadd1 100644 --- a/src/components/listview/listview.scss +++ b/src/components/listview/listview.scss @@ -14,7 +14,6 @@ font-family: inherit; font-size: inherit; margin: 0; - display: block; align-items: center; cursor: pointer; overflow: hidden; @@ -56,7 +55,6 @@ } .listItem-border { - display: block; margin: 0; padding: 0; border-width: 0 0 0.1em 0;