From b39889b34445f663377534d18e55e412147fdfe5 Mon Sep 17 00:00:00 2001 From: TheMelmacian <76712303+TheMelmacian@users.noreply.github.com> Date: Sun, 19 May 2024 21:43:10 +0200 Subject: [PATCH] fix: 'ActionSheet closed without resolving' error prevent error when ActionSheet dialog is closed without selection --- src/controllers/playback/video/index.js | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/controllers/playback/video/index.js b/src/controllers/playback/video/index.js index 5ebedb0b19..a32a43984e 100644 --- a/src/controllers/playback/video/index.js +++ b/src/controllers/playback/video/index.js @@ -982,6 +982,8 @@ export default function (view) { stats: true, suboffset: showSubOffset, onOption: onSettingsOption + }).catch(() => { + // prevent 'ActionSheet closed without resolving' error }).finally(() => { resetIdle(); }); @@ -1055,6 +1057,8 @@ export default function (view) { if (index !== currentIndex) { playbackManager.setAudioStreamIndex(index, player); } + }).catch(() => { + // prevent 'ActionSheet closed without resolving' error }).finally(() => { resetIdle(); }); @@ -1102,10 +1106,11 @@ export default function (view) { playbackManager.setSecondarySubtitleStreamIndex(index, player); } } - }) - .finally(() => { - resetIdle(); - }); + }).catch(() => { + // prevent 'ActionSheet closed without resolving' error + }).finally(() => { + resetIdle(); + }); setTimeout(resetIdle, 0); } @@ -1182,6 +1187,8 @@ export default function (view) { } toggleSubtitleSync(); + }).catch(() => { + // prevent 'ActionSheet closed without resolving' error }).finally(() => { resetIdle(); }); @@ -1217,7 +1224,9 @@ export default function (view) { scrollY: true }).then( chapterStartPositionTicks => playbackManager.seek(chapterStartPositionTicks, player) - ).finally(() => { + ).catch(() => { + // prevent 'ActionSheet closed without resolving' error + }).finally(() => { resetIdle(); });