From b65bd915ee51864cfc6bcd53a2f82a9168f78b7f Mon Sep 17 00:00:00 2001
From: Bill Thornton <billt2006@gmail.com>
Date: Sun, 22 Mar 2020 01:07:04 -0400
Subject: [PATCH] Simplify show/hide button logic for tv providers

---
 src/components/tvproviders/schedulesdirect.js | 18 +++++-------------
 src/components/tvproviders/xmltv.js           | 18 +++++-------------
 2 files changed, 10 insertions(+), 26 deletions(-)

diff --git a/src/components/tvproviders/schedulesdirect.js b/src/components/tvproviders/schedulesdirect.js
index 4a6f3d297f..cf11e5736d 100644
--- a/src/components/tvproviders/schedulesdirect.js
+++ b/src/components/tvproviders/schedulesdirect.js
@@ -264,21 +264,13 @@ define(["jQuery", "loading", "emby-checkbox", "listViewStyle", "emby-input", "em
         self.init = function () {
             options = options || {};
 
-            // Only hide the button if explicitly set to false; default to showing if undefined or null
+            // Only hide the buttons if explicitly set to false; default to showing if undefined or null
             // FIXME: rename this option to clarify logic
-            if (options.showCancelButton === false) {
-                page.querySelector(".btnCancel").classList.add("hide");
-            } else {
-                page.querySelector(".btnCancel").classList.remove("hide");
-            }
+            var hideCancelButton = options.showCancelButton === false;
+            page.querySelector(".btnCancel").classList.toggle("hide", hideCancelButton);
 
-            // Only hide the button if explicitly set to false; default to showing if undefined or null
-            // FIXME: rename this option to clarify logic
-            if (options.showSubmitButton === false) {
-                page.querySelector(".btnSubmitListings").classList.add("hide");
-            } else {
-                page.querySelector(".btnSubmitListings").classList.remove("hide");
-            }
+            var hideSubmitButton = options.showSubmitButton === false;
+            page.querySelector(".btnSubmitListings").classList.toggle("hide", hideSubmitButton);
 
             $(".formLogin", page).on("submit", function () {
                 submitLoginForm();
diff --git a/src/components/tvproviders/xmltv.js b/src/components/tvproviders/xmltv.js
index 0ba164fe25..7e7d381f09 100644
--- a/src/components/tvproviders/xmltv.js
+++ b/src/components/tvproviders/xmltv.js
@@ -163,21 +163,13 @@ define(["jQuery", "loading", "emby-checkbox", "emby-input", "listViewStyle", "pa
         self.init = function () {
             options = options || {};
 
-            // Only hide the button if explicitly set to false; default to showing if undefined or null
+            // Only hide the buttons if explicitly set to false; default to showing if undefined or null
             // FIXME: rename this option to clarify logic
-            if (options.showCancelButton === false) {
-                page.querySelector(".btnCancel").classList.add("hide");
-            } else {
-                page.querySelector(".btnCancel").classList.remove("hide");
-            }
+            var hideCancelButton = options.showCancelButton === false;
+            page.querySelector(".btnCancel").classList.toggle("hide", hideCancelButton);
 
-            // Only hide the button if explicitly set to false; default to showing if undefined or null
-            // FIXME: rename this option to clarify logic
-            if (options.showSubmitButton === false) {
-                page.querySelector(".btnSubmitListings").classList.add("hide");
-            } else {
-                page.querySelector(".btnSubmitListings").classList.remove("hide");
-            }
+            var hideSubmitButton = options.showSubmitButton === false;
+            page.querySelector(".btnSubmitListings").classList.toggle("hide", hideSubmitButton);
 
             $("form", page).on("submit", function () {
                 submitListingsForm();