mirrors/jellyfin-web
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00
Code Activity

refactor: Move queries into loops

Browse source
This commit is contained in:
Dmitry Lyzo 2023-10-04 00:09:31 +03:00
parent bab1fd7bb9
commit b81342d23b
1 changed files with 13 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

36
src/components/filtermenu/filtermenu.js
View file

@ -103,35 +103,27 @@ function onInputCommand(e) {
} }
} }
function saveValues(context, settings, settingsKey, setfilters) { function saveValues(context, settings, settingsKey, setfilters) {
let elems;
// Video type // Video type
const videoTypes = []; const videoTypes = [];
elems = context.querySelectorAll('.chkVideoTypeFilter'); for (const elem of context.querySelectorAll('.chkVideoTypeFilter')) {
if (elem.checked) {
for (let i = 0, length = elems.length; i < length; i++) { videoTypes.push(elem.getAttribute('data-filter'));
if (elems[i].checked) {
videoTypes.push(elems[i].getAttribute('data-filter'));
} }
} }
// Series status // Series status
const seriesStatuses = []; const seriesStatuses = [];
elems = context.querySelectorAll('.chkSeriesStatus'); for (const elem of context.querySelectorAll('.chkSeriesStatus')) {
if (elem.checked) {
for (let i = 0, length = elems.length; i < length; i++) { seriesStatuses.push(elem.getAttribute('data-filter'));
if (elems[i].checked) {
seriesStatuses.push(elems[i].getAttribute('data-filter'));
} }
} }
// Genres // Genres
const genres = []; const genres = [];
elems = context.querySelectorAll('.chkGenreFilter'); for (const elem of context.querySelectorAll('.chkGenreFilter')) {
if (elem.checked) {
for (let i = 0, length = elems.length; i < length; i++) { genres.push(elem.getAttribute('data-filter'));
if (elems[i].checked) {
genres.push(elems[i].getAttribute('data-filter'));
} }
} }
@ -157,13 +149,11 @@ function saveValues(context, settings, settingsKey, setfilters) {
GenreIds: genres.join(',') GenreIds: genres.join(',')
})); }));
} else { } else {
elems = context.querySelectorAll('.simpleFilter'); for (const elem of context.querySelectorAll('.simpleFilter')) {
if (elem.tagName === 'INPUT') {
for (let i = 0, length = elems.length; i < length; i++) { setBasicFilter(context, settingsKey + '-filter-' + elem.getAttribute('data-settingname'), elem);
if (elems[i].tagName === 'INPUT') {
setBasicFilter(context, settingsKey + '-filter-' + elems[i].getAttribute('data-settingname'), elems[i]);
} else { } else {
setBasicFilter(context, settingsKey + '-filter-' + elems[i].getAttribute('data-settingname'), elems[i].querySelector('input')); setBasicFilter(context, settingsKey + '-filter-' + elem.getAttribute('data-settingname'), elem.querySelector('input'));
} }
} }