1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00

add suggested changes from code review

This commit is contained in:
dkanada 2019-01-24 22:26:24 +09:00
parent c51d005a4d
commit b9d06ebf62

View file

@ -108,11 +108,18 @@ define(["appSettings", "browser", "events", "htmlMediaHelper"], function(appSett
} }
function onAppVisible() { function onAppVisible() {
isHidden && (isHidden = false, console.log("triggering app resume event"), events.trigger(appHost, "resume")); if (isHidden) {
isHidden = false;
console.log("triggering app resume event");
events.trigger(appHost, "resume");
}
} }
function onAppHidden() { function onAppHidden() {
isHidden || (isHidden = true, console.log("app is hidden")); if (!isHidden) {
isHidden = true;
console.log("app is hidden");
}
} }
var htmlMediaAutoplayAppStorageKey = "supportshtmlmediaautoplay0"; var htmlMediaAutoplayAppStorageKey = "supportshtmlmediaautoplay0";
@ -141,7 +148,7 @@ define(["appSettings", "browser", "events", "htmlMediaHelper"], function(appSett
browser.chrome && features.push("chromecast"); browser.chrome && features.push("chromecast");
return features; return features;
}(); }();
if (supportedFeatures.indexOf("htmlvideoautoplay") === -1 && supportsHtmlMediaAutoplay() !=== false) { if (supportedFeatures.indexOf("htmlvideoautoplay") === -1 && supportsHtmlMediaAutoplay() !== false) {
require(["autoPlayDetect"], function(autoPlayDetect) { require(["autoPlayDetect"], function(autoPlayDetect) {
autoPlayDetect.supportsHtmlMediaAutoplay().then(function() { autoPlayDetect.supportsHtmlMediaAutoplay().then(function() {
appSettings.set(htmlMediaAutoplayAppStorageKey, "true"); appSettings.set(htmlMediaAutoplayAppStorageKey, "true");
@ -218,8 +225,14 @@ define(["appSettings", "browser", "events", "htmlMediaHelper"], function(appSett
var doc = self.document; var doc = self.document;
doc && (void 0 !== doc.visibilityState ? (visibilityChange = "visibilitychange", visibilityState = "hidden") : void 0 !== doc.mozHidden ? (visibilityChange = "mozvisibilitychange", visibilityState = "mozVisibilityState") : void 0 !== doc.msHidden ? (visibilityChange = "msvisibilitychange", visibilityState = "msVisibilityState") : void 0 !== doc.webkitHidden && (visibilityChange = "webkitvisibilitychange", visibilityState = "webkitVisibilityState")); doc && (void 0 !== doc.visibilityState ? (visibilityChange = "visibilitychange", visibilityState = "hidden") : void 0 !== doc.mozHidden ? (visibilityChange = "mozvisibilitychange", visibilityState = "mozVisibilityState") : void 0 !== doc.msHidden ? (visibilityChange = "msvisibilitychange", visibilityState = "msVisibilityState") : void 0 !== doc.webkitHidden && (visibilityChange = "webkitvisibilitychange", visibilityState = "webkitVisibilityState"));
var isHidden = false; var isHidden = false;
doc && doc.addEventListener(visibilityChange, function() { if (doc) {
document[visibilityState] ? onAppHidden() : onAppVisible() doc.addEventListener(visibilityChange, function() {
}), self.addEventListener && (self.addEventListener("focus", onAppVisible), self.addEventListener("blur", onAppHidden)); document[visibilityState] ? onAppHidden() : onAppVisible()
});
}
if (self.addEventListener) {
self.addEventListener("focus", onAppVisible);
self.addEventListener("blur", onAppHidden);
}
return appHost; return appHost;
}); });