mirrors/jellyfin-web
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00
Code Activity

Reduce cognitive complexity

Browse source
This commit is contained in:
Robert Down 2025-02-24 22:21:11 -05:00
parent 0f846957c1
commit bd62fe4476
1 changed files with 23 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

38
src/components/guide/guide.js
View file

@ -591,9 +591,6 @@ function Guide(options) {
let html = ''; let html = '';
for (const channel of channels) { for (const channel of channels) {
const hasChannelLogo = channel.ImageTags.Logo;
const hasChannelPrimary = channel.ImageTags.Primary;
let cssClass = 'guide-channelHeaderCell itemAction'; let cssClass = 'guide-channelHeaderCell itemAction';
if (layoutManager.tv) { if (layoutManager.tv) {
@ -610,24 +607,16 @@ function Guide(options) {
html += '<button title="' + escapeHtml(title.join(' ')) + '" type="button" class="' + cssClass + '"' + ' data-action="link" data-isfolder="' + channel.IsFolder + '" data-id="' + channel.Id + '" data-serverid="' + channel.ServerId + '" data-type="' + channel.Type + '">'; html += '<button title="' + escapeHtml(title.join(' ')) + '" type="button" class="' + cssClass + '"' + ' data-action="link" data-isfolder="' + channel.IsFolder + '" data-id="' + channel.Id + '" data-serverid="' + channel.ServerId + '" data-type="' + channel.Type + '">';
const hasChannelImage = hasChannelLogo || hasChannelPrimary; const channelImageUrl = renderChannelImageUrl(channel, apiClient);
if (hasChannelImage) { if (channelImageUrl) {
const imgType = hasChannelLogo ? 'Logo' : 'Primary'; html += '<div class="guideChannelImage lazy" data-src="' + channelImageUrl + '"></div>';
const imgTag = hasChannelLogo ? channel.ImageTags.Logo : channel.ImageTags.Primary;
const url = apiClient.getScaledImageUrl(channel.Id, {
maxHeight: 220,
tag: imgTag,
type: imgType
});
html += '<div class="guideChannelImage lazy" data-src="' + url + '"></div>';
} }
if (channel.ChannelNumber) { if (channel.ChannelNumber) {
html += '<h3 class="guideChannelNumber">' + channel.ChannelNumber + '</h3>'; html += '<h3 class="guideChannelNumber">' + channel.ChannelNumber + '</h3>';
} }
if (!hasChannelImage && channel.Name) { if (!channelImageUrl && channel.Name) {
html += '<div class="guideChannelName">' + escapeHtml(channel.Name) + '</div>'; html += '<div class="guideChannelName">' + escapeHtml(channel.Name) + '</div>';
} }
@ -639,6 +628,25 @@ function Guide(options) {
imageLoader.lazyChildren(channelList); imageLoader.lazyChildren(channelList);
} }
function renderChannelImageUrl(channel, apiClient) {
const hasChannelLogo = channel.ImageTags.Logo;
const hasChannelPrimary = channel.ImageTags.Primary;
if (!hasChannelLogo && !hasChannelPrimary) {
return false;
}
const imgType = hasChannelLogo ? 'Logo' : 'Primary';
const imgTag = hasChannelLogo ? channel.ImageTags.Logo : channel.ImageTags.Primary;
const url = apiClient.getScaledImageUrl(channel.Id, {
maxHeight: 220,
tag: imgTag,
type: imgType
});
return url;
}
function renderPrograms(context, date, channels, programs, programOptions) { function renderPrograms(context, date, channels, programs, programOptions) {
const listInfo = { const listInfo = {
startIndex: 0 startIndex: 0