From be26da26f82d49f02f12c8c2774831c153896bfd Mon Sep 17 00:00:00 2001
From: gnattu <gnattuoc@me.com>
Date: Thu, 29 Feb 2024 09:33:54 +0800
Subject: [PATCH] feat: add VideoToolbox Tone mapping support

This also hides AV1 encoding from VideoToolbox option to not confuse our user.
---
 src/controllers/dashboard/encodingsettings.html | 12 +++++++++++-
 src/controllers/dashboard/encodingsettings.js   | 14 +++++++++++++-
 src/strings/en-us.json                          |  2 ++
 3 files changed, 26 insertions(+), 2 deletions(-)

diff --git a/src/controllers/dashboard/encodingsettings.html b/src/controllers/dashboard/encodingsettings.html
index 330dac8a1a..37d92d6a03 100644
--- a/src/controllers/dashboard/encodingsettings.html
+++ b/src/controllers/dashboard/encodingsettings.html
@@ -129,7 +129,7 @@
                             <span>${AllowHevcEncoding}</span>
                         </label>
                     </div>
-                    <div class="checkboxList">
+                    <div class="checkboxList allowAv1EncodingOption">
                         <label>
                             <input type="checkbox" is="emby-checkbox" id="chkAllowAv1Encoding" />
                             <span>${AllowAv1Encoding}</span>
@@ -155,6 +155,16 @@
                     </div>
                 </div>
 
+                <div class="videoToolboxTonemappingOptions hide">
+                    <div class="checkboxListContainer checkboxContainer-withDescription">
+                        <label>
+                            <input type="checkbox" is="emby-checkbox" id="chkVideoToolboxTonemapping" />
+                            <span>${EnableVideoToolboxTonemapping}</span>
+                        </label>
+                        <div class="fieldDescription checkboxFieldDescription">${AllowVideoToolboxTonemappingHelp}</div>
+                    </div>
+                </div>
+
                 <div class="tonemappingOptions hide">
                     <div class="checkboxListContainer checkboxContainer-withDescription">
                         <label>
diff --git a/src/controllers/dashboard/encodingsettings.js b/src/controllers/dashboard/encodingsettings.js
index 3d434df7f6..8ca9f0fae9 100644
--- a/src/controllers/dashboard/encodingsettings.js
+++ b/src/controllers/dashboard/encodingsettings.js
@@ -32,6 +32,7 @@ function loadPage(page, config, systemInfo) {
     $('#txtVaapiDevice', page).val(config.VaapiDevice || '');
     page.querySelector('#chkTonemapping').checked = config.EnableTonemapping;
     page.querySelector('#chkVppTonemapping').checked = config.EnableVppTonemapping;
+    page.querySelector('#chkVideoToolboxTonemapping').checked = config.EnableVideoToolboxTonemapping;
     page.querySelector('#selectTonemappingAlgorithm').value = config.TonemappingAlgorithm;
     page.querySelector('#selectTonemappingMode').value = config.TonemappingMode;
     page.querySelector('#selectTonemappingRange').value = config.TonemappingRange;
@@ -93,6 +94,7 @@ function onSubmit() {
             config.VaapiDevice = $('#txtVaapiDevice', form).val();
             config.EnableTonemapping = form.querySelector('#chkTonemapping').checked;
             config.EnableVppTonemapping = form.querySelector('#chkVppTonemapping').checked;
+            config.EnableVideoToolboxTonemapping = form.querySelector('#chkVideoToolboxTonemapping').checked;
             config.TonemappingAlgorithm = form.querySelector('#selectTonemappingAlgorithm').value;
             config.TonemappingMode = form.querySelector('#selectTonemappingMode').value;
             config.TonemappingRange = form.querySelector('#selectTonemappingRange').value;
@@ -206,7 +208,7 @@ $(document).on('pageinit', '#encodingSettingsPage', function () {
             page.querySelector('.fld10bitHevcVp9HwDecoding').classList.add('hide');
         }
 
-        if (this.value == 'amf' || this.value == 'nvenc' || this.value == 'qsv' || this.value == 'vaapi' || this.value == 'rkmpp') {
+        if (this.value == 'amf' || this.value == 'nvenc' || this.value == 'qsv' || this.value == 'vaapi' || this.value == 'rkmpp' || this.value == 'videotoolbox') {
             page.querySelector('.tonemappingOptions').classList.remove('hide');
         } else {
             page.querySelector('.tonemappingOptions').classList.add('hide');
@@ -218,6 +220,16 @@ $(document).on('pageinit', '#encodingSettingsPage', function () {
             page.querySelector('.fldIntelLp').classList.add('hide');
         }
 
+        if ((this.value == 'videotoolbox')) {
+            page.querySelector('.videoToolboxTonemappingOptions').classList.remove('hide');
+        } else {
+            page.querySelector('.videoToolboxTonemappingOptions').classList.add('hide');
+        }
+
+        if ((this.value == 'videotoolbox')) {
+            page.querySelector('.allowAv1EncodingOption').classList.add('hide');
+        }
+
         if (systemInfo.OperatingSystem.toLowerCase() === 'linux' && (this.value == 'qsv' || this.value == 'vaapi')) {
             page.querySelector('.vppTonemappingOptions').classList.remove('hide');
         } else {
diff --git a/src/strings/en-us.json b/src/strings/en-us.json
index c7a6fe5edf..8abe8c1a9e 100644
--- a/src/strings/en-us.json
+++ b/src/strings/en-us.json
@@ -1660,6 +1660,8 @@
     "EnableEnhancedNvdecDecoder": "Enable enhanced NVDEC decoder",
     "EnableVppTonemapping": "Enable VPP Tone mapping",
     "AllowVppTonemappingHelp": "Full Intel driver based tone-mapping. Currently works only on certain hardware with HDR10 videos. This has a higher priority compared to another OpenCL implementation.",
+    "EnableVideoToolboxTonemapping": "Enable VideoToolbox Tone mapping",
+    "AllowVideoToolboxTonemappingHelp": "Hardware-accelerated tone-mapping provided by VideoToolbox. It works with most HDR formats, including HDR10, HDR10+, and HLG, but does not work with Dolby Vision Profile 5. This has a higher priority compared to another OpenCL implementation.",
     "Controls": "Controls",
     "LabelEnableGamepad": "Enable Gamepad",
     "EnableGamepadHelp": "Listen for input from any connected controllers. (Requires: 'TV' Display Mode)",