mirrors/jellyfin-web
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00
Code Activity

apply suggestions from code review

Browse source 
Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
This commit is contained in:
dkanada 2019-03-20 14:48:59 -07:00 • committed by GitHub
parent 65fafe9c58
commit bf95e6016f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/scripts/itemdetailpage.js
View file

@ -281,10 +281,22 @@ define(["loading", "appRouter", "layoutManager", "connectionManager", "cardBuild
var apiClient = connectionManager.getApiClient(item.ServerId); var apiClient = connectionManager.getApiClient(item.ServerId);
renderSeriesTimerEditor(page, item, apiClient, user), renderTimerEditor(page, item, apiClient, user), renderImage(page, item, apiClient, user), renderLogo(page, item, apiClient), setTitle(item, apiClient), setInitialCollapsibleState(page, item, apiClient, context, user), renderDetails(page, item, apiClient, context), renderTrackSelections(page, instance, item), dom.getWindowSize().innerWidth >= 1e3 ? backdrop.setBackdrops([item]) : backdrop.clear(), renderDetailPageBackdrop(page, item, apiClient); renderSeriesTimerEditor(page, item, apiClient, user), renderTimerEditor(page, item, apiClient, user), renderImage(page, item, apiClient, user), renderLogo(page, item, apiClient), setTitle(item, apiClient), setInitialCollapsibleState(page, item, apiClient, context, user), renderDetails(page, item, apiClient, context), renderTrackSelections(page, instance, item), dom.getWindowSize().innerWidth >= 1e3 ? backdrop.setBackdrops([item]) : backdrop.clear(), renderDetailPageBackdrop(page, item, apiClient);
var canPlay = reloadPlayButtons(page, item); var canPlay = reloadPlayButtons(page, item);
(item.LocalTrailerCount || item.RemoteTrailers && item.RemoteTrailers.length) && -1 !== playbackManager.getSupportedCommands().indexOf("PlayTrailers") ? hideAll(page, "btnPlayTrailer", !0) : hideAll(page, "btnPlayTrailer"); if ((item.LocalTrailerCount || item.RemoteTrailers && item.RemoteTrailers.length) && -1 !== playbackManager.getSupportedCommands().indexOf("PlayTrailers")) {
hideAll(page, "btnPlayTrailer", true);
} else {
hideAll(page, "btnPlayTrailer");
}
setTrailerButtonVisibility(page, item); setTrailerButtonVisibility(page, item);
item.CanDelete && !item.IsFolder ? hideAll(page, "btnDeleteItem", !0) : hideAll(page, "btnDeleteItem"); if (item.CanDelete && !item.IsFolder) {
"Program" !== item.Type || canPlay ? hideAll(page, "mainDetailButtons", !0) : hideAll(page, "mainDetailButtons"); hideAll(page, "btnDeleteItem", true);
} else {
hideAll(page, "btnDeleteItem");
}
if ("Program" !== item.Type || canPlay) {
hideAll(page, "mainDetailButtons", true);
} else {
hideAll(page, "mainDetailButtons");
}
showRecordingFields(instance, page, item, user); showRecordingFields(instance, page, item, user);
var groupedVersions = (item.MediaSources || []).filter(function(g) { var groupedVersions = (item.MediaSources || []).filter(function(g) {
return "Grouping" == g.Type return "Grouping" == g.Type
@ -1208,7 +1220,7 @@ define(["loading", "appRouter", "layoutManager", "connectionManager", "cardBuild
view.addEventListener("viewbeforehide", function() { view.addEventListener("viewbeforehide", function() {
events.off(apiClient, "message", onWebSocketMessage); events.off(apiClient, "message", onWebSocketMessage);
events.off(playbackManager, "playerchange", onPlayerChange); events.off(playbackManager, "playerchange", onPlayerChange);
libraryMenu.setTransparentMenu(!1); libraryMenu.setTransparentMenu(false);
}); });
view.addEventListener("viewdestroy", function() { view.addEventListener("viewdestroy", function() {
currentItem = null; currentItem = null;

2
src/scripts/tvrecommended.js
View file

@ -204,7 +204,7 @@ define(["events", "inputManager", "libraryMenu", "layoutManager", "loading", "do
initialTabIndex = currentTabIndex; initialTabIndex = currentTabIndex;
self.initTab = function() { self.initTab = function() {
var tabContent = self.tabContent; var tabContent = self.tabContent;
setScrollClasses(tabContent.querySelector("#resumableItems"), enableScrollX()) setScrollClasses(tabContent.querySelector("#resumableItems"), enableScrollX());
}, self.renderTab = function() { }, self.renderTab = function() {
reload() reload()
}; };