1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00

code style changes

This commit is contained in:
dkanada 2020-06-28 16:36:00 +09:00
parent 7f87c4671d
commit c0c66dea57
3 changed files with 18 additions and 19 deletions

View file

@ -1,18 +1,16 @@
import globalize from 'globalize'; import globalize from 'globalize';
/** /**
* Helper for handling settings * Helper for handling settings.
* @module components/settingsHelper * @module components/settingsHelper
*/ */
export function populateLanguages(select, languages) {
export function populateLanguages(select, languages) {
let html = ''; let html = '';
html += "<option value=''>" + globalize.translate('AnyLanguage') + '</option>'; html += "<option value=''>" + globalize.translate('AnyLanguage') + '</option>';
for (let i = 0, length = languages.length; i < length; i++) { for (let i = 0, length = languages.length; i < length; i++) {
const culture = languages[i]; const culture = languages[i];
html += "<option value='" + culture.ThreeLetterISOLanguageName + "'>" + culture.DisplayName + '</option>'; html += "<option value='" + culture.ThreeLetterISOLanguageName + "'>" + culture.DisplayName + '</option>';
} }

View file

@ -1,7 +1,8 @@
/** /**
* Subtitle settings visual helper * Subtitle settings visual helper.
* @module components/subtitleSettings/subtitleAppearanceHelper * @module components/subtitleSettings/subtitleAppearanceHelper
*/ */
function getTextStyles(settings, isCue) { function getTextStyles(settings, isCue) {
let list = []; let list = [];

View file

@ -16,7 +16,7 @@ import 'emby-checkbox';
import 'flexStyles'; import 'flexStyles';
/** /**
* Subtitle settings * Subtitle settings.
* @module components/subtitleSettings/subtitleSettings * @module components/subtitleSettings/subtitleSettings
*/ */
@ -40,7 +40,7 @@ function loadForm(context, user, userSettings, appearanceSettings, apiClient) {
context.querySelector('.fldBurnIn').classList.remove('hide'); context.querySelector('.fldBurnIn').classList.remove('hide');
} }
let selectSubtitleLanguage = context.querySelector( '#selectSubtitleLanguage' ); let selectSubtitleLanguage = context.querySelector('#selectSubtitleLanguage');
settingsHelper.populateLanguages(selectSubtitleLanguage, allCultures); settingsHelper.populateLanguages(selectSubtitleLanguage, allCultures);
@ -67,7 +67,7 @@ function loadForm(context, user, userSettings, appearanceSettings, apiClient) {
function saveUser(context, user, userSettingsInstance, appearanceKey, apiClient) { function saveUser(context, user, userSettingsInstance, appearanceKey, apiClient) {
let appearanceSettings = userSettingsInstance.getSubtitleAppearanceSettings( appearanceKey ); let appearanceSettings = userSettingsInstance.getSubtitleAppearanceSettings(appearanceKey);
appearanceSettings = Object.assign(appearanceSettings, getSubtitleAppearanceObject(context)); appearanceSettings = Object.assign(appearanceSettings, getSubtitleAppearanceObject(context));
userSettingsInstance.setSubtitleAppearanceSettings(appearanceSettings, appearanceKey); userSettingsInstance.setSubtitleAppearanceSettings(appearanceSettings, appearanceKey);
@ -105,9 +105,9 @@ function save(instance, context, userId, userSettings, apiClient, enableSaveConf
function onSubtitleModeChange(e) { function onSubtitleModeChange(e) {
let view = dom.parentWithClass( e.target, 'subtitlesettings' ); let view = dom.parentWithClass(e.target, 'subtitlesettings');
let subtitlesHelp = view.querySelectorAll( '.subtitlesHelp' ); let subtitlesHelp = view.querySelectorAll('.subtitlesHelp');
for (let i = 0, length = subtitlesHelp.length; i < length; i++) { for (let i = 0, length = subtitlesHelp.length; i < length; i++) {
subtitlesHelp[i].classList.add('hide'); subtitlesHelp[i].classList.add('hide');
} }
@ -116,13 +116,13 @@ function onSubtitleModeChange(e) {
function onAppearanceFieldChange(e) { function onAppearanceFieldChange(e) {
let view = dom.parentWithClass( e.target, 'subtitlesettings' ); let view = dom.parentWithClass(e.target, 'subtitlesettings');
let appearanceSettings = getSubtitleAppearanceObject( view ); let appearanceSettings = getSubtitleAppearanceObject(view);
let elements = { let elements = {
window: view.querySelector( '.subtitleappearance-preview-window' ), window: view.querySelector('.subtitleappearance-preview-window'),
text: view.querySelector( '.subtitleappearance-preview-text' ) text: view.querySelector('.subtitleappearance-preview-text')
}; };
subtitleAppearanceHelper.applyStyles(elements, appearanceSettings); subtitleAppearanceHelper.applyStyles(elements, appearanceSettings);
@ -176,14 +176,14 @@ export class SubtitleSettings {
loading.show(); loading.show();
let userId = self.options.userId; let userId = self.options.userId;
let apiClient = connectionManager.getApiClient( self.options.serverId ); let apiClient = connectionManager.getApiClient(self.options.serverId);
let userSettings = self.options.userSettings; let userSettings = self.options.userSettings;
apiClient.getUser(userId).then(function (user) { apiClient.getUser(userId).then(function (user) {
userSettings.setUserInfo(userId, apiClient).then(function () { userSettings.setUserInfo(userId, apiClient).then(function () {
self.dataLoaded = true; self.dataLoaded = true;
let appearanceSettings = userSettings.getSubtitleAppearanceSettings( self.options.appearanceKey ); let appearanceSettings = userSettings.getSubtitleAppearanceSettings(self.options.appearanceKey);
loadForm(context, user, userSettings, appearanceSettings, apiClient); loadForm(context, user, userSettings, appearanceSettings, apiClient);
}); });
@ -191,14 +191,14 @@ export class SubtitleSettings {
} }
submit() { submit() {
this.onSubmit( null ); this.onSubmit(null);
} }
destroy() { destroy() {
this.options = null; this.options = null;
} }
onSubmit( e ) { onSubmit(e) {
const self = this; const self = this;
let apiClient = connectionManager.getApiClient(self.options.serverId); let apiClient = connectionManager.getApiClient(self.options.serverId);
let userId = self.options.userId; let userId = self.options.userId;