mirrors/jellyfin-web
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00
Code Activity

Apply suggestions from code review

Browse source
This commit is contained in:
Dmitry Lyzo 2019-11-27 14:30:56 +03:00
parent 3752db775b
commit c677708819
1 changed files with 5 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/components/scrollManager.js
View file

@ -12,7 +12,6 @@ define(["dom", "browser", "layoutManager"], function (dom, browser, layoutManage
var Epsilon = 1e-6; var Epsilon = 1e-6;
// FIXME: Need to scroll to top of page to fully show the top menu. This can be solved by some marker of top most elements or their containers // FIXME: Need to scroll to top of page to fully show the top menu. This can be solved by some marker of top most elements or their containers
var _minimumScrollY = 0;
/** /**
* Returns minimum vertical scroll. * Returns minimum vertical scroll.
* Scroll less than that value will be zeroed. * Scroll less than that value will be zeroed.
@ -20,13 +19,11 @@ define(["dom", "browser", "layoutManager"], function (dom, browser, layoutManage
* @return {number} minimum vertical scroll * @return {number} minimum vertical scroll
*/ */
function minimumScrollY() { function minimumScrollY() {
if (_minimumScrollY === 0) {
var topMenu = document.querySelector(".headerTop"); var topMenu = document.querySelector(".headerTop");
if (topMenu) { if (topMenu) {
_minimumScrollY = topMenu.clientHeight; return topMenu.clientHeight;
} }
} return 0;
return _minimumScrollY;
} }
var supportsSmoothScroll = "scrollBehavior" in document.documentElement.style; var supportsSmoothScroll = "scrollBehavior" in document.documentElement.style;
@ -333,8 +330,7 @@ define(["dom", "browser", "layoutManager"], function (dom, browser, layoutManage
if (k === 1) { if (k === 1) {
resetScrollTimer(); resetScrollTimer();
xScroller.scrollLeft = scrollX; builtinScroll(xScroller, scrollX, yScroller, scrollY, false);
yScroller.scrollTop = scrollY;
return; return;
} }