From c7b6f4418c13eb427af20c92932837dec1d2866f Mon Sep 17 00:00:00 2001 From: Bond_009 Date: Tue, 30 Apr 2024 21:46:29 +0200 Subject: [PATCH] Address comments --- src/plugins/htmlAudioPlayer/plugin.js | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/plugins/htmlAudioPlayer/plugin.js b/src/plugins/htmlAudioPlayer/plugin.js index cf67329af5..9a4b6d32de 100644 --- a/src/plugins/htmlAudioPlayer/plugin.js +++ b/src/plugins/htmlAudioPlayer/plugin.js @@ -113,12 +113,19 @@ class HtmlAudioPlayer { let val = options.url; console.debug('playing url: ' + val); import('../../scripts/settings/userSettings').then((userSettings) => { - if (userSettings.selectAudioNormalization() == 'TrackGain' - && (options.item.NormalizationGain != null || options.mediaSource.albumNormalizationGain != null)) { - self.gainNode.gain.value = Math.pow(10, ((options.item.NormalizationGain ?? options.mediaSource.albumNormalizationGain) / 20)); - } else if (userSettings.selectAudioNormalization() == 'AlbumGain' - && (options.mediaSource.albumNormalizationGain != null || options.item.NormalizationGain != null)) { - self.gainNode.gain.value = Math.pow(10, ((options.mediaSource.albumNormalizationGain ?? options.item.NormalizationGain) / 20)); + let normalizationGain; + if (userSettings.selectAudioNormalization() == 'TrackGain') { + normalizationGain = + options.item.NormalizationGain ?? + options.mediaSource.albumNormalizationGain; + } else if (userSettings.selectAudioNormalization() == 'AlbumGain') { + normalizationGain = + options.item.albumNormalizationGain ?? + options.mediaSource.NormalizationGain; + } + + if (normalizationGain) { + self.gainNode.gain.value = Math.pow(10, normalizationGain / 20); } else { self.gainNode.gain.value = 1; }