From cac6b42dab6ea3b44bd0ac3dedbdef67c26c739a Mon Sep 17 00:00:00 2001 From: dkanada Date: Fri, 14 Aug 2020 18:23:16 +0900 Subject: [PATCH] Merge pull request #1799 from matjaz321/checkbox-space-ff-issue Hitting space to check/uncheck checkboxes doesn't work on firefox (cherry picked from commit fea28f727786e81f5cafd759aba8d7e0c780d399) --- src/elements/emby-checkbox/emby-checkbox.js | 2 +- src/elements/emby-radio/emby-radio.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/elements/emby-checkbox/emby-checkbox.js b/src/elements/emby-checkbox/emby-checkbox.js index a8a076cb83..71a16043d3 100644 --- a/src/elements/emby-checkbox/emby-checkbox.js +++ b/src/elements/emby-checkbox/emby-checkbox.js @@ -6,7 +6,7 @@ define(['browser', 'dom', 'css!./emby-checkbox', 'webcomponents'], function (bro function onKeyDown(e) { // Don't submit form on enter // Real (non-emulator) Tizen does nothing on Space - if (e.keyCode === 13 || e.keyCode === 32) { + if (e.keyCode === 13 || (e.keyCode === 32 && browser.tizen)) { e.preventDefault(); this.checked = !this.checked; diff --git a/src/elements/emby-radio/emby-radio.js b/src/elements/emby-radio/emby-radio.js index b83461d7b8..961373f6cc 100644 --- a/src/elements/emby-radio/emby-radio.js +++ b/src/elements/emby-radio/emby-radio.js @@ -1,4 +1,4 @@ -define(['layoutManager', 'css!./emby-radio', 'webcomponents'], function (layoutManager) { +define(['browser', 'layoutManager', 'css!./emby-radio', 'webcomponents'], function (browser, layoutManager) { 'use strict'; var EmbyRadioPrototype = Object.create(HTMLInputElement.prototype); @@ -7,7 +7,7 @@ define(['layoutManager', 'css!./emby-radio', 'webcomponents'], function (layoutM // Don't submit form on enter // Real (non-emulator) Tizen does nothing on Space - if (e.keyCode === 13 || e.keyCode === 32) { + if (e.keyCode === 13 || (e.keyCode === 32 && browser.tizen)) { e.preventDefault(); if (!this.checked) {