From cef44e41d610b010031b8f318e35a93b313bf3d7 Mon Sep 17 00:00:00 2001 From: grafixeyehero <32230989+grafixeyehero@users.noreply.github.com> Date: Sat, 9 Oct 2021 21:29:30 +0300 Subject: [PATCH] fix sonarcloud Code Smell Refactoring Cognitive Complexity --- src/components/pages/NewUserPage.tsx | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/src/components/pages/NewUserPage.tsx b/src/components/pages/NewUserPage.tsx index fcd94e0b37..77571c5495 100644 --- a/src/components/pages/NewUserPage.tsx +++ b/src/components/pages/NewUserPage.tsx @@ -45,17 +45,22 @@ const NewUserPage: FunctionComponent = () => { loadUser(); - const loadMediaFolders = (mediaFolders) => { + const getItemsResult = items => { const itemsArr: ItemsArr[] = []; - for (const folder of mediaFolders) { + for (const item of items) { itemsArr.push({ - Id: folder.Id, - Name: folder.Name + Id: item.Id, + Name: item.Name }); } + return itemsArr; + }; - setMediaFoldersItems(itemsArr); + const loadMediaFolders = (result) => { + const mediaFolders = getItemsResult(result); + + setMediaFoldersItems(mediaFolders); const folderAccess = element?.current?.querySelector('.folderAccess'); folderAccess.dispatchEvent(new CustomEvent('create')); @@ -63,17 +68,10 @@ const NewUserPage: FunctionComponent = () => { element.current.querySelector('.chkEnableAllFolders').checked = false; }; - const loadChannels = (channels) => { - const itemsArr: ItemsArr[] = []; + const loadChannels = (result) => { + const channels = getItemsResult(result); - for (const folder of channels) { - itemsArr.push({ - Id: folder.Id, - Name: folder.Name - }); - } - - setChannelsItems(itemsArr); + setChannelsItems(channels); const channelAccess = element?.current?.querySelector('.channelAccess'); channelAccess.dispatchEvent(new CustomEvent('create'));