From d36a8994fb068f94485841ea8b6361cfe1fa86d3 Mon Sep 17 00:00:00 2001 From: Cromefire_ Date: Thu, 28 May 2020 23:06:36 +0200 Subject: [PATCH] Fixed review comments --- .eslintrc.js | 1 + src/components/fetchhelper.js | 11 ++++++++--- src/plugins/backdropScreensaver/plugin.js | 5 ++--- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 27b5c2a237..ab53f0f03d 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -132,6 +132,7 @@ module.exports = { 'Object.getOwnPropertyDescriptor', 'Object.getPrototypeOf', 'Object.keys', + 'Object.entries', 'Object.getOwnPropertyNames', 'Function.name', 'Function.hasInstance', diff --git a/src/components/fetchhelper.js b/src/components/fetchhelper.js index 3bc24a8918..11c5697dc7 100644 --- a/src/components/fetchhelper.js +++ b/src/components/fetchhelper.js @@ -75,10 +75,15 @@ }); } + /** + * @param params {Record} + * @returns {string} Query string + */ function paramsToString(params) { - return Object.keys(params) - .filter((k) => !!params[k]) - .map(k => `${encodeURIComponent(k)}=${encodeURIComponent(params[k])}`) + return Object.entries(params) + // eslint-disable-next-line no-unused-vars + .filter(([_, v]) => v !== null && v !== undefined) + .map(([k, v]) => `${encodeURIComponent(k)}=${encodeURIComponent(v)}`) .join('&'); } diff --git a/src/plugins/backdropScreensaver/plugin.js b/src/plugins/backdropScreensaver/plugin.js index acaefa76d2..88bfa1f4b7 100644 --- a/src/plugins/backdropScreensaver/plugin.js +++ b/src/plugins/backdropScreensaver/plugin.js @@ -26,9 +26,8 @@ class BackdropScreensaver { if (result.Items.length) { - import('slideshow').then(slideshow => { - - var newSlideShow = new slideshow({ + import('slideshow').then(({default: Slideshow}) => { + const newSlideShow = new Slideshow({ showTitle: true, cover: true, items: result.Items