From 58051dcd8019780e9c8e6d6b1b937c9142d41b4a Mon Sep 17 00:00:00 2001
From: Dmitry Lyzo <ashephard0@gmail.com>
Date: Mon, 15 Apr 2024 21:01:44 +0300
Subject: [PATCH 1/4] Extract canPlayDts function

---
 src/scripts/browserDeviceProfile.js | 26 ++++++++++++++++++++------
 1 file changed, 20 insertions(+), 6 deletions(-)

diff --git a/src/scripts/browserDeviceProfile.js b/src/scripts/browserDeviceProfile.js
index dce9a02cb4..8bc3b21644 100644
--- a/src/scripts/browserDeviceProfile.js
+++ b/src/scripts/browserDeviceProfile.js
@@ -94,6 +94,25 @@ function supportsAc3(videoTestElement) {
     return videoTestElement.canPlayType('audio/mp4; codecs="ac-3"').replace(/no/, '');
 }
 
+/**
+ * Checks if the device supports DTS (DCA).
+ * @param {HTMLVideoElement} videoTestElement The video test element
+ * @returns {boolean|null} _true_ if the device supports DTS (DCA). _false_ if the device doesn't support DTS (DCA). _null_ if support status is unknown.
+ */
+function canPlayDts(videoTestElement) {
+    // DTS audio is not supported by Samsung TV 2018+ (Tizen 4.0+) and LG TV 2020-2022 (webOS 5.0, 6.0 and 22) models
+    if (browser.tizenVersion >= 4 || (browser.web0sVersion >= 5 && browser.web0sVersion < 23)) {
+        return false;
+    }
+
+    if (videoTestElement.canPlayType('video/mp4; codecs="dts-"').replace(/no/, '')
+        || videoTestElement.canPlayType('video/mp4; codecs="dts+"').replace(/no/, '')) {
+        return true;
+    }
+
+    return null;
+}
+
 function supportsEac3(videoTestElement) {
     if (browser.tizen || browser.web0s) {
         return true;
@@ -530,12 +549,7 @@ export default function (options) {
 
     let supportsDts = options.supportsDts;
     if (supportsDts == null) {
-        supportsDts = browser.tizen || browser.web0sVersion || videoTestElement.canPlayType('video/mp4; codecs="dts-"').replace(/no/, '') || videoTestElement.canPlayType('video/mp4; codecs="dts+"').replace(/no/, '');
-
-        // DTS audio is not supported by Samsung TV 2018+ (Tizen 4.0+) and LG TV 2020-2022 (webOS 5.0, 6.0 and 22) models
-        if (browser.tizenVersion >= 4 || (browser.web0sVersion >= 5 && browser.web0sVersion < 23)) {
-            supportsDts = false;
-        }
+        supportsDts = canPlayDts(videoTestElement);
     }
 
     if (supportsDts) {

From ce15adba6900e70f61bf4a19db318c15ec39d363 Mon Sep 17 00:00:00 2001
From: Dmitry Lyzo <ashephard0@gmail.com>
Date: Mon, 15 Apr 2024 20:26:12 +0300
Subject: [PATCH 2/4] Add DTS enabling option

---
 src/components/playbackSettings/playbackSettings.js |  3 +++
 .../playbackSettings/playbackSettings.template.html |  8 ++++++++
 src/scripts/browserDeviceProfile.js                 |  2 +-
 src/scripts/settings/appSettings.js                 | 13 +++++++++++++
 src/strings/en-us.json                              |  2 ++
 5 files changed, 27 insertions(+), 1 deletion(-)

diff --git a/src/components/playbackSettings/playbackSettings.js b/src/components/playbackSettings/playbackSettings.js
index 254389a9f6..c1106ec244 100644
--- a/src/components/playbackSettings/playbackSettings.js
+++ b/src/components/playbackSettings/playbackSettings.js
@@ -173,6 +173,7 @@ function loadForm(context, user, userSettings, systemInfo, apiClient) {
 
     context.querySelector('.chkPlayDefaultAudioTrack').checked = user.Configuration.PlayDefaultAudioTrack || false;
     context.querySelector('.chkPreferFmp4HlsContainer').checked = userSettings.preferFmp4HlsContainer();
+    context.querySelector('.chkEnableDts').checked = appSettings.enableDts();
     context.querySelector('.chkEnableCinemaMode').checked = userSettings.enableCinemaMode();
     context.querySelector('#selectAudioNormalization').value = userSettings.selectAudioNormalization();
     context.querySelector('.chkEnableNextVideoOverlay').checked = userSettings.enableNextVideoInfoOverlay();
@@ -216,6 +217,8 @@ function saveUser(context, user, userSettingsInstance, apiClient) {
     appSettings.maxVideoWidth(context.querySelector('.selectMaxVideoWidth').value);
     appSettings.limitSupportedVideoResolution(context.querySelector('.chkLimitSupportedVideoResolution').checked);
 
+    appSettings.enableDts(context.querySelector('.chkEnableDts').checked);
+
     setMaxBitrateFromField(context.querySelector('.selectVideoInNetworkQuality'), true, 'Video');
     setMaxBitrateFromField(context.querySelector('.selectVideoInternetQuality'), false, 'Video');
     setMaxBitrateFromField(context.querySelector('.selectMusicInternetQuality'), false, 'Audio');
diff --git a/src/components/playbackSettings/playbackSettings.template.html b/src/components/playbackSettings/playbackSettings.template.html
index 6dc860260f..ef9b5ab4da 100644
--- a/src/components/playbackSettings/playbackSettings.template.html
+++ b/src/components/playbackSettings/playbackSettings.template.html
@@ -157,6 +157,14 @@
         <div class="selectContainer">
             <select is="emby-select" class="selectSkipBackLength" label="${LabelSkipBackLength}"></select>
         </div>
+
+        <div class="checkboxContainer checkboxContainer-withDescription fldEnableDts">
+            <label>
+                <input type="checkbox" is="emby-checkbox" class="chkEnableDts" />
+                <span>${EnableDts}</span>
+            </label>
+            <div class="fieldDescription checkboxFieldDescription">${EnableDtsHelp}</div>
+        </div>
     </div>
 
     <button is="emby-button" type="submit" class="raised button-submit block btnSave hide">
diff --git a/src/scripts/browserDeviceProfile.js b/src/scripts/browserDeviceProfile.js
index 8bc3b21644..4af5566c30 100644
--- a/src/scripts/browserDeviceProfile.js
+++ b/src/scripts/browserDeviceProfile.js
@@ -547,7 +547,7 @@ export default function (options) {
         hlsInFmp4VideoAudioCodecs.push('mp2');
     }
 
-    let supportsDts = options.supportsDts;
+    let supportsDts = appSettings.enableDts() || options.supportsDts;
     if (supportsDts == null) {
         supportsDts = canPlayDts(videoTestElement);
     }
diff --git a/src/scripts/settings/appSettings.js b/src/scripts/settings/appSettings.js
index 4d96c1eed6..a6e1881bd3 100644
--- a/src/scripts/settings/appSettings.js
+++ b/src/scripts/settings/appSettings.js
@@ -132,6 +132,19 @@ class AppSettings {
         return toBoolean(this.get('limitSupportedVideoResolution'), false);
     }
 
+    /**
+     * Get or set 'Enable DTS' state.
+     * @param {boolean|undefined} val - Flag to enable 'Enable DTS' or undefined.
+     * @return {boolean} 'Enable DTS' state.
+     */
+    enableDts(val) {
+        if (val !== undefined) {
+            return this.set('enableDts', val.toString());
+        }
+
+        return toBoolean(this.get('enableDts'), false);
+    }
+
     set(name, value, userId) {
         const currentValue = this.get(name, userId);
         localStorage.setItem(this.#getKey(name, userId), value);
diff --git a/src/strings/en-us.json b/src/strings/en-us.json
index 7ac237d099..1904d82619 100644
--- a/src/strings/en-us.json
+++ b/src/strings/en-us.json
@@ -246,6 +246,8 @@
     "EnableDetailsBanner": "Details Banner",
     "EnableDetailsBannerHelp": "Display a banner image at the top of the item details page.",
     "EnableDisplayMirroring": "Display mirroring",
+    "EnableDts": "Enable DTS (DCA)",
+    "EnableDtsHelp": "Only enable if your device supports DTS or is connected to a compatible audio receiver, otherwise it may cause playback failure.",
     "EnableExternalVideoPlayers": "External video players",
     "EnableExternalVideoPlayersHelp": "An external player menu will be shown when starting video playback.",
     "EnableFasterAnimations": "Faster animations",

From 275e18457e6723a4aced94f4e83374be39b6c0a3 Mon Sep 17 00:00:00 2001
From: Dmitry Lyzo <ashephard0@gmail.com>
Date: Mon, 15 Apr 2024 22:20:47 +0300
Subject: [PATCH 3/4] Add TrueHD enabling option

---
 src/components/playbackSettings/playbackSettings.js |  2 ++
 .../playbackSettings/playbackSettings.template.html |  8 ++++++++
 src/scripts/browserDeviceProfile.js                 |  2 +-
 src/scripts/settings/appSettings.js                 | 13 +++++++++++++
 src/strings/en-us.json                              |  2 ++
 5 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/src/components/playbackSettings/playbackSettings.js b/src/components/playbackSettings/playbackSettings.js
index c1106ec244..6717c66613 100644
--- a/src/components/playbackSettings/playbackSettings.js
+++ b/src/components/playbackSettings/playbackSettings.js
@@ -174,6 +174,7 @@ function loadForm(context, user, userSettings, systemInfo, apiClient) {
     context.querySelector('.chkPlayDefaultAudioTrack').checked = user.Configuration.PlayDefaultAudioTrack || false;
     context.querySelector('.chkPreferFmp4HlsContainer').checked = userSettings.preferFmp4HlsContainer();
     context.querySelector('.chkEnableDts').checked = appSettings.enableDts();
+    context.querySelector('.chkEnableTrueHd').checked = appSettings.enableTrueHd();
     context.querySelector('.chkEnableCinemaMode').checked = userSettings.enableCinemaMode();
     context.querySelector('#selectAudioNormalization').value = userSettings.selectAudioNormalization();
     context.querySelector('.chkEnableNextVideoOverlay').checked = userSettings.enableNextVideoInfoOverlay();
@@ -218,6 +219,7 @@ function saveUser(context, user, userSettingsInstance, apiClient) {
     appSettings.limitSupportedVideoResolution(context.querySelector('.chkLimitSupportedVideoResolution').checked);
 
     appSettings.enableDts(context.querySelector('.chkEnableDts').checked);
+    appSettings.enableTrueHd(context.querySelector('.chkEnableTrueHd').checked);
 
     setMaxBitrateFromField(context.querySelector('.selectVideoInNetworkQuality'), true, 'Video');
     setMaxBitrateFromField(context.querySelector('.selectVideoInternetQuality'), false, 'Video');
diff --git a/src/components/playbackSettings/playbackSettings.template.html b/src/components/playbackSettings/playbackSettings.template.html
index ef9b5ab4da..c5dab26127 100644
--- a/src/components/playbackSettings/playbackSettings.template.html
+++ b/src/components/playbackSettings/playbackSettings.template.html
@@ -165,6 +165,14 @@
             </label>
             <div class="fieldDescription checkboxFieldDescription">${EnableDtsHelp}</div>
         </div>
+
+        <div class="checkboxContainer checkboxContainer-withDescription fldEnableTrueHd">
+            <label>
+                <input type="checkbox" is="emby-checkbox" class="chkEnableTrueHd" />
+                <span>${EnableTrueHd}</span>
+            </label>
+            <div class="fieldDescription checkboxFieldDescription">${EnableTrueHdHelp}</div>
+        </div>
     </div>
 
     <button is="emby-button" type="submit" class="raised button-submit block btnSave hide">
diff --git a/src/scripts/browserDeviceProfile.js b/src/scripts/browserDeviceProfile.js
index 4af5566c30..542b535f88 100644
--- a/src/scripts/browserDeviceProfile.js
+++ b/src/scripts/browserDeviceProfile.js
@@ -562,7 +562,7 @@ export default function (options) {
         videoAudioCodecs.push('pcm_s24le');
     }
 
-    if (options.supportsTrueHd) {
+    if (appSettings.enableTrueHd() || options.supportsTrueHd) {
         videoAudioCodecs.push('truehd');
     }
 
diff --git a/src/scripts/settings/appSettings.js b/src/scripts/settings/appSettings.js
index a6e1881bd3..83d4d6879c 100644
--- a/src/scripts/settings/appSettings.js
+++ b/src/scripts/settings/appSettings.js
@@ -145,6 +145,19 @@ class AppSettings {
         return toBoolean(this.get('enableDts'), false);
     }
 
+    /**
+     * Get or set 'Enable TrueHD' state.
+     * @param {boolean|undefined} val - Flag to enable 'Enable TrueHD' or undefined.
+     * @return {boolean} 'Enable TrueHD' state.
+     */
+    enableTrueHd(val) {
+        if (val !== undefined) {
+            return this.set('enableTrueHd', val.toString());
+        }
+
+        return toBoolean(this.get('enableTrueHd'), false);
+    }
+
     set(name, value, userId) {
         const currentValue = this.get(name, userId);
         localStorage.setItem(this.#getKey(name, userId), value);
diff --git a/src/strings/en-us.json b/src/strings/en-us.json
index 1904d82619..d5b7316d10 100644
--- a/src/strings/en-us.json
+++ b/src/strings/en-us.json
@@ -269,6 +269,8 @@
     "EnableThemeSongsHelp": "Play the theme songs in background while browsing the library.",
     "EnableThemeVideosHelp": "Play theme videos in the background while browsing the library.",
     "EnableTonemapping": "Enable Tone mapping",
+    "EnableTrueHd": "Enable TrueHD",
+    "EnableTrueHdHelp": "Only enable if your device supports TrueHD or is connected to a compatible audio receiver, otherwise it may cause playback failure.",
     "EncoderPresetHelp": "Pick a faster value to improve performance, or a slower value to improve quality.",
     "Ended": "Ended",
     "EndsAtValue": "Ends at {0}",

From f1220600eb6757a7c965e7c1f67afb81f134282c Mon Sep 17 00:00:00 2001
From: Dmitry Lyzo <ashephard0@gmail.com>
Date: Sun, 5 May 2024 01:48:00 +0300
Subject: [PATCH 4/4] Add Video Advanced section

---
 .../playbackSettings/playbackSettings.template.html         | 6 ++++++
 src/strings/en-us.json                                      | 1 +
 2 files changed, 7 insertions(+)

diff --git a/src/components/playbackSettings/playbackSettings.template.html b/src/components/playbackSettings/playbackSettings.template.html
index c5dab26127..eb416687d7 100644
--- a/src/components/playbackSettings/playbackSettings.template.html
+++ b/src/components/playbackSettings/playbackSettings.template.html
@@ -157,6 +157,12 @@
         <div class="selectContainer">
             <select is="emby-select" class="selectSkipBackLength" label="${LabelSkipBackLength}"></select>
         </div>
+    </div>
+
+    <div class="verticalSection verticalSection-extrabottompadding">
+        <h2 class="sectionTitle">
+            ${HeaderVideoAdvanced}
+        </h2>
 
         <div class="checkboxContainer checkboxContainer-withDescription fldEnableDts">
             <label>
diff --git a/src/strings/en-us.json b/src/strings/en-us.json
index d5b7316d10..b09c51f47f 100644
--- a/src/strings/en-us.json
+++ b/src/strings/en-us.json
@@ -505,6 +505,7 @@
     "HeaderUploadSubtitle": "Upload Subtitle",
     "HeaderUser": "User",
     "HeaderUsers": "Users",
+    "HeaderVideoAdvanced": "Video Advanced",
     "HeaderVideoQuality": "Video Quality",
     "HeaderVideos": "Videos",
     "HeaderVideoType": "Video Type",