From 364f2d448e6da5532da63375db1443f9c4bb715c Mon Sep 17 00:00:00 2001
From: Dominik <git@secnd.me>
Date: Mon, 14 Nov 2022 10:35:49 +0100
Subject: [PATCH 1/3] Add option for segment deletion and make throttle and
 segment seconds configurable

---
 .../dashboard/encodingsettings.html            | 18 ++++++++++++++++++
 src/controllers/dashboard/encodingsettings.js  |  6 ++++++
 src/strings/en-us.json                         |  6 ++++++
 3 files changed, 30 insertions(+)

diff --git a/src/controllers/dashboard/encodingsettings.html b/src/controllers/dashboard/encodingsettings.html
index d6e29a4928..1f047737b8 100644
--- a/src/controllers/dashboard/encodingsettings.html
+++ b/src/controllers/dashboard/encodingsettings.html
@@ -316,6 +316,24 @@
                     <div class="fieldDescription checkboxFieldDescription">${AllowFfmpegThrottlingHelp}</div>
                 </div>
 
+                <div class="checkboxContainer checkboxContainer-withDescription">
+                    <label>
+                        <input is="emby-checkbox" type="checkbox" id="chkEnableSegmentDeletion" />
+                        <span>${AllowSegmentDeletion}</span>
+                    </label>
+                    <div class="fieldDescription checkboxFieldDescription">${AllowSegmentDeletionHelp}</div>
+                </div>
+
+                <div class="inputContainer">
+                    <input is="emby-input" type="number" id="txtThrottleDelaySeconds" pattern="[0-9]*" min="10" max="3600" step="1" label="${LabelThrottleDelaySeconds}" />
+                    <div class="fieldDescription">${LabelThrottleDelaySecondsHelp}</div>
+                </div>
+
+                <div class="inputContainer">
+                    <input is="emby-input" type="number" id="txtSegmentKeepSeconds" pattern="[0-9]*" min="15" max="3600" step="1" label="${LabelSegmentKeepSeconds}" />
+                    <div class="fieldDescription">${LabelSegmentKeepSecondsHelp}</div>
+                </div>
+
                 <div>
                     <button is="emby-button" type="submit" class="raised button-submit block">
                         <span>${Save}</span>
diff --git a/src/controllers/dashboard/encodingsettings.js b/src/controllers/dashboard/encodingsettings.js
index 044fb1eb3d..3e2bfd2f4b 100644
--- a/src/controllers/dashboard/encodingsettings.js
+++ b/src/controllers/dashboard/encodingsettings.js
@@ -46,6 +46,9 @@ import alert from '../../components/alert';
         page.querySelector('#chkDoubleRateDeinterlacing').checked = config.DeinterlaceDoubleRate;
         page.querySelector('#chkEnableSubtitleExtraction').checked = config.EnableSubtitleExtraction || false;
         page.querySelector('#chkEnableThrottling').checked = config.EnableThrottling || false;
+        page.querySelector('#chkEnableSegmentDeletion').checked = config.EnableSegmentDeletion || false;
+        page.querySelector('#txtThrottleDelaySeconds').value = config.ThrottleDelaySeconds || '';
+        page.querySelector('#txtSegmentKeepSeconds').value = config.SegmentKeepSeconds || '';
         page.querySelector('#selectVideoDecoder').dispatchEvent(new CustomEvent('change', {
             bubbles: true
         }));
@@ -102,6 +105,9 @@ import alert from '../../components/alert';
                 config.DeinterlaceDoubleRate = form.querySelector('#chkDoubleRateDeinterlacing').checked;
                 config.EnableSubtitleExtraction = form.querySelector('#chkEnableSubtitleExtraction').checked;
                 config.EnableThrottling = form.querySelector('#chkEnableThrottling').checked;
+                config.EnableSegmentDeletion = form.querySelector('#chkEnableSegmentDeletion').checked;
+                config.ThrottleDelaySeconds = parseInt(form.querySelector('#txtThrottleDelaySeconds').value || '0');
+                config.SegmentKeepSeconds = parseInt(form.querySelector('#txtSegmentKeepSeconds').value || '0');
                 config.HardwareDecodingCodecs = Array.prototype.map.call(Array.prototype.filter.call(form.querySelectorAll('.chkDecodeCodec'), function (c) {
                     return c.checked;
                 }), function (c) {
diff --git a/src/strings/en-us.json b/src/strings/en-us.json
index 1487f8bf29..9e5c796893 100644
--- a/src/strings/en-us.json
+++ b/src/strings/en-us.json
@@ -25,6 +25,12 @@
     "AllowedRemoteAddressesHelp": "Comma separated list of IP addresses or IP/netmask entries for networks that will be allowed to connect remotely. If left blank, all remote addresses will be allowed.",
     "AllowFfmpegThrottling": "Throttle Transcodes",
     "AllowFfmpegThrottlingHelp": "When a transcode or remux gets far enough ahead from the current playback position, pause the process so it will consume less resources. This is most useful when watching without seeking often. Turn this off if you experience playback issues.",
+    "AllowSegmentDeletion": "Delete segments",
+    "AllowSegmentDeletionHelp": "Delete old segments after they have been sent to the client. This prevents having to store the entire transcoded file on disk. Will only work with throttling enabled. Turn this off if you experience playback issues.",
+    "LabelThrottleDelaySeconds": "Throttle after",
+    "LabelThrottleDelaySecondsHelp": "Time in seconds after which the transcoder will be throttled. Must be large enough for the client to maintain a healthy buffer. Only works if throttling is enabled.",
+    "LabelSegmentKeepSeconds": "Time to keep segments",
+    "LabelSegmentKeepSecondsHelp": "Time in seconds for which segments should be kept before they are overwritten. Must be greater than \"Throttle after\". Only works if segment deletion is enabled.",
     "AllowHWTranscodingHelp": "Allow the tuner to transcode streams on the fly. This may help reduce transcoding required by the server.",
     "AllowMediaConversion": "Allow media conversion",
     "AllowMediaConversionHelp": "Grant or deny access to the convert media feature.",

From e92ce92f1ddeb6d9e0ebb89ec83f9414d4d121d6 Mon Sep 17 00:00:00 2001
From: Dominik <git@secnd.me>
Date: Tue, 15 Nov 2022 15:41:22 +0100
Subject: [PATCH 2/3] Set startPosition on HLS video to prevent transcoder from
 starting twice

---
 src/plugins/htmlVideoPlayer/plugin.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/plugins/htmlVideoPlayer/plugin.js b/src/plugins/htmlVideoPlayer/plugin.js
index 249e27328a..90da50359f 100644
--- a/src/plugins/htmlVideoPlayer/plugin.js
+++ b/src/plugins/htmlVideoPlayer/plugin.js
@@ -409,6 +409,7 @@ function tryRemoveElement(elem) {
                     const includeCorsCredentials = await getIncludeCorsCredentials();
 
                     const hls = new Hls({
+                        startPosition: options.playerStartPositionTicks / 10000000,
                         manifestLoadingTimeOut: 20000,
                         maxBufferLength: maxBufferLength,
                         xhrSetup(xhr) {

From 139da4d4f66c926acec25223c1df4bc420f35adf Mon Sep 17 00:00:00 2001
From: Dominik <git@secnd.me>
Date: Tue, 20 Jun 2023 12:46:38 +0200
Subject: [PATCH 3/3] Fix linter complaints

---
 src/controllers/dashboard/encodingsettings.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/controllers/dashboard/encodingsettings.js b/src/controllers/dashboard/encodingsettings.js
index a3476be786..a769a65d00 100644
--- a/src/controllers/dashboard/encodingsettings.js
+++ b/src/controllers/dashboard/encodingsettings.js
@@ -108,8 +108,8 @@ function onSubmit() {
             config.EnableSubtitleExtraction = form.querySelector('#chkEnableSubtitleExtraction').checked;
             config.EnableThrottling = form.querySelector('#chkEnableThrottling').checked;
             config.EnableSegmentDeletion = form.querySelector('#chkEnableSegmentDeletion').checked;
-            config.ThrottleDelaySeconds = parseInt(form.querySelector('#txtThrottleDelaySeconds').value || '0');
-            config.SegmentKeepSeconds = parseInt(form.querySelector('#txtSegmentKeepSeconds').value || '0');
+            config.ThrottleDelaySeconds = parseInt(form.querySelector('#txtThrottleDelaySeconds').value || '0', 10);
+            config.SegmentKeepSeconds = parseInt(form.querySelector('#txtSegmentKeepSeconds').value || '0', 10);
             config.HardwareDecodingCodecs = Array.prototype.map.call(Array.prototype.filter.call(form.querySelectorAll('.chkDecodeCodec'), function (c) {
                 return c.checked;
             }), function (c) {