Remove dead code

.eslintrc.js

@@ -39,6 +39,8 @@ module.exports = {
         'no-multi-spaces': ['error'],
         'no-multiple-empty-lines': ['error', { 'max': 1 }],
         'no-trailing-spaces': ['error'],
+        'no-unused-expressions': ['error', { 'allowShortCircuit': true, 'allowTernary': true, 'allowTaggedTemplates': true }],
+        "no-unused-vars": ["error", { "vars": "all", "args": "none", "ignoreRestSiblings": true }],
         'one-var': ['error', 'never'],
         'quotes': ['error', 'single', { 'avoidEscape': true, 'allowTemplateLiterals': false }],
         'semi': ['error'],
@@ -98,9 +100,8 @@ module.exports = {
             },
             rules: {
                 // TODO: Fix warnings and remove these rules
-                'no-redeclare': ['warn'],
+                'no-redeclare': ['off'],
-                'no-unused-vars': ['warn'],
+                'no-useless-escape': ['off'],
-                'no-useless-escape': ['warn'],
                 // TODO: Remove after ES6 migration is complete
                 'import/no-unresolved': ['off']
             },

src/components/actionSheet/actionSheet.js

@@ -255,8 +255,6 @@ export function show(options) {
         });
     }
 
-    // Seeing an issue in some non-chrome browsers where this is requiring a double click
-    //var eventName = browser.firefox ? 'mousedown' : 'click';
     let selectedId;
 
     let timeout;

src/components/activitylog.js

@@ -69,6 +69,7 @@ import 'listViewStyle';
         const minDate = new Date();
         const hasUserId = 'false' !== elem.getAttribute('data-useractivity');
 
+        // TODO: Use date-fns
         if (hasUserId) {
             minDate.setTime(minDate.getTime() - 24 * 60 * 60 * 1000); // one day back
         } else {

src/components/appRouter.js

@@ -153,15 +153,10 @@ define(['loading', 'globalize', 'events', 'viewManager', 'skinManager', 'backdro
         };
 
         if (!isBackNav) {
-            // Don't force a new view for home due to the back menu
-            //if (route.type !== 'home') {
             onNewViewNeeded();
             return;
-            //}
         }
         viewManager.tryRestoreView(currentRequest, function () {
-
-            // done
             currentRouteInfo = {
                 route: route,
                 path: ctx.path
@@ -309,8 +304,7 @@ define(['loading', 'globalize', 'events', 'viewManager', 'skinManager', 'backdro
 
             page({
                 click: options.click !== false,
-                hashbang: options.hashbang !== false,
+                hashbang: options.hashbang !== false
-                enableHistory: enableHistory()
             });
         }).catch().then(function() {
             loading.hide();
@@ -319,10 +313,6 @@ define(['loading', 'globalize', 'events', 'viewManager', 'skinManager', 'backdro
 
     function enableHistory() {
 
-        //if (browser.edgeUwp) {
-        //    return false;
-        //}
-
         // shows status bar on navigation
         if (browser.xboxOne) {
             return false;

src/components/apphost.js

@@ -257,12 +257,6 @@ define(['appSettings', 'browser', 'events', 'htmlMediaHelper', 'webSettings', 'g
             features.push('fullscreenchange');
         }
 
-        if (browser.chrome || browser.edge && !browser.slow) {
-            if (!browser.noAnimation && !browser.edgeUwp && !browser.xboxOne) {
-                features.push('imageanalysis');
-            }
-        }
-
         if (browser.tv || browser.xboxOne || browser.ps4 || browser.mobile) {
             features.push('physicalvolumecontrol');
         }

src/components/collectionEditor/collectionEditor.js

@@ -249,6 +249,7 @@ import 'flexStyles';
             html += '</h3>';
 
             if (appHost.supports('externallinks')) {
+                // TODO: Change to Jellyfin docs
                 html += `<a is="emby-linkbutton" class="button-link btnHelp flex align-items-center" href="https://web.archive.org/web/20181216120305/https://github.com/MediaBrowser/Wiki/wiki/Collections" target="_blank" style="margin-left:auto;margin-right:.5em;padding:.25em;" title="${globalize.translate('Help')}"><span class="material-icons info"></span><span style="margin-left:.25em;">${globalize.translate('Help')}</span></a>`;
             }
 

src/components/dialog/dialog.js

@@ -45,9 +45,9 @@ import 'flexStyles';
             dlg.classList.add('dialog-fullscreen-lowres');
         }
 
-        //dlg.querySelector('.btnCancel').addEventListener('click', function (e) {
+        dlg.querySelector('.btnCancel').addEventListener('click', function (e) {
-        //    dialogHelper.close(dlg);
+            dialogHelper.close(dlg);
-        //});
+        });
 
         if (options.title) {
             dlg.querySelector('.formDialogHeaderTitle').innerHTML = options.title || '';

src/components/favoriteitems.js

@@ -154,8 +154,7 @@ define(['loading', 'libraryBrowser', 'cardBuilder', 'dom', 'apphost', 'imageLoad
                     html += '<div is="emby-itemscontainer" class="itemsContainer vertical-wrap padded-left padded-right">';
                 }
 
-                var supportsImageAnalysis = appHost.supports('imageanalysis');
+                var cardLayout = appHost.preferVisualCards && section.autoCardLayout && section.showTitle;
-                var cardLayout = (appHost.preferVisualCards || supportsImageAnalysis) && section.autoCardLayout && section.showTitle;
                 cardLayout = false;
                 html += cardBuilder.getCardsHtml(result.Items, {
                     preferThumb: section.preferThumb,

src/components/filtermenu/filtermenu.js

@@ -39,34 +39,11 @@ define(['require', 'dom', 'focusManager', 'dialogHelper', 'loading', 'apphost',
     }
 
     function renderDynamicFilters(context, result, options) {
-
-        // If there's a huge number of these they will be really show to render
-        //if (result.Tags) {
-        //    result.Tags.length = Math.min(result.Tags.length, 50);
-        //}
-
         renderOptions(context, '.genreFilters', 'chkGenreFilter', result.Genres, function (i) {
-
             // Switching from | to ,
             var delimeter = (options.settings.GenreIds || '').indexOf('|') === -1 ? ',' : '|';
             return (delimeter + (options.settings.GenreIds || '') + delimeter).indexOf(delimeter + i.Id + delimeter) !== -1;
         });
-
-        //renderOptions(context, '.officialRatingFilters', 'chkOfficialRatingFilter', result.OfficialRatings, function (i) {
-        //    var delimeter = '|';
-        //    return (delimeter + (query.OfficialRatings || '') + delimeter).indexOf(delimeter + i + delimeter) != -1;
-        //});
-
-        //renderOptions(context, '.tagFilters', 'chkTagFilter', result.Tags, function (i) {
-        //    var delimeter = '|';
-        //    return (delimeter + (query.Tags || '') + delimeter).indexOf(delimeter + i + delimeter) != -1;
-        //});
-
-        //renderOptions(context, '.yearFilters', 'chkYearFilter', result.Years, function (i) {
-
-        //    var delimeter = ',';
-        //    return (delimeter + (query.Years || '') + delimeter).indexOf(delimeter + i + delimeter) != -1;
-        //});
     }
 
     function loadDynamicFilters(context, options) {
@@ -81,11 +58,7 @@ define(['require', 'dom', 'focusManager', 'dialogHelper', 'loading', 'apphost',
         });
 
         apiClient.getFilters(filterMenuOptions).then(function (result) {
-
             renderDynamicFilters(context, result, options);
-        }, function () {
-
-            // older server
         });
     }
 
@@ -314,13 +287,7 @@ define(['require', 'dom', 'focusManager', 'dialogHelper', 'loading', 'apphost',
                 var submitted;
 
                 dlg.querySelector('form').addEventListener('change', function () {
-
                     submitted = true;
-                    //if (options.onChange) {
-                    //    saveValues(dlg, options.settings, options.settingsKey);
-                    //    options.onChange();
-                    //}
-
                 }, true);
 
                 dialogHelper.open(dlg).then(function () {

src/components/focusManager.js

@@ -272,14 +272,10 @@ define(['dom', 'scrollManager'], function (dom, scrollManager) {
         var rect = getOffset(activeElement);
 
         // Get elements and work out x/y points
-        var cache = [];
         var point1x = parseFloat(rect.left) || 0;
         var point1y = parseFloat(rect.top) || 0;
         var point2x = parseFloat(point1x + rect.width - 1) || point1x;
         var point2y = parseFloat(point1y + rect.height - 1) || point1y;
-        // Shortcuts to help with compression
-        var min = Math.min;
-        var max = Math.max;
 
         var sourceMidX = rect.left + (rect.width / 2);
         var sourceMidY = rect.top + (rect.height / 2);
@@ -301,10 +297,6 @@ define(['dom', 'scrollManager'], function (dom, scrollManager) {
                 continue;
             }
 
-            //if (!isCurrentlyFocusableInternal(curr)) {
-            //    continue;
-            //}
-
             var elementRect = getOffset(curr);
 
             // not currently visible

src/components/guide/guide.js

@@ -43,11 +43,9 @@ define(['require', 'inputManager', 'browser', 'globalize', 'connectionManager',
 
         if (guideProgramName) {
             if (pctOfWidth > 0 && pctOfWidth <= 100) {
-                //guideProgramName.style.marginLeft = pctOfWidth + '%';
                 guideProgramName.style.transform = 'translateX(' + pctOfWidth + '%)';
                 caret.classList.remove('hide');
             } else {
-                //guideProgramName.style.marginLeft = '0';
                 guideProgramName.style.transform = 'none';
                 caret.classList.add('hide');
             }
@@ -121,7 +119,6 @@ define(['require', 'inputManager', 'browser', 'globalize', 'connectionManager',
         var cellCurationMinutes = 30;
         var cellDurationMs = cellCurationMinutes * 60 * 1000;
         var msPerDay = 86400000;
-        var totalRendererdMs = msPerDay;
 
         var currentDate;
         var currentStartIndex = 0;
@@ -577,7 +574,6 @@ define(['require', 'inputManager', 'browser', 'globalize', 'connectionManager',
                     html += '</div>';
 
                     if (program.IsHD && options.showHdIcon) {
-                        //html += '<span class="guideHdIcon material-icons programIcon hd"></span>';
                         if (layoutManager.tv) {
                             html += '<div class="programIcon guide-programTextIcon guide-programTextIcon-tv">HD</div>';
                         } else {
@@ -866,6 +862,7 @@ define(['require', 'inputManager', 'browser', 'globalize', 'connectionManager',
             var dateTabsHtml = '';
             var tabIndex = 0;
 
+            // TODO: Use date-fns
             var date = new Date();
 
             if (currentDate) {
@@ -873,7 +870,6 @@ define(['require', 'inputManager', 'browser', 'globalize', 'connectionManager',
             }
 
             date.setHours(nowHours, 0, 0, 0);
-            //start.setHours(0, 0, 0, 0);
 
             var startTimeOfDayMs = (start.getHours() * 60 * 60 * 1000);
             startTimeOfDayMs += start.getMinutes() * 60 * 1000;
@@ -951,8 +947,6 @@ define(['require', 'inputManager', 'browser', 'globalize', 'connectionManager',
             var focusableElements;
             var newRow;
 
-            var scrollX = false;
-
             switch (e.detail.command) {
 
                 case 'up':
@@ -1018,7 +1012,6 @@ define(['require', 'inputManager', 'browser', 'globalize', 'connectionManager',
                     focusManager.moveLeft(target, {
                         container: container
                     });
-                    scrollX = true;
                     break;
                 case 'right':
                     container = programCell ? dom.parentWithClass(programCell, 'channelPrograms') : null;
@@ -1027,7 +1020,6 @@ define(['require', 'inputManager', 'browser', 'globalize', 'connectionManager',
                     focusManager.moveRight(target, {
                         container: container
                     });
-                    scrollX = true;
                     break;
                 default:
                     return;

src/components/homeScreenSettings/homeScreenSettings.js

@@ -148,9 +148,7 @@ import 'emby-checkbox';
 
         let html = '';
 
-        let index = 0;
+        html += result.Items.map((view) => {
-
-        html += result.Items.map(view => {
 
             let currentHtml = '';
 
@@ -171,7 +169,6 @@ import 'emby-checkbox';
 
             currentHtml += '</div>';
 
-            index++;
             return currentHtml;
 
         }).join('');
@@ -305,8 +302,6 @@ import 'emby-checkbox';
             const viewItem = dom.parentWithClass(target, 'viewItem');
 
             if (viewItem) {
-                const ul = dom.parentWithClass(viewItem, 'paperList');
-
                 if (target.classList.contains('btnViewItemDown')) {
 
                     const next = viewItem.nextSibling;

src/components/homesections/homesections.js

@@ -1,13 +1,9 @@
 import connectionManager from 'connectionManager';
 import cardBuilder from 'cardBuilder';
-import appSettings from 'appSettings';
 import dom from 'dom';
-import appHost from 'apphost';
 import layoutManager from 'layoutManager';
 import imageLoader from 'imageLoader';
 import globalize from 'globalize';
-import itemShortcuts from 'itemShortcuts';
-import itemHelper from 'itemHelper';
 import appRouter from 'appRouter';
 import imageHelper from 'scripts/imagehelper';
 import 'paper-icon-button-light';
@@ -215,14 +211,6 @@ import 'css!./homesections';
         imageLoader.lazyChildren(elem);
     }
 
-    /**
-     * Returns a random integer between min (inclusive) and max (inclusive)
-     * Using Math.round() will give you a non-uniform distribution!
-     */
-    function getRandomInt(min, max) {
-        return Math.floor(Math.random() * (max - min + 1)) + min;
-    }
-
     function getFetchLatestItemsFn(serverId, parentId, collectionType) {
         return function () {
             const apiClient = connectionManager.getApiClient(serverId);
@@ -347,14 +335,6 @@ import 'css!./homesections';
         }
     }
 
-    function getRequirePromise(deps) {
-        return new Promise(function (resolve, reject) {
-            import(deps).then(() => {
-                return resolve;
-            });
-        });
-    }
-
     export function loadLibraryTiles(elem, apiClient, user, userSettings, shape, userViews, allSections) {
         let html = '';
         if (userViews.length) {
@@ -549,7 +529,6 @@ import 'css!./homesections';
     }
 
     function getOnNowItemsHtml(items) {
-        const cardLayout = false;
         return cardBuilder.getCardsHtml({
             items: items,
             preferThumb: 'auto',
@@ -576,7 +555,6 @@ import 'css!./homesections';
             return Promise.resolve();
         }
 
-        const userId = user.Id;
         return apiClient.getLiveTvRecommendedPrograms({
             userId: apiClient.getCurrentUserId(),
             IsAiring: true,
@@ -766,7 +744,6 @@ import 'css!./homesections';
 
     function getLatestRecordingItemsHtml(activeRecordingsOnly) {
         return function (items) {
-            const cardLayout = false;
             return cardBuilder.getCardsHtml({
                 items: items,
                 shape: enableScrollX() ? 'autooverflow' : 'auto',

src/components/htmlMediaHelper.js

@@ -33,32 +33,6 @@ import events from 'events';
         return false;
     }
 
-    export function enableHlsShakaPlayer(item, mediaSource, mediaType) {
-        /* eslint-disable-next-line compat/compat */
-        if (!!window.MediaSource && !!MediaSource.isTypeSupported) {
-
-            if (canPlayNativeHls()) {
-
-                if (browser.edge && mediaType === 'Video') {
-                    return true;
-                }
-
-                // simple playback should use the native support
-                if (mediaSource.RunTimeTicks) {
-                    //if (!browser.edge) {
-                    //return false;
-                    //}
-                }
-
-                //return false;
-            }
-
-            return true;
-        }
-
-        return false;
-    }
-
     export function enableHlsJsPlayer(runTimeTicks, mediaType) {
 
         if (window.MediaSource == null) {
@@ -170,7 +144,6 @@ import events from 'events';
         var seconds = (ticks || 0) / 10000000;
 
         if (seconds) {
-            var src = (instance.currentSrc() || '').toLowerCase();
 
             // Appending #t=xxx to the query string doesn't seem to work with HLS
             // For plain video files, not all browsers support it either

src/components/imageDownloader/imageDownloader.js

@@ -270,7 +270,6 @@ define(['dom', 'loading', 'apphost', 'dialogHelper', 'connectionManager', 'image
         // end footer
 
         html += '</div>';
-        //html += '</div>';
 
         html += '</' + tagName + '>';
 

src/components/listview/listview.js

@@ -270,8 +270,6 @@ import 'emby-playstatebutton';
             }
 
             if (!clickEntireItem && options.dragHandle) {
-                //html += '<button is="paper-icon-button-light" class="listViewDragHandle listItemButton"><span class="material-icons drag_handle"></span></button>';
-                // Firefox and Edge are not allowing the button to be draggable
                 html += '<span class="listViewDragHandle material-icons listItemIcon listItemIcon-transparent drag_handle"></span>';
             }
 

src/components/maintabsmanager.js

@@ -16,9 +16,6 @@ import 'emby-button';
         return false;
     }
 
-    function getTabsContainerElem() {
-    }
-
     function ensureElements(enableInFooter) {
 
         if (enableInFooter) {
@@ -27,7 +24,6 @@ import 'emby-button';
                 footerTabsContainer.classList.add('footerTabs');
                 footerTabsContainer.classList.add('sectionTabs');
                 footerTabsContainer.classList.add('hide');
-                //appFooter.add(footerTabsContainer);
             }
         }
 
@@ -75,7 +71,6 @@ import 'emby-button';
         }
 
         // implement without hammer
-        const pageCount = getTabContainersFn().length;
         const onSwipeLeft = function (e, target) {
             if (allowSwipe(target) && view.contains(target)) {
                 tabsElem.selectNext();
@@ -193,12 +188,6 @@ import 'emby-button';
 
                 const newPanel = tabContainers[e.detail.selectedTabIndex];
 
-                //if (e.detail.previousIndex != null && e.detail.previousIndex != e.detail.selectedTabIndex) {
-                //    if (newPanel.animate && (animateTabs || []).indexOf(e.detail.selectedTabIndex) != -1) {
-                //        fadeInRight(newPanel);
-                //    }
-                //}
-
                 if (newPanel) {
                     newPanel.classList.add('is-active');
                 }
@@ -221,10 +210,6 @@ import 'emby-button';
                 }
             }
 
-            //if (enableSwipe !== false) {
-            //    libraryBrowser.configureSwipeTabs(ownerpage, tabs);
-            //}
-
             return {
                 tabsContainer: tabsContainerElem,
                 tabs: tabsContainerElem.querySelector('[is="emby-tabs"]'),

src/components/mediainfo/mediainfo.js

@@ -568,10 +568,6 @@ import 'emby-button';
             });
         }
 
-        //if (mediaSource.Container) {
-        //    html += '<div class="mediaInfoIcon mediaInfoText">' + mediaSource.Container + '</div>';
-        //}
-
         const resolutionText = getResolutionText(videoStream);
         if (resolutionText) {
             list.push({

src/components/multiSelect/multiSelect.js

@@ -580,10 +580,9 @@ import 'css!./multiSelect';
             dom.removeEventListener(element, 'touchend', onTouchEnd, {
                 passive: true
             });
-            // this fires in safari due to magnifying class
+            dom.removeEventListener(element, 'touchcancel', onTouchEnd, {
-            //dom.removeEventListener(element, "touchcancel", onTouchEnd, {
+                passive: true
-            //    passive: true
+            });
-            //});
             dom.removeEventListener(element, 'mousedown', onMouseDown, {
                 passive: true
             });

src/components/notifications/notifications.js

@@ -101,11 +101,7 @@ define(['serverNotifications', 'playbackManager', 'events', 'globalize', 'requir
             body: body,
             vibrate: true,
             tag: 'newItem' + item.Id,
-            data: {
+            data: {}
-                //options: {
-                //    url: LibraryBrowser.getHref(item)
-                //}
-            }
         };
 
         var imageTags = item.ImageTags || {};

src/components/playback/playbackmanager.js

@@ -777,7 +777,6 @@ define(['events', 'datetime', 'appSettings', 'itemHelper', 'pluginManager', 'pla
 
         var players = [];
         var currentTargetInfo;
-        var lastLocalPlayer;
         var currentPairingId = null;
 
         this._playNextAfterEnded = true;
@@ -1031,10 +1030,6 @@ define(['events', 'datetime', 'appSettings', 'itemHelper', 'pluginManager', 'pla
                 console.debug('Active player: ' + JSON.stringify(targetInfo));
             }
 
-            if (player && player.isLocalPlayer) {
-                lastLocalPlayer = player;
-            }
-
             if (previousPlayer) {
                 self.endPlayerUpdates(previousPlayer);
             }
@@ -4076,8 +4071,7 @@ define(['events', 'datetime', 'appSettings', 'itemHelper', 'pluginManager', 'pla
                 this.setSubtitleStreamIndex(parseInt(cmd.Arguments.Index), player);
                 break;
             case 'SetMaxStreamingBitrate':
-                // todo
+                this.setMaxStreamingBitrate(parseInt(cmd.Arguments.Bitrate), player);
-                //this.setMaxStreamingBitrate(parseInt(cmd.Arguments.Bitrate), player);
                 break;
             case 'ToggleFullscreen':
                 this.toggleFullscreen(player);

src/components/playback/playerSelectionMenu.js

@@ -182,7 +182,6 @@ function disconnectFromPlayer(currentDeviceName) {
 
             dialog({
                 buttons: menuItems,
-                //positionTo: positionTo,
                 text: globalize.translate('ConfirmEndPlayerSession', currentDeviceName)
 
             }).then(function (id) {

src/components/playback/playersettingsmenu.js

@@ -88,8 +88,6 @@ function showRepeatModeMenu(player, btn) {
 
 function getQualitySecondaryText(player) {
     var state = playbackManager.getPlayerState(player);
-    var isAutoEnabled = playbackManager.enableAutomaticBitrateDetection(player);
-    var currentMaxBitrate = playbackManager.getMaxStreamingBitrate(player);
 
     var videoStream = playbackManager.currentMediaSource(player).MediaStreams.filter(function (stream) {
         return stream.Type === 'Video';
@@ -106,20 +104,6 @@ function getQualitySecondaryText(player) {
         enableAuto: true
     });
 
-    var menuItems = options.map(function (o) {
-        var opt = {
-            name: o.name,
-            id: o.bitrate,
-            asideText: o.secondaryText
-        };
-
-        if (o.selected) {
-            opt.selected = true;
-        }
-
-        return opt;
-    });
-
     var selectedOption = options.filter(function (o) {
         return o.selected;
     });
@@ -168,7 +152,6 @@ function showAspectRatioMenu(player, btn) {
 
 function showWithUser(options, player, user) {
     var supportedCommands = playbackManager.getSupportedCommands(player);
-    var mediaType = options.mediaType;
 
     var menuItems = [];
     if (supportedCommands.indexOf('SetAspectRatio') !== -1) {

src/components/playerstats/playerstats.js

@@ -132,7 +132,6 @@ import 'css!./playerstats';
         let audioChannels;
 
         if (session.TranscodingInfo) {
-
             videoCodec = session.TranscodingInfo.VideoCodec;
             audioCodec = session.TranscodingInfo.AudioCodec;
             totalBitrate = session.TranscodingInfo.Bitrate;
@@ -140,7 +139,6 @@ import 'css!./playerstats';
         }
 
         if (videoCodec) {
-
             sessionStats.push({
                 label: globalize.translate('LabelVideoCodec'),
                 value: session.TranscodingInfo.IsVideoDirect ? (videoCodec.toUpperCase() + ' (direct)') : videoCodec.toUpperCase()
@@ -148,20 +146,18 @@ import 'css!./playerstats';
         }
 
         if (audioCodec) {
-
             sessionStats.push({
                 label: globalize.translate('LabelAudioCodec'),
                 value: session.TranscodingInfo.IsAudioDirect ? (audioCodec.toUpperCase() + ' (direct)') : audioCodec.toUpperCase()
             });
         }
 
-        //if (audioChannels) {
+        if (audioChannels) {
-
+            sessionStats.push({
-        //    sessionStats.push({
+                label: globalize.translate('LabelAudioChannels'),
-        //        label: 'Audio channels:',
+                value: audioChannels
-        //        value: audioChannels
+            });
-        //    });
+        }
-        //}
 
         if (displayPlayMethod === 'Transcode') {
             if (totalBitrate) {

src/components/qualityOptions.js

@@ -14,7 +14,6 @@ define(['globalize'], function (globalize) {
         }
 
         var maxAllowedWidth = videoWidth || 4096;
-        //var maxAllowedHeight = videoHeight || 2304;
 
         var qualityOptions = [];
 

src/components/recordingcreator/recordingeditor.js

@@ -19,9 +19,6 @@ define(['dialogHelper', 'globalize', 'layoutManager', 'mediaInfo', 'apphost', 'c
     }
 
     function renderTimer(context, item, apiClient) {
-
-        var program = item.ProgramInfo || {};
-
         context.querySelector('#txtPrePaddingMinutes').value = item.PrePaddingSeconds / 60;
         context.querySelector('#txtPostPaddingMinutes').value = item.PostPaddingSeconds / 60;
 

src/components/recordingcreator/seriesrecordingeditor.js

@@ -20,8 +20,6 @@ define(['dialogHelper', 'globalize', 'layoutManager', 'mediaInfo', 'apphost', 'c
 
     function renderTimer(context, item, apiClient) {
 
-        var program = item.ProgramInfo || {};
-
         context.querySelector('#txtPrePaddingMinutes').value = item.PrePaddingSeconds / 60;
         context.querySelector('#txtPostPaddingMinutes').value = item.PostPaddingSeconds / 60;
 

src/components/remotecontrol/remotecontrol.js

@@ -222,7 +222,6 @@ define(['browser', 'datetime', 'backdrop', 'libraryBrowser', 'listView', 'imageL
     }
 
     function setImageUrl(context, state, url) {
-        currentImgUrl = url;
         var item = state.NowPlayingItem;
         var imgContainer = context.querySelector('.nowPlayingPageImageContainer');
 
@@ -257,7 +256,6 @@ define(['browser', 'datetime', 'backdrop', 'libraryBrowser', 'listView', 'imageL
         }
     }
 
-    var currentImgUrl;
     return function () {
         function toggleRepeat() {
             switch (playbackManager.getRepeatMode()) {
@@ -909,7 +907,6 @@ define(['browser', 'datetime', 'backdrop', 'libraryBrowser', 'listView', 'imageL
         }
 
         function onShow(context, tab) {
-            currentImgUrl = null;
             bindToPlayer(context, playbackManager.getCurrentPlayer());
         }
 

src/components/sanitizeFilename.js

@@ -1,3 +1,4 @@
+// TODO: Check if needed and move to external dependency
 // From https://github.com/parshap/node-sanitize-filename
 
 const illegalRe = /[\/\?<>\\:\*\|":]/g;

src/components/slideshow/slideshow.js

@@ -130,8 +130,6 @@ define(['dialogHelper', 'inputManager', 'connectionManager', 'layoutManager', 'f
         var hideTimeout;
         /** Last coordinates of the mouse pointer. */
         var lastMouseMoveData;
-        /** Visibility status of the OSD. */
-        var _osdOpen = false;
 
         // Use autoplay on Chromecast since it is non-interactive.
         if (browser.chromecast) options.interactive = false;
@@ -363,8 +361,6 @@ define(['dialogHelper', 'inputManager', 'connectionManager', 'layoutManager', 'f
         function getSwiperSlideHtmlFromItem(item) {
             return getSwiperSlideHtmlFromSlide({
                 originalImage: getImgUrl(item, currentOptions.user),
-                //title: item.Name,
-                //description: item.Overview
                 Id: item.Id,
                 ServerId: item.ServerId
             });
@@ -545,7 +541,6 @@ define(['dialogHelper', 'inputManager', 'connectionManager', 'layoutManager', 'f
                 return;
             }
 
-            _osdOpen = true;
             element.classList.remove('hide');
 
             var onFinish = function () {
@@ -578,7 +573,6 @@ define(['dialogHelper', 'inputManager', 'connectionManager', 'layoutManager', 'f
 
             var onFinish = function () {
                 element.classList.add('hide');
-                _osdOpen = false;
             };
 
             if (!element.animate) {

src/components/sortmenu/sortmenu.js

@@ -90,13 +90,7 @@ define(['require', 'dom', 'focusManager', 'dialogHelper', 'loading', 'layoutMana
                 var submitted;
 
                 dlg.querySelector('form').addEventListener('change', function () {
-
                     submitted = true;
-                    //if (options.onChange) {
-                    //    saveValues(dlg, options.settings, options.settingsKey);
-                    //    options.onChange();
-                    //}
-
                 }, true);
 
                 dialogHelper.open(dlg).then(function () {
@@ -106,11 +100,8 @@ define(['require', 'dom', 'focusManager', 'dialogHelper', 'loading', 'layoutMana
                     }
 
                     if (submitted) {
-
-                        //if (!options.onChange) {
                         saveValues(dlg, options.settings, options.settingsKey);
                         resolve();
-                        //}
                         return;
                     }
 

src/components/subtitleeditor/subtitleeditor.js

@@ -4,43 +4,6 @@ define(['dialogHelper', 'require', 'layoutManager', 'globalize', 'userSettings',
     var currentItem;
     var hasChanges;
 
-    function showLocalSubtitles(context, index) {
-
-        loading.show();
-
-        var subtitleContent = context.querySelector('.subtitleContent');
-        subtitleContent.innerHTML = '';
-
-        var apiClient = connectionManager.getApiClient(currentItem.ServerId);
-        var url = 'Videos/' + currentItem.Id + '/Subtitles/' + index;
-
-        apiClient.ajax({
-
-            type: 'GET',
-            url: url
-
-        }).then(function (result) {
-
-            subtitleContent.innerHTML = result;
-
-            loading.hide();
-        });
-    }
-
-    function showRemoteSubtitles(context, id) {
-
-        loading.show();
-
-        var url = 'Providers/Subtitles/Subtitles/' + id;
-
-        ApiClient.get(ApiClient.getUrl(url)).then(function (result) {
-
-            // show result
-
-            loading.hide();
-        });
-    }
-
     function downloadRemoteSubtitles(context, id) {
 
         var url = 'Items/' + currentItem.Id + '/RemoteSearch/Subtitles/' + id;
@@ -170,14 +133,6 @@ define(['dialogHelper', 'require', 'layoutManager', 'globalize', 'userSettings',
             elem.classList.add('hide');
         }
         elem.innerHTML = html;
-
-        //('.btnViewSubtitles', elem).on('click', function () {
-
-        //    var index = this.getAttribute('data-index');
-
-        //    showLocalSubtitles(context, index);
-
-        //});
     }
 
     function fillLanguages(context, apiClient, languages) {
@@ -250,8 +205,6 @@ define(['dialogHelper', 'require', 'layoutManager', 'globalize', 'userSettings',
 
             html += '<div class="listItemBody ' + bodyClass + '">';
 
-            //html += '<a class="btnViewSubtitle" href="#" data-subid="' + result.Id + '">';
-
             html += '<div>' + (result.Name) + '</div>';
             html += '<div class="secondary listItemBodyText">';
 
@@ -272,8 +225,6 @@ define(['dialogHelper', 'require', 'layoutManager', 'globalize', 'userSettings',
                 html += '<div class="secondary listItemBodyText"><div class="inline-flex align-items-center justify-content-center" style="background:#3388cc;color:#fff;padding: .3em 1em;border-radius:1000em;">' + globalize.translate('PerfectMatch') + '</div></div>';
             }
 
-            //html += '</a>';
-
             html += '</div>';
 
             if (!layoutManager.tv) {
@@ -290,12 +241,6 @@ define(['dialogHelper', 'require', 'layoutManager', 'globalize', 'userSettings',
         var elem = context.querySelector('.subtitleResults');
         elem.innerHTML = html;
 
-        //('.btnViewSubtitle', elem).on('click', function () {
-
-        //    var id = this.getAttribute('data-subid');
-        //    showRemoteSubtitles(context, id);
-        //});
-
         loading.hide();
     }
 
@@ -369,11 +314,10 @@ define(['dialogHelper', 'require', 'layoutManager', 'globalize', 'userSettings',
     }
 
     function onSubtitleResultsClick(e) {
-
-        var btnOptions = dom.parentWithClass(e.target, 'btnOptions');
         var subtitleId;
         var context;
 
+        var btnOptions = dom.parentWithClass(e.target, 'btnOptions');
         if (btnOptions) {
             subtitleId = btnOptions.getAttribute('data-subid');
             context = dom.parentWithClass(btnOptions, 'subtitleEditorDialog');

src/components/tabbedview/itemstab.js

@@ -286,9 +286,6 @@ define(['playbackManager', 'userSettings', 'alphaPicker', 'alphaNumericShortcuts
         bindAll(view.querySelectorAll('.btnShuffle'), 'click', shuffle.bind(this));
     }
 
-    function getSettingValue(key, defaultValue) {
-    }
-
     ItemsTab.prototype.getViewSettings = function () {
 
         var basekey = this.getSettingsKey();
@@ -507,16 +504,10 @@ define(['playbackManager', 'userSettings', 'alphaPicker', 'alphaNumericShortcuts
     };
 
     ItemsTab.prototype.getFilterMenuOptions = function () {
-
+        return {};
-        var params = this.params;
-
-        return {
-
-        };
     };
 
     ItemsTab.prototype.getItemTypes = function () {
-
         return [];
     };
 

src/components/themeMediaPlayer.js

@@ -100,12 +100,12 @@ define(['playbackManager', 'userSettings', 'connectionManager'], function (playb
 
     }, true);
 
-    //Events.on(playbackManager, 'playbackstart', function (e, player) {
+    Events.on(playbackManager, 'playbackstart', function (e, player) {
-    //    var item = playbackManager.currentItem(player);
+        var item = playbackManager.currentItem(player);
-    //    // User played something manually
+        // User played something manually
-    //    if (currentThemeIds.indexOf(item.Id) == -1) {
+        if (currentThemeIds.indexOf(item.Id) == -1) {
-    //        currentOwnerId = null;
+            currentOwnerId = null;
-    //    }
+        }
-    //});
+    });
 
 });

src/components/userdatabuttons/userdatabuttons.js

@@ -112,22 +112,6 @@ define(['connectionManager', 'globalize', 'dom', 'itemHelper', 'paper-icon-butto
             }
         }
 
-        //var tooltipLike = globalize.translate('Like');
-        //var tooltipDislike = globalize.translate('Dislike');
-
-        //if (typeof userData.Likes == "undefined") {
-        //    html += getUserDataButtonHtml('markDislike', itemId, serverId, btnCssClass + ' btnUserData btnDislike', 'thumb-down', tooltipDislike);
-        //    html += getUserDataButtonHtml('markLike', itemId, serverId, btnCssClass + ' btnUserData btnLike', 'thumb-up', tooltipLike);
-        //}
-        //else if (userData.Likes) {
-        //    html += getUserDataButtonHtml('markDislike', itemId, serverId, btnCssClass + ' btnUserData btnDislike', 'thumb-down', tooltipDislike);
-        //    html += getUserDataButtonHtml('markLike', itemId, serverId, btnCssClass + ' btnUserData btnLike btnUserDataOn', 'thumb-up', tooltipLike);
-        //}
-        //else {
-        //    html += getUserDataButtonHtml('markDislike', itemId, serverId, btnCssClass + ' btnUserData btnDislike btnUserDataOn', 'thumb-down', tooltipDislike);
-        //    html += getUserDataButtonHtml('markLike', itemId, serverId, btnCssClass + ' btnUserData btnLike', 'thumb-up', tooltipLike);
-        //}
-
         var tooltipFavorite = globalize.translate('Favorite');
         if (userData.IsFavorite) {
 

src/components/viewManager/viewManager.js

@@ -21,11 +21,10 @@ define(['viewContainer', 'focusManager', 'queryString', 'layoutManager'], functi
         if (!newView.initComplete) {
             newView.initComplete = true;
 
-            var controller;
             if (typeof options.controllerFactory === 'function') {
-                controller = new options.controllerFactory(newView, eventDetail.detail.params);
+                new options.controllerFactory(newView, eventDetail.detail.params);
             } else if (options.controllerFactory && typeof options.controllerFactory.default === 'function') {
-                controller = new options.controllerFactory.default(newView, eventDetail.detail.params);
+                new options.controllerFactory.default(newView, eventDetail.detail.params);
             }
 
             if (!options.controllerFactory || dispatchPageEvents) {

src/controllers/auth/selectserver.js

@@ -95,11 +95,6 @@ import 'emby-button';
         }
     }
 
-    function showGeneralError() {
-        loading.hide();
-        alertText(globalize.translate('DefaultErrorMessage'));
-    }
-
     function alertText(text) {
         alertTextWithOptions({
             text: text

src/controllers/dashboard/plugins/available.js

@@ -34,7 +34,6 @@ define(['loading', 'libraryMenu', 'globalize', 'cardStyle', 'emby-button', 'emby
         var availablePlugins = options.availablePlugins;
         var installedPlugins = options.installedPlugins;
 
-        var categories = [];
         availablePlugins.forEach(function (plugin, index, array) {
             plugin.category = plugin.category || 'General';
             plugin.categoryDisplayName = getHeaderText(plugin.category);

src/controllers/dashboard/users/userprofilespage.js

@@ -155,102 +155,12 @@ import 'flexStyles';
         page.querySelector('.localUsers').innerHTML = getUserSectionHtml(users, true);
     }
 
-    function showPendingUserMenu(elem) {
-        const menuItems = [];
-        menuItems.push({
-            name: globalize.translate('ButtonCancel'),
-            id: 'delete',
-            icon: 'delete'
-        });
-
-        import('actionsheet').then(({default: actionsheet}) => {
-            const card = dom.parentWithClass(elem, 'card');
-            const page = dom.parentWithClass(card, 'page');
-            const id = card.getAttribute('data-id');
-            actionsheet.show({
-                items: menuItems,
-                positionTo: card,
-                callback: function (menuItemId) {
-                    switch (menuItemId) {
-                        case 'delete':
-                            cancelAuthorization(page, id);
-                    }
-                }
-            });
-        });
-    }
-
-    function getPendingUserHtml(user) {
-        let html = '';
-        html += "<div data-id='" + user.Id + "' class='card squareCard scalableCard squareCard-scalable'>";
-        html += '<div class="cardBox cardBox-bottompadded visualCardBox">';
-        html += '<div class="cardScalable visualCardBox-cardScalable">';
-        html += '<div class="cardPadder cardPadder-square"></div>';
-        html += '<a class="cardContent cardImageContainer" is="emby-linkbutton" href="#">';
-
-        if (user.ImageUrl) {
-            html += '<div class="cardImage" style="background-image:url(\'' + user.ImageUrl + "');\">";
-            html += '</div>';
-        } else {
-            html += '<span class="cardImageIcon material-icons person"></span>';
-        }
-
-        html += '</a>';
-        html += '</div>';
-        html += '<div class="cardFooter visualCardBox-cardFooter">';
-        html += '<div class="cardText" style="text-align:right; float:right;padding:0;">';
-        html += '<button type="button" is="paper-icon-button-light" class="btnUserMenu"><span class="material-icons more_vert"></span></button>';
-        html += '</div>';
-        html += '<div class="cardText" style="padding-top:10px;padding-bottom:10px;">';
-        html += user.UserName;
-        html += '</div>';
-        html += '</div>';
-        html += '</div>';
-        return html + '</div>';
-    }
-
-    function renderPendingGuests(page, users) {
-        if (users.length) {
-            page.querySelector('.sectionPendingGuests').classList.remove('hide');
-        } else {
-            page.querySelector('.sectionPendingGuests').classList.add('hide');
-        }
-
-        page.querySelector('.pending').innerHTML = users.map(getPendingUserHtml).join('');
-    }
-
-    // TODO cvium: maybe reuse for invitation system
-    function cancelAuthorization(page, id) {
-        loading.show();
-        ApiClient.ajax({
-            type: 'DELETE',
-            url: ApiClient.getUrl('Connect/Pending', {
-                Id: id
-            })
-        }).then(function () {
-            loadData(page);
-        });
-    }
-
     function loadData(page) {
         loading.show();
         ApiClient.getUsers().then(function (users) {
             renderUsers(page, users);
             loading.hide();
         });
-        // TODO cvium
-        renderPendingGuests(page, []);
-        // ApiClient.getJSON(ApiClient.getUrl("Connect/Pending")).then(function (pending) {
-        //
-        // });
-    }
-
-    function showInvitePopup(page) {
-        import('components/guestinviter/guestinviter').then(({default: guestinviter}) => {
-            guestinviter.show().then(function () {
-                loadData(page);
-            });
-        });
     }
 
     pageIdOn('pageinit', 'userProfilesPage', function () {
@@ -265,14 +175,8 @@ import 'flexStyles';
                 showUserMenu(btnUserMenu);
             }
         });
-        page.querySelector('.pending').addEventListener('click', function (e__r) {
-            const btnUserMenu = dom.parentWithClass(e__r.target, 'btnUserMenu');
-
-            if (btnUserMenu) {
-                showPendingUserMenu(btnUserMenu);
-            }
-        });
     });
+
     pageIdOn('pagebeforeshow', 'userProfilesPage', function () {
         loadData(this);
     });

src/controllers/favorites.js

@@ -170,8 +170,7 @@ define(['appRouter', 'cardBuilder', 'dom', 'globalize', 'connectionManager', 'ap
 
     function getItemsHtmlFn(section) {
         return function (items) {
-            var supportsImageAnalysis = appHost.supports('imageanalysis');
+            var cardLayout = appHost.preferVisualCards && section.autoCardLayout && section.showTitle;
-            var cardLayout = (appHost.preferVisualCards || supportsImageAnalysis) && section.autoCardLayout && section.showTitle;
             cardLayout = false;
             var serverId = this.apiClient.serverId();
             var leadingButtons = layoutManager.tv ? [{

src/controllers/itemDetails/index.js

@@ -1678,6 +1678,7 @@ define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSetti
             require(['alert'], function (alert) {
                 alert.default({
                     text: globalize.translate('AddItemToCollectionHelp'),
+                    // TODO: Change to Jellyfin docs
                     html: globalize.translate('AddItemToCollectionHelp') + '<br/><br/><a is="emby-linkbutton" class="button-link" target="_blank" href="https://web.archive.org/web/20181216120305/https://github.com/MediaBrowser/Wiki/wiki/Collections">' + globalize.translate('ButtonLearnMore') + '</a>'
                 });
             });

src/controllers/livetv/livetvrecordings.js

@@ -24,7 +24,6 @@ define(['layoutManager', 'loading', 'cardBuilder', 'apphost', 'imageLoader', 'sc
             recordingItems.classList.add('vertical-wrap');
         }
 
-        appHost.supports('imageanalysis');
         recordingItems.innerHTML = cardBuilder.getCardsHtml(Object.assign({
             items: recordings,
             shape: scrollX ? 'autooverflow' : 'auto',

src/controllers/livetv/livetvschedule.js

@@ -30,17 +30,14 @@ define(['layoutManager', 'cardBuilder', 'apphost', 'imageLoader', 'loading', 'sc
             recordingItems.classList.add('vertical-wrap');
         }
 
-        var supportsImageAnalysis = appHost.supports('imageanalysis');
-        var cardLayout = appHost.preferVisualCards || supportsImageAnalysis;
-        cardLayout = false;
         recordingItems.innerHTML = cardBuilder.getCardsHtml(Object.assign({
             items: recordings,
             shape: enableScrollX() ? 'autooverflow' : 'auto',
             showTitle: true,
             showParentTitle: true,
             coverImage: true,
-            cardLayout: cardLayout,
+            cardLayout: appHost.preferVisualCards,
-            centerText: !cardLayout,
+            centerText: !appHost.preferVisualCards,
             allowBottomPadding: !enableScrollX(),
             preferThumb: 'auto'
         }, cardOptions || {}));

src/controllers/livetv/livetvseriestimers.js

@@ -3,7 +3,6 @@ define(['datetime', 'cardBuilder', 'imageLoader', 'apphost', 'loading', 'paper-i
 
     function renderTimers(context, timers) {
         var html = '';
-        appHost.supports('imageanalysis');
         html += cardBuilder.getCardsHtml({
             items: timers,
             shape: 'auto',

src/controllers/movies/moviegenres.js

@@ -75,7 +75,6 @@ define(['layoutManager', 'loading', 'libraryBrowser', 'cardBuilder', 'lazyLoader
                 ParentId: params.topParentId
             };
             ApiClient.getItems(ApiClient.getCurrentUserId(), query).then(function (result) {
-                var supportsImageAnalysis = appHost.supports('imageanalysis');
 
                 if (viewStyle == 'Thumb') {
                     cardBuilder.buildCards(result.Items, {

src/controllers/movies/moviesrecommended.js

@@ -346,8 +346,6 @@ define(['events', 'layoutManager', 'inputManager', 'userSettings', 'libraryMenu'
         function loadTab(page, index) {
             currentTabIndex = index;
             getTabController(page, index, function (controller) {
-                initialTabIndex = null;
-
                 if (renderedTabs.indexOf(index) == -1) {
                     renderedTabs.push(index);
                     controller.renderTab();
@@ -370,10 +368,8 @@ define(['events', 'layoutManager', 'inputManager', 'userSettings', 'libraryMenu'
             }
         }
 
-        var isViewRestored;
         var self = this;
         var currentTabIndex = parseInt(params.tab || getDefaultTabIndex(params.topParentId));
-        var initialTabIndex = currentTabIndex;
         var suggestionsTabIndex = 1;
 
         self.initTab = function () {
@@ -389,7 +385,8 @@ define(['events', 'layoutManager', 'inputManager', 'userSettings', 'libraryMenu'
         var tabControllers = [];
         var renderedTabs = [];
         view.addEventListener('viewshow', function (e) {
-            if (isViewRestored = e.detail.isRestored, initTabs(), !view.getAttribute('data-title')) {
+            initTabs();
+            if (!view.getAttribute('data-title')) {
                 var parentId = params.topParentId;
 
                 if (parentId) {

src/controllers/music/musicrecommended.js

@@ -41,8 +41,7 @@ define(['browser', 'layoutManager', 'userSettings', 'inputManager', 'loading', '
         };
         ApiClient.getJSON(ApiClient.getUrl('Users/' + userId + '/Items/Latest', options)).then(function (items) {
             var elem = page.querySelector('#recentlyAddedSongs');
-            var supportsImageAnalysis = appHost.supports('imageanalysis');
+
-            supportsImageAnalysis = false;
             elem.innerHTML = cardBuilder.getCardsHtml({
                 items: items,
                 showUnplayedIndicator: false,
@@ -51,10 +50,10 @@ define(['browser', 'layoutManager', 'userSettings', 'inputManager', 'loading', '
                 showTitle: true,
                 showParentTitle: true,
                 lazy: true,
-                centerText: !supportsImageAnalysis,
+                centerText: true,
-                overlayPlayButton: !supportsImageAnalysis,
+                overlayPlayButton: true,
                 allowBottomPadding: !enableScrollX(),
-                cardLayout: supportsImageAnalysis,
+                cardLayout: false,
                 coverImage: true
             });
             imageLoader.lazyChildren(elem);
@@ -90,8 +89,6 @@ define(['browser', 'layoutManager', 'userSettings', 'inputManager', 'loading', '
             }
 
             var itemsContainer = elem.querySelector('.itemsContainer');
-            var supportsImageAnalysis = appHost.supports('imageanalysis');
-            supportsImageAnalysis = false;
             itemsContainer.innerHTML = cardBuilder.getCardsHtml({
                 items: result.Items,
                 showUnplayedIndicator: false,
@@ -100,10 +97,10 @@ define(['browser', 'layoutManager', 'userSettings', 'inputManager', 'loading', '
                 showParentTitle: true,
                 action: 'instantmix',
                 lazy: true,
-                centerText: !supportsImageAnalysis,
+                centerText: true,
-                overlayMoreButton: !supportsImageAnalysis,
+                overlayMoreButton: true,
                 allowBottomPadding: !enableScrollX(),
-                cardLayout: supportsImageAnalysis,
+                cardLayout: false,
                 coverImage: true
             });
             imageLoader.lazyChildren(itemsContainer);
@@ -134,8 +131,6 @@ define(['browser', 'layoutManager', 'userSettings', 'inputManager', 'loading', '
             }
 
             var itemsContainer = elem.querySelector('.itemsContainer');
-            var supportsImageAnalysis = appHost.supports('imageanalysis');
-            supportsImageAnalysis = false;
             itemsContainer.innerHTML = cardBuilder.getCardsHtml({
                 items: result.Items,
                 showUnplayedIndicator: false,
@@ -144,10 +139,10 @@ define(['browser', 'layoutManager', 'userSettings', 'inputManager', 'loading', '
                 showParentTitle: true,
                 action: 'instantmix',
                 lazy: true,
-                centerText: !supportsImageAnalysis,
+                centerText: true,
-                overlayMoreButton: !supportsImageAnalysis,
+                overlayMoreButton: true,
                 allowBottomPadding: !enableScrollX(),
-                cardLayout: supportsImageAnalysis,
+                cardLayout: false,
                 coverImage: true
             });
             imageLoader.lazyChildren(itemsContainer);
@@ -339,8 +334,6 @@ define(['browser', 'layoutManager', 'userSettings', 'inputManager', 'loading', '
         function loadTab(page, index) {
             currentTabIndex = index;
             getTabController(page, index, function (controller) {
-                initialTabIndex = null;
-
                 if (renderedTabs.indexOf(index) == -1) {
                     renderedTabs.push(index);
                     controller.renderTab();
@@ -356,10 +349,8 @@ define(['browser', 'layoutManager', 'userSettings', 'inputManager', 'loading', '
             }
         }
 
-        var isViewRestored;
         var self = this;
         var currentTabIndex = parseInt(params.tab || getDefaultTabIndex(params.topParentId));
-        var initialTabIndex = currentTabIndex;
 
         self.initTab = function () {
             var tabContent = view.querySelector(".pageTabContent[data-index='0']");
@@ -377,7 +368,6 @@ define(['browser', 'layoutManager', 'userSettings', 'inputManager', 'loading', '
         var tabControllers = [];
         var renderedTabs = [];
         view.addEventListener('viewshow', function (e) {
-            isViewRestored = e.detail.isRestored;
             initTabs();
             if (!view.getAttribute('data-title')) {
                 var parentId = params.topParentId;

src/controllers/shows/tvgenres.js

@@ -85,8 +85,6 @@ import 'emby-button';
                 ParentId: params.topParentId
             };
             ApiClient.getItems(ApiClient.getCurrentUserId(), query).then(function (result) {
-                const supportsImageAnalysis = appHost.supports('imageanalysis');
-
                 if (viewStyle == 'Thumb') {
                     cardBuilder.buildCards(result.Items, {
                         itemsContainer: elem,

src/controllers/shows/tvlatest.js

@@ -1,7 +1,6 @@
 import loading from 'loading';
 import groupedcards from 'components/groupedcards';
 import cardBuilder from 'cardBuilder';
-import appHost from 'apphost';
 import imageLoader from 'imageLoader';
 
 /* eslint-disable indent */
@@ -23,8 +22,7 @@ import imageLoader from 'imageLoader';
 
     function loadLatest(context, params, promise) {
         promise.then(function (items) {
-            let html = '';
+            var html = '';
-            appHost.supports('imageanalysis');
             html += cardBuilder.getCardsHtml({
                 items: items,
                 shape: 'backdrop',

src/controllers/shows/tvrecommended.js

@@ -269,8 +269,6 @@ import 'emby-button';
         function loadTab(page, index) {
             currentTabIndex = index;
             getTabController(page, index, function (controller) {
-                initialTabIndex = null;
-
                 if (renderedTabs.indexOf(index) == -1) {
                     renderedTabs.push(index);
                     controller.renderTab();
@@ -301,10 +299,8 @@ import 'emby-button';
             }
         }
 
-        let isViewRestored;
         const self = this;
         let currentTabIndex = parseInt(params.tab || getDefaultTabIndex(params.topParentId));
-        let initialTabIndex = currentTabIndex;
 
         self.initTab = function () {
             const tabContent = self.tabContent;
@@ -319,7 +315,6 @@ import 'emby-button';
         let renderedTabs = [];
         setScrollClasses(view.querySelector('#resumableItems'), enableScrollX());
         view.addEventListener('viewshow', function (e) {
-            isViewRestored = e.detail.isRestored;
             initTabs();
             if (!view.getAttribute('data-title')) {
                 const parentId = params.topParentId;

src/controllers/shows/tvupcoming.js

@@ -1,9 +1,7 @@
 import layoutManager from 'layoutManager';
 import loading from 'loading';
 import datetime from 'datetime';
-import libraryBrowser from 'libraryBrowser';
 import cardBuilder from 'cardBuilder';
-import appHost from 'apphost';
 import imageLoader from 'imageLoader';
 import globalize from 'globalize';
 import 'scrollStyles';
@@ -106,8 +104,6 @@ import 'emby-itemscontainer';
                 html += '<div is="emby-itemscontainer" class="itemsContainer vertical-wrap padded-left padded-right">';
             }
 
-            let supportsImageAnalysis = appHost.supports('imageanalysis');
-            supportsImageAnalysis = false;
             html += cardBuilder.getCardsHtml({
                 items: group.items,
                 showLocationTypeIndicator: false,
@@ -116,11 +112,11 @@ import 'emby-itemscontainer';
                 preferThumb: true,
                 lazy: true,
                 showDetailsMenu: true,
-                centerText: !supportsImageAnalysis,
+                centerText: true,
                 showParentTitle: true,
                 overlayText: false,
                 allowBottomPadding: allowBottomPadding,
-                cardLayout: supportsImageAnalysis,
+                cardLayout: false,
                 overlayMoreButton: true,
                 missingIndicator: false
             });

src/controllers/user/home.js

@@ -1,7 +1,4 @@
 import HomescreenSettings from 'homescreenSettings';
-import dom from 'dom';
-import globalize from 'globalize';
-import loading from 'loading';
 import * as userSettings from 'userSettings';
 import autoFocuser from 'autoFocuser';
 import 'listViewStyle';

src/controllers/user/playback.js

@@ -1,7 +1,4 @@
 import PlaybackSettings from 'playbackSettings';
-import dom from 'dom';
-import globalize from 'globalize';
-import loading from 'loading';
 import * as userSettings from 'userSettings';
 import autoFocuser from 'autoFocuser';
 import 'listViewStyle';

src/elements/emby-collapse/emby-collapse.js

@@ -11,11 +11,7 @@ import 'emby-button';
         elem.classList.remove('hide');
         elem.classList.add('expanded');
         elem.style.height = 'auto';
-        const height = elem.offsetHeight + 'px';
+        var height = elem.offsetHeight + 'px';
-        elem.style.height = '0';
-
-        // trigger reflow
-        const newHeight = elem.offsetHeight;
         elem.style.height = height;
 
         setTimeout(function () {
@@ -28,15 +24,12 @@ import 'emby-button';
         }, 300);
 
         const icon = button.querySelector('.material-icons');
-        //icon.innerHTML = 'expand_less';
         icon.classList.add('emby-collapse-expandIconExpanded');
     }
 
     function slideUpToHide(button, elem) {
 
         elem.style.height = elem.offsetHeight + 'px';
-        // trigger reflow
-        const newHeight = elem.offsetHeight;
 
         elem.classList.remove('expanded');
         elem.style.height = '0';
@@ -50,7 +43,6 @@ import 'emby-button';
         }, 300);
 
         const icon = button.querySelector('.material-icons');
-        //icon.innerHTML = 'expand_more';
         icon.classList.remove('emby-collapse-expandIconExpanded');
     }
 

src/elements/emby-itemscontainer/emby-itemscontainer.js

@@ -18,7 +18,6 @@ import 'webcomponents';
 
     function onClick(e) {
         const itemsContainer = this;
-        const target = e.target;
         let multiSelect = itemsContainer.multiSelect;
 
         if (multiSelect) {

src/elements/emby-progressring/emby-progressring.js

@@ -13,23 +13,22 @@ import 'webcomponents';
         import('text!./emby-progressring.template.html').then(({default: template}) => {
             instance.innerHTML = template;
 
-            //if (window.MutationObserver) {
+            if (window.MutationObserver) {
-            //    // create an observer instance
+                // create an observer instance
-            //    var observer = new MutationObserver(function (mutations) {
+                var observer = new MutationObserver(function (mutations) {
-            //        mutations.forEach(function (mutation) {
+                    mutations.forEach(function (mutation) {
+                        instance.setProgress(parseFloat(instance.getAttribute('data-progress') || '0'));
+                    });
+                });
 
-            //            instance.setProgress(parseFloat(instance.getAttribute('data-progress') || '0'));
+                // configuration of the observer:
-            //        });
+                var config = { attributes: true, childList: false, characterData: false };
-            //    });
 
-            //    // configuration of the observer:
+                // pass in the target node, as well as the observer options
-            //    var config = { attributes: true, childList: false, characterData: false };
+                observer.observe(instance, config);
 
-            //    // pass in the target node, as well as the observer options
+                instance.observer = observer;
-            //    observer.observe(instance, config);
+            }
-
-            //    instance.observer = observer;
-            //}
 
             instance.setProgress(parseFloat(instance.getAttribute('data-progress') || '0'));
         });

src/elements/emby-radio/emby-radio.js

@@ -37,7 +37,6 @@ import 'webcomponents';
         this.classList.add('mdl-radio__button');
 
         let labelElement = this.parentNode;
-        //labelElement.classList.add('"mdl-radio mdl-js-radio mdl-js-ripple-effect');
         labelElement.classList.add('mdl-radio');
         labelElement.classList.add('mdl-js-radio');
         labelElement.classList.add('mdl-js-ripple-effect');

src/elements/emby-ratingbutton/emby-ratingbutton.js

@@ -78,7 +78,6 @@ import EmbyButtonPrototype from 'emby-button';
             if (icon) {
                 icon.classList.add('favorite');
                 icon.classList.remove('ratingbutton-icon-withrating');
-                //icon.innerHTML = 'thumb_up';
             }
             button.classList.remove('ratingbutton-withrating');
 
@@ -87,7 +86,6 @@ import EmbyButtonPrototype from 'emby-button';
             if (icon) {
                 icon.classList.add('favorite');
                 icon.classList.remove('ratingbutton-icon-withrating');
-                //icon.innerHTML = 'thumb_down';
             }
             button.classList.remove('ratingbutton-withrating');
 
@@ -96,7 +94,6 @@ import EmbyButtonPrototype from 'emby-button';
             if (icon) {
                 icon.classList.add('favorite');
                 icon.classList.remove('ratingbutton-icon-withrating');
-                //icon.innerHTML = 'thumbs_up_down';
             }
             button.classList.remove('ratingbutton-withrating');
         }

src/elements/emby-scrollbuttons/emby-scrollbuttons.js

@@ -36,6 +36,7 @@ const EmbyScrollButtonsPrototype = Object.create(HTMLDivElement.prototype);
     }
 
     function updateScrollButtons(scrollButtons, scrollSize, scrollPos, scrollWidth) {
+        // TODO: Check if hack is really needed
         // hack alert add twenty for rounding errors
         if (scrollWidth <= scrollSize + 20) {
             scrollButtons.scrollButtonsLeft.classList.add('hide');
@@ -122,7 +123,6 @@ const EmbyScrollButtonsPrototype = Object.create(HTMLDivElement.prototype);
         const direction = this.getAttribute('data-direction');
         const scrollSize = getScrollSize(scroller);
         const scrollPos = getScrollPosition(scroller);
-        const scrollWidth = getScrollWidth(scroller);
 
         let newPos;
         if (direction === 'left') {

src/elements/emby-slider/emby-slider.js

@@ -146,8 +146,9 @@ import 'emby-input';
             return;
         }
 
+        // TODO: Not sure what this is trying to accomplish.
         if (enableWidthWithTransform == null) {
-            //enableWidthWithTransform = browser.supportsCssAnimation();
+            enableWidthWithTransform = browser.supportsCssAnimation();
         }
 
         this.setAttribute('data-embyslider', 'true');

src/elements/emby-tabs/emby-tabs.js

@@ -29,13 +29,6 @@ import 'scrollStyles';
         }
     }
 
-    function addActivePanelClass(tabs, index) {
-        let tabPanel = getTabPanel(tabs, index);
-        if (tabPanel) {
-            tabPanel.classList.add('is-active');
-        }
-    }
-
     function fadeInRight(elem) {
 
         const pct = browser.mobile ? '4%' : '0.5%';
@@ -263,7 +256,6 @@ import 'scrollStyles';
             onClick.call(tabs, {
                 target: tabButtons[selected]
             });
-            //tabButtons[selected].click();
         }
     };
 
@@ -330,8 +322,6 @@ import 'scrollStyles';
     };
 
     EmbyTabs.setTabEnabled = function (index, enabled) {
-
-        const tabs = this;
         const btn = this.querySelector('.emby-tab-button[data-index="' + index + '"]');
 
         if (enabled) {

src/elements/emby-textarea/emby-textarea.js

@@ -47,7 +47,6 @@ import 'emby-input';
                 return;
             }
             let newHeight = 0;
-            let hasGrown = false;
 
             if ((textarea.scrollHeight - offset) > self.maxAllowedHeight) {
                 textarea.style.overflowY = 'scroll';

src/legacy/focusPreventScroll.js

@@ -1,3 +1,4 @@
+// TODO: Move to external library (https://github.com/calvellido/focus-options-polyfill)
 // Polyfill to add support for preventScroll by focus function
 
 if (HTMLElement.prototype.nativeFocus === undefined) {

src/libraries/scroller.js

@@ -872,12 +872,10 @@ define(['browser', 'layoutManager', 'dom', 'focusManager', 'ResizeObserver', 'sc
         if (item === undefined) {
             this.slideTo(this._pos[location], immediate);
         } else {
-
+            if (!transform) {
-            //if (!transform) {
+                item.scrollIntoView();
-
+                return;
-            //    item.scrollIntoView();
+            }
-            //    return;
-            //}
 
             var itemPos = this.getPos(item);
 

src/plugins/experimentalWarnings/plugin.js

@@ -1,14 +1,7 @@
 define(['connectionManager', 'globalize', 'userSettings', 'apphost'], function (connectionManager, globalize, userSettings, appHost) {
     'use strict';
 
-    function getRequirePromise(deps) {
+    // TODO: Replace with date-fns
-
-        return new Promise(function (resolve, reject) {
-
-            require(deps, resolve);
-        });
-    }
-
     // https://stackoverflow.com/questions/6117814/get-week-of-year-in-javascript-like-in-php
     function getWeek(date) {
         var d = new Date(Date.UTC(date.getFullYear(), date.getMonth(), date.getDate()));
@@ -26,6 +19,7 @@ define(['connectionManager', 'globalize', 'userSettings', 'apphost'], function (
 
         var now = new Date();
 
+        // TODO: Use date-fns
         userSettingsKey += now.getFullYear() + '-w' + getWeek(now);
 
         if (userSettings.get(userSettingsKey, false) === '1') {

src/plugins/htmlAudioPlayer/plugin.js

@@ -140,8 +140,6 @@ define(['events', 'browser', 'require', 'apphost', 'appSettings', 'htmlMediaHelp
                             xhrSetup: function(xhr, url) {
                                 xhr.withCredentials = true;
                             }
-                            //appendErrorMaxRetry: 6,
-                            //debug: true
                         });
                         hls.loadSource(val);
                         hls.attachMedia(elem);

src/plugins/htmlVideoPlayer/plugin.js

@@ -1,3 +1,4 @@
+
 define(['browser', 'require', 'events', 'apphost', 'loading', 'dom', 'playbackManager', 'appRouter', 'appSettings', 'connectionManager', 'htmlMediaHelper', 'itemHelper', 'screenfull', 'globalize'], function (browser, require, events, appHost, loading, dom, playbackManager, appRouter, appSettings, connectionManager, htmlMediaHelper, itemHelper, screenfull, globalize) {
     'use strict';
     /* globals cast */
@@ -17,25 +18,6 @@ define(['browser', 'require', 'events', 'apphost', 'loading', 'dom', 'playbackMa
         }
     }
 
-    var _supportsTextTracks;
-    function supportsTextTracks() {
-
-        if (_supportsTextTracks == null) {
-            _supportsTextTracks = document.createElement('video').textTracks != null;
-        }
-
-        // For now, until ready
-        return _supportsTextTracks;
-    }
-
-    function supportsCanvas() {
-        return !!document.createElement('canvas').getContext;
-    }
-
-    function supportsWebWorkers() {
-        return !!window.Worker;
-    }
-
     function enableNativeTrackSupport(currentSrc, track) {
 
         if (track) {
@@ -129,11 +111,6 @@ define(['browser', 'require', 'events', 'apphost', 'loading', 'dom', 'playbackMa
         return useHtml ? result.replace(/\n/gi, '<br>') : result;
     }
 
-    function setTracks(elem, tracks, item, mediaSource) {
-
-        elem.innerHTML = getTracksHtml(tracks, item, mediaSource);
-    }
-
     function getTextTrackUrl(track, item, format) {
 
         if (itemHelper.isLocalItem(item) && track.Path) {
@@ -148,22 +125,6 @@ define(['browser', 'require', 'events', 'apphost', 'loading', 'dom', 'playbackMa
         return url;
     }
 
-    function getTracksHtml(tracks, item, mediaSource) {
-        return tracks.map(function (t) {
-
-            if (t.DeliveryMethod !== 'External') {
-                return '';
-            }
-
-            var defaultAttribute = mediaSource.DefaultSubtitleStreamIndex === t.Index ? ' default' : '';
-
-            var language = t.Language || 'und';
-            var label = t.Language || 'und';
-            return '<track id="textTrack' + t.Index + '" label="' + label + '" kind="subtitles" src="' + getTextTrackUrl(t, item) + '" srclang="' + language + '"' + defaultAttribute + '></track>';
-
-        }).join('');
-    }
-
     function getDefaultProfile() {
 
         return new Promise(function (resolve, reject) {
@@ -191,12 +152,9 @@ define(['browser', 'require', 'events', 'apphost', 'loading', 'dom', 'playbackMa
 
         var videoDialog;
 
-        var winJsPlaybackItem;
-
         var subtitleTrackIndexToSetOnPlaying;
         var audioTrackIndexToSetOnPlaying;
 
-        var lastCustomTrackMs = 0;
         var currentClock;
         var currentSubtitlesOctopus;
         var currentAssRenderer;
@@ -334,8 +292,6 @@ define(['browser', 'require', 'events', 'apphost', 'loading', 'dom', 'playbackMa
                         xhrSetup: function(xhr, xhr_url) {
                             xhr.withCredentials = true;
                         }
-                        //appendErrorMaxRetry: 6,
-                        //debug: true
                     });
                     hls.loadSource(url);
                     hls.attachMedia(elem);
@@ -350,55 +306,6 @@ define(['browser', 'require', 'events', 'apphost', 'loading', 'dom', 'playbackMa
             });
         }
 
-        function onShakaError(event) {
-
-            var error = event.detail;
-            console.error('Error code', error.code, 'object', error);
-        }
-
-        function setSrcWithShakaPlayer(instance, elem, options, url) {
-
-            return new Promise(function (resolve, reject) {
-
-                require(['shaka'], function () {
-                    /* globals shaka */
-
-                    var player = new shaka.Player(elem);
-
-                    //player.configure({
-                    //    abr: {
-                    //        enabled: false
-                    //    },
-                    //    streaming: {
-
-                    //        failureCallback: function () {
-                    //            alert(2);
-                    //        }
-                    //    }
-                    //});
-
-                    //shaka.log.setLevel(6);
-
-                    // Listen for error events.
-                    player.addEventListener('error', onShakaError);
-
-                    // Try to load a manifest.
-                    // This is an asynchronous process.
-                    player.load(url).then(function () {
-
-                        // This runs if the asynchronous load is successful.
-                        resolve();
-
-                    }, reject);
-
-                    self._shakaPlayer = player;
-
-                    // This is needed in setCurrentTrackElement
-                    self._currentSrc = url;
-                });
-            });
-        }
-
         function setCurrentSrcChromecast(instance, elem, options, url) {
 
             elem.autoplay = true;
@@ -441,7 +348,6 @@ define(['browser', 'require', 'events', 'apphost', 'loading', 'dom', 'playbackMa
             var media = event.data.media || {};
             var url = media.contentId;
             var contentType = media.contentType.toLowerCase();
-            var options = media.customData;
 
             var protocol;
             var ext = 'm3u8';
@@ -486,12 +392,6 @@ define(['browser', 'require', 'events', 'apphost', 'loading', 'dom', 'playbackMa
             mediaManager.defaultOnLoad = mediaManager.onLoad.bind(mediaManager);
             mediaManager.onLoad = onMediaManagerLoadMedia.bind(self);
 
-            //mediaManager.defaultOnPlay = mediaManager.onPlay.bind(mediaManager);
-            //mediaManager.onPlay = function (event) {
-            //    // TODO ???
-            //    mediaManager.defaultOnPlay(event);
-            //};
-
             mediaManager.defaultOnStop = mediaManager.onStop.bind(mediaManager);
             mediaManager.onStop = function (event) {
                 playbackManager.stop();
@@ -516,8 +416,6 @@ define(['browser', 'require', 'events', 'apphost', 'loading', 'dom', 'playbackMa
             htmlMediaHelper.destroyFlvPlayer(self);
             htmlMediaHelper.destroyCastPlayer(self);
 
-            var tracks = getMediaStreamTextTracks(options.mediaSource);
-
             subtitleTrackIndexToSetOnPlaying = options.mediaSource.DefaultSubtitleStreamIndex == null ? -1 : options.mediaSource.DefaultSubtitleStreamIndex;
             if (subtitleTrackIndexToSetOnPlaying != null && subtitleTrackIndexToSetOnPlaying >= 0) {
                 var initialSubtitleStream = options.mediaSource.MediaStreams[subtitleTrackIndexToSetOnPlaying];
@@ -535,14 +433,7 @@ define(['browser', 'require', 'events', 'apphost', 'loading', 'dom', 'playbackMa
                 elem.crossOrigin = crossOrigin;
             }
 
-            /*if (htmlMediaHelper.enableHlsShakaPlayer(options.item, options.mediaSource, 'Video') && val.indexOf('.m3u8') !== -1) {
+            if (browser.chromecast && val.indexOf('.m3u8') !== -1 && options.mediaSource.RunTimeTicks) {
-
-                setTracks(elem, tracks, options.item, options.mediaSource);
-
-                return setSrcWithShakaPlayer(self, elem, options, val);
-
-            } else*/ if (browser.chromecast && val.indexOf('.m3u8') !== -1 && options.mediaSource.RunTimeTicks) {
-
                 return setCurrentSrcChromecast(self, elem, options, val);
             } else if (htmlMediaHelper.enableHlsJsPlayer(options.mediaSource.RunTimeTicks, 'Video') && val.indexOf('.m3u8') !== -1) {
                 return setSrcWithHlsJs(self, elem, options, val);
@@ -1062,7 +953,6 @@ define(['browser', 'require', 'events', 'apphost', 'loading', 'dom', 'playbackMa
             destroyCustomTrack(videoElement);
             customTrackIndex = track.Index;
             renderTracksEvents(videoElement, track, item);
-            lastCustomTrackMs = 0;
         }
 
         function renderSsaAss(videoElement, track, item) {

src/plugins/logoScreensaver/plugin.js

@@ -59,23 +59,6 @@ define(['pluginManager'], function (pluginManager) {
             return elem.animate(keyframes, timing);
         }
 
-        function shake(elem, iterations) {
-            var keyframes = [
-                { transform: 'translate3d(0, 0, 0)', offset: 0 },
-                { transform: 'translate3d(-10px, 0, 0)', offset: 0.1 },
-                { transform: 'translate3d(10px, 0, 0)', offset: 0.2 },
-                { transform: 'translate3d(-10px, 0, 0)', offset: 0.3 },
-                { transform: 'translate3d(10px, 0, 0)', offset: 0.4 },
-                { transform: 'translate3d(-10px, 0, 0)', offset: 0.5 },
-                { transform: 'translate3d(10px, 0, 0)', offset: 0.6 },
-                { transform: 'translate3d(-10px, 0, 0)', offset: 0.7 },
-                { transform: 'translate3d(10px, 0, 0)', offset: 0.8 },
-                { transform: 'translate3d(-10px, 0, 0)', offset: 0.9 },
-                { transform: 'translate3d(0, 0, 0)', offset: 1 }];
-            var timing = { duration: 900, iterations: iterations };
-            return elem.animate(keyframes, timing);
-        }
-
         function swing(elem, iterations) {
             var keyframes = [
                 { transform: 'translate(0%)', offset: 0 },
@@ -118,7 +101,6 @@ define(['pluginManager'], function (pluginManager) {
         }
 
         function rotateIn(elem, iterations) {
-            var transformOrigin = elem.style['transform-origin'];
             var keyframes = [{ transform: 'rotate3d(0, 0, 1, -200deg)', opacity: '0', transformOrigin: 'center', offset: 0 },
                 { transform: 'none', opacity: '1', transformOrigin: 'center', offset: 1 }];
             var timing = { duration: 900, iterations: iterations };
@@ -126,7 +108,6 @@ define(['pluginManager'], function (pluginManager) {
         }
 
         function rotateOut(elem, iterations) {
-            var transformOrigin = elem.style['transform-origin'];
             var keyframes = [{ transform: 'none', opacity: '1', transformOrigin: 'center', offset: 0 },
                 { transform: 'rotate3d(0, 0, 1, 200deg)', opacity: '0', transformOrigin: 'center', offset: 1 }];
             var timing = { duration: 900, iterations: iterations };

src/scripts/browser.js

@@ -101,8 +101,6 @@ define([], function () {
         }
 
         var animation = false;
-        var animationstring = 'animation';
-        var keyframeprefix = '';
         var domPrefixes = ['Webkit', 'O', 'Moz'];
         var pfx = '';
         var elm = document.createElement('div');
@@ -115,8 +113,6 @@ define([], function () {
             for (var i = 0; i < domPrefixes.length; i++) {
                 if (elm.style[domPrefixes[i] + 'AnimationName'] !== undefined) {
                     pfx = domPrefixes[i];
-                    animationstring = pfx + 'Animation';
-                    keyframeprefix = '-' + pfx.toLowerCase() + '-';
                     animation = true;
                     break;
                 }

src/scripts/imagehelper.js

@@ -1,6 +1,5 @@
-/* eslint-disable indent */
 
-import browser from 'browser';
+/* eslint-disable indent */
 
     export function getDeviceIcon(device) {
         var baseUrl = 'assets/img/devices/';

src/scripts/libraryMenu.js

@@ -229,7 +229,6 @@ define(['dom', 'layoutManager', 'inputManager', 'connectionManager', 'events', '
 
     function openMainDrawer() {
         navDrawerInstance.open();
-        lastOpenTime = new Date().getTime();
     }
 
     function onMainDrawerOpened() {
@@ -575,15 +574,12 @@ define(['dom', 'layoutManager', 'inputManager', 'connectionManager', 'events', '
     }
 
     function updateLibraryMenu(user) {
-        // FIXME: Potential equivalent might be
-        // showBySelector(".lnkSyncToOtherDevices", !!user.Policy.EnableContentDownloading);
         if (!user) {
             showBySelector('.libraryMenuDownloads', false);
             showBySelector('.lnkSyncToOtherDevices', false);
             return void showBySelector('.userMenuOptions', false);
         }
 
-        // FIXME: Potentially the same as above
         if (user.Policy.EnableContentDownloading) {
             showBySelector('.lnkSyncToOtherDevices', true);
         } else {
@@ -838,7 +834,6 @@ define(['dom', 'layoutManager', 'inputManager', 'connectionManager', 'events', '
     var enableLibraryNavDrawerHome = !layoutManager.tv;
     var skinHeader = document.querySelector('.skinHeader');
     var requiresUserRefresh = true;
-    var lastOpenTime = new Date().getTime();
     window.LibraryMenu = {
         getTopParentId: getTopParentId,
         onHardwareMenuButtonClick: function () {

src/scripts/livetvcomponents.js

@@ -64,10 +64,7 @@ define(['layoutManager', 'datetime', 'cardBuilder', 'apphost'], function (layout
 
         for (i = 0, length = groups.length; i < length; i++) {
             var group = groups[i];
-            var supportsImageAnalysis = appHost.supports('imageanalysis');
-            var cardLayout = appHost.preferVisualCards || supportsImageAnalysis;
 
-            cardLayout = true;
             if (group.name) {
                 html += '<div class="verticalSection">';
                 html += '<h2 class="sectionTitle sectionTitle-cards padded-left">' + group.name + '</h2>';
@@ -86,21 +83,21 @@ define(['layoutManager', 'datetime', 'cardBuilder', 'apphost'], function (layout
 
             html += cardBuilder.getCardsHtml({
                 items: group.items,
-                shape: cardLayout ? getBackdropShape() : enableScrollX() ? 'autoOverflow' : 'autoVertical',
+                shape: getBackdropShape(),
                 showParentTitleOrTitle: true,
                 showAirTime: true,
                 showAirEndTime: true,
-                showChannelName: !cardLayout,
+                showChannelName: false,
-                cardLayout: cardLayout,
+                cardLayout: true,
-                centerText: !cardLayout,
+                centerText: false,
                 action: 'edit',
                 cardFooterAside: 'none',
-                preferThumb: !!cardLayout || 'auto',
+                preferThumb: true,
-                defaultShape: cardLayout ? null : 'portrait',
+                defaultShape: null,
                 coverImage: true,
                 allowBottomPadding: false,
                 overlayText: false,
-                showChannelLogo: cardLayout
+                showChannelLogo: true
             });
             html += '</div>';
 

src/scripts/site.js

@@ -14,7 +14,7 @@ function getWindowLocationSearch(win) {
     return search || '';
 }
 
-function getParameterByName(name, url) {
+window.getParameterByName = function (name, url) {
     'use strict';
 
     name = name.replace(/[\[]/, '\\[').replace(/[\]]/, '\\]');
@@ -27,7 +27,7 @@ function getParameterByName(name, url) {
     }
 
     return decodeURIComponent(results[1].replace(/\+/g, ' '));
-}
+};
 
 function pageClassOn(eventName, className, fn) {
     'use strict';
@@ -41,7 +41,7 @@ function pageClassOn(eventName, className, fn) {
     });
 }
 
-function pageIdOn(eventName, id, fn) {
+window.pageIdOn = function(eventName, id, fn) {
     'use strict';
 
     document.addEventListener(eventName, function (event) {
@@ -51,7 +51,7 @@ function pageIdOn(eventName, id, fn) {
             fn.call(target, event);
         }
     });
-}
+};
 
 var Dashboard = {
     getCurrentUser: function () {
@@ -236,9 +236,7 @@ var Dashboard = {
 
 var AppInfo = {};
 
-!function () {
+function initClient() {
-    'use strict';
-
     function defineConnectionManager(connectionManager) {
         window.ConnectionManager = connectionManager;
         define('connectionManager', [], function () {
@@ -1127,7 +1125,9 @@ var AppInfo = {};
     })();
 
     return onWebComponentsReady();
-}();
+}
+
+initClient();
 
 pageClassOn('viewshow', 'standalonePage', function () {
     document.querySelector('.skinHeader').classList.add('noHeaderRight');

src/strings/ar.json

@@ -227,7 +227,6 @@
     "HeaderPassword": "كلمة السر",
     "HeaderPasswordReset": "إعادة تهيئة كلمة السر",
     "HeaderPaths": "مسارات",
-    "HeaderPendingInvitations": "الدعوات المعلقة",
     "HeaderPeople": "الناس",
     "HeaderPinCodeReset": "أعد تهيئة الرمز الشخصي",
     "HeaderPlayAll": "تشغيل الكل",

src/strings/bg-bg.json

@@ -224,7 +224,6 @@
     "HeaderParentalRatings": "Родителска оценка",
     "HeaderPassword": "Парола",
     "HeaderPaths": "Пътища",
-    "HeaderPendingInvitations": "Чакащи покани",
     "HeaderPeople": "Хора",
     "HeaderPlayAll": "Пускане на всичко",
     "HeaderPlayOn": "Пускане на",

src/strings/ca.json

@@ -212,7 +212,6 @@
     "HeaderPassword": "Contrasenya",
     "HeaderPasswordReset": "Reiniciar Contrasenya",
     "HeaderPaths": "Directoris",
-    "HeaderPendingInvitations": "Invitacions Pendents",
     "HeaderPeople": "Gent",
     "HeaderPlayAll": "Reprodueix Tot",
     "HeaderPlaybackError": "Error de Reproducció",

src/strings/cs.json

@@ -341,7 +341,6 @@
     "HeaderPassword": "Heslo",
     "HeaderPasswordReset": "Obnova hesla",
     "HeaderPaths": "Cesty",
-    "HeaderPendingInvitations": "Čekající pozvánky",
     "HeaderPeople": "Lidé",
     "HeaderPinCodeReset": "Obnovit Pin kód",
     "HeaderPlayAll": "Přehrát vše",

src/strings/da.json

@@ -296,7 +296,6 @@
     "HeaderPassword": "Adgangskode",
     "HeaderPasswordReset": "Nulstil adgangskode",
     "HeaderPaths": "Stier",
-    "HeaderPendingInvitations": "Ventende invitationer",
     "HeaderPeople": "Mennesker",
     "HeaderPinCodeReset": "Nulstil pinkode",
     "HeaderPlayAll": "Afspil Alle",

src/strings/de.json

@@ -381,7 +381,6 @@
     "HeaderPassword": "Passwort",
     "HeaderPasswordReset": "Passwort zurücksetzen",
     "HeaderPaths": "Pfade",
-    "HeaderPendingInvitations": "Ausstehende Einladungen",
     "HeaderPeople": "Personen",
     "HeaderPhotoAlbums": "Fotoalben",
     "HeaderPinCodeReset": "PIN Code zurücksetzen",

src/strings/el.json

@@ -350,7 +350,6 @@
     "HeaderPassword": "Κωδικός",
     "HeaderPasswordReset": "Επαναφορά του κωδικού πρόσβασης",
     "HeaderPaths": "Διαδρομή",
-    "HeaderPendingInvitations": "Εκκρεμείς προσκλήσεις",
     "HeaderPhotoAlbums": "Άλμπουμ φωτογραφιών",
     "HeaderPinCodeReset": "Επαναφορά Pin Code",
     "HeaderPlayAll": "Αναπαραγωγή Όλων",

src/strings/en-gb.json

@@ -446,7 +446,6 @@
     "HeaderPassword": "Password",
     "HeaderPasswordReset": "Password Reset",
     "HeaderPaths": "Paths",
-    "HeaderPendingInvitations": "Pending Invitations",
     "CopyStreamURL": "Copy Stream URL",
     "CopyStreamURLSuccess": "URL copied successfully.",
     "XmlDocumentAttributeListHelp": "These attributes are applied to the root element of every XML response.",

src/strings/en-us.json

@@ -438,7 +438,6 @@
     "HeaderPassword": "Password",
     "HeaderPasswordReset": "Password Reset",
     "HeaderPaths": "Paths",
-    "HeaderPendingInvitations": "Pending Invitations",
     "HeaderPeople": "People",
     "HeaderPhotoAlbums": "Photo Albums",
     "HeaderPinCodeReset": "Reset Pin Code",

src/strings/es-ar.json

@@ -534,7 +534,6 @@
     "HeaderPinCodeReset": "Restablecer código PIN",
     "HeaderPhotoAlbums": "Álbumes de fotos",
     "HeaderPeople": "Personas",
-    "HeaderPendingInvitations": "Invitaciones pendientes",
     "HeaderPaths": "Rutas",
     "HeaderPasswordReset": "Restablecer contraseña",
     "HeaderPassword": "Contraseña",

src/strings/es-mx.json

@@ -392,7 +392,6 @@
     "HeaderPassword": "Contraseña",
     "HeaderPasswordReset": "Restablecer contraseña",
     "HeaderPaths": "Rutas",
-    "HeaderPendingInvitations": "Invitaciones pendientes",
     "HeaderPeople": "Personas",
     "HeaderPhotoAlbums": "Álbumes de fotos",
     "HeaderPinCodeReset": "Restablecer código PIN",

src/strings/es.json

@@ -340,7 +340,6 @@
     "HeaderPassword": "Contraseña",
     "HeaderPasswordReset": "Reestablecer contraseña",
     "HeaderPaths": "Ruta",
-    "HeaderPendingInvitations": "Invitaciones pendientes",
     "HeaderPeople": "Gente",
     "HeaderPinCodeReset": "Restablecer código PIN",
     "HeaderPlayAll": "Reproducir todo",

src/strings/es_419.json

@@ -1096,7 +1096,6 @@
     "HeaderPinCodeReset": "Restablecer código PIN",
     "HeaderPhotoAlbums": "Álbumes de fotos",
     "HeaderPeople": "Personas",
-    "HeaderPendingInvitations": "Invitaciones pendientes",
     "HeaderPaths": "Rutas",
     "HeaderPasswordReset": "Restablecer contraseña",
     "HeaderPassword": "Contraseña",

src/strings/fa.json

@@ -329,7 +329,6 @@
     "HeaderPinCodeReset": "بازنشانی پین کد",
     "HeaderPhotoAlbums": "آلبوم‌های عکس",
     "HeaderPeople": "افراد",
-    "HeaderPendingInvitations": "دعوت‌های در انتظار",
     "HeaderPasswordReset": "بازنشانی گذرواژه",
     "HeaderPassword": "گذرواژه",
     "HeaderParentalRatings": "رتبه بندی والدین",

src/strings/fi.json

@@ -480,7 +480,6 @@
     "HeaderPreferredMetadataLanguage": "Ensisijainen metadatan kieli",
     "HeaderPinCodeReset": "Nollaa PIN-koodi",
     "HeaderPhotoAlbums": "Kuva-albumit",
-    "HeaderPendingInvitations": "Odottavat kutsut",
     "HeaderPaths": "Polut",
     "HeaderPasswordReset": "Salasanan nollaus",
     "HeaderNextVideoPlayingInValue": "Seuraava video alkaa {0}",

src/strings/fr.json

@@ -387,7 +387,6 @@
     "HeaderPassword": "Mot de passe",
     "HeaderPasswordReset": "Mot de passe réinitialisé",
     "HeaderPaths": "Chemins",
-    "HeaderPendingInvitations": "Invitations en attente",
     "HeaderPeople": "Personnes",
     "HeaderPhotoAlbums": "Albums photo",
     "HeaderPinCodeReset": "Réinitialiser le code PIN",

src/strings/he.json

@@ -616,7 +616,6 @@
     "HeaderPinCodeReset": "איפוס קוד סיכה",
     "HeaderPhotoAlbums": "אלבומי תמונות",
     "HeaderPeople": "אנשים",
-    "HeaderPendingInvitations": "הזמנות ממתינות",
     "HeaderPasswordReset": "איפוס סיסמה",
     "HeaderPassword": "סיסמה",
     "HeaderOtherItems": "פריטים אחרים",

src/strings/hr.json

@@ -256,7 +256,6 @@
     "HeaderPassword": "Lozinka",
     "HeaderPasswordReset": "Poništenje lozinke",
     "HeaderPaths": "Putanje",
-    "HeaderPendingInvitations": "Neriješeni pozivi",
     "HeaderPinCodeReset": "Poništi PIN",
     "HeaderPlayback": "Reprodukcija medija",
     "HeaderPleaseSignIn": "Molim, prijavite se",

src/strings/hu.json

@@ -762,7 +762,6 @@
     "HeaderNextVideoPlayingInValue": "Következő videó lejátszása {0}",
     "HeaderOtherItems": "Egyéb elemek",
     "HeaderPasswordReset": "Jelszó visszaállítása",
-    "HeaderPendingInvitations": "Függő meghívók",
     "HeaderPhotoAlbums": "Fényképalbumok",
     "HeaderPlaybackError": "Lejátszási hiba",
     "HeaderProfileInformation": "Profil információ",

src/strings/it.json

@@ -371,7 +371,6 @@
     "HeaderParentalRatings": "Valutazioni genitori",
     "HeaderPasswordReset": "Reset della Password",
     "HeaderPaths": "Percorsi",
-    "HeaderPendingInvitations": "Inviti in sospeso",
     "HeaderPeople": "Persone",
     "HeaderPhotoAlbums": "Album foto",
     "HeaderPinCodeReset": "Resetta il codice PIN",

src/strings/ja.json

@@ -412,7 +412,6 @@
     "HeaderPassword": "パスワード",
     "HeaderPasswordReset": "パスワードリセット",
     "HeaderPaths": "パス",
-    "HeaderPendingInvitations": "保留中の招待状",
     "HeaderPeople": "人",
     "HeaderPhotoAlbums": "フォトアルバム",
     "HeaderPinCodeReset": "PINコードのリセット",

src/strings/kk.json

@@ -409,7 +409,6 @@
     "HeaderPassword": "Paról",
     "HeaderPasswordReset": "Paróldi ysyrý",
     "HeaderPaths": "Joldar",
-    "HeaderPendingInvitations": "Bógelis shaqyrýlar",
     "HeaderPeople": "Adamdar",
     "HeaderPhotoAlbums": "Fotoálbomdar",
     "HeaderPinCodeReset": "PIN-kodty ysyrý",

src/strings/ko.json

@@ -195,7 +195,6 @@
     "HeaderPassword": "비밀번호",
     "HeaderPasswordReset": "비밀번호 재설정",
     "HeaderPaths": "경로",
-    "HeaderPendingInvitations": "초대 보류",
     "HeaderPinCodeReset": "PIN 코드 초기화",
     "HeaderPlayAll": "모두 재생",
     "HeaderPlayback": "미디어 재생",

src/strings/lt-lt.json

@@ -985,7 +985,6 @@
     "HeaderOnNow": "Gyvai dabar",
     "HeaderOtherItems": "Kiti elementai",
     "HeaderParentalRatings": "Amžiaus kategorijos",
-    "HeaderPendingInvitations": "Laukiantys kvietimai",
     "HeaderPeople": "Žmonės",
     "HeaderPhotoAlbums": "Nuotraukų albumai",
     "HeaderPinCodeReset": "Nustatyti PIN kodą iš naujo",

src/strings/lv.json

@@ -1112,7 +1112,6 @@
     "LabelAirsBeforeEpisode": "Tiešraidē pirms epizodes:",
     "LabelAirsAfterSeason": "Tiešraidē pēc sezonas:",
     "HeaderSubtitleProfilesHelp": "Subtitru profili apraksta ierīces atbalstītos subtitru formātus.",
-    "HeaderPendingInvitations": "Gaidošie Uzaicinājumi",
     "HeaderKeepSeries": "Paturēt Sēriju",
     "HeaderFavoritePlaylists": "Atskaņošanas Sarakstu Favorīti",
     "ApiKeysCaption": "Saraksts ar pašlaik iespējotajām API atslēgām",

src/strings/nb.json

@@ -304,7 +304,6 @@
     "HeaderPassword": "Passord",
     "HeaderPasswordReset": "Tilbakestill passord",
     "HeaderPaths": "Filbaner",
-    "HeaderPendingInvitations": "Ventende invitasjoner",
     "HeaderPeople": "Personer",
     "HeaderPinCodeReset": "Tilbakestill PIN-kode",
     "HeaderPlayAll": "Spill alle",

src/strings/nl.json

@@ -372,7 +372,6 @@
     "HeaderPassword": "Wachtwoord",
     "HeaderPasswordReset": "Wachtwoord resetten",
     "HeaderPaths": "Paden",
-    "HeaderPendingInvitations": "Uitstaande uitnodigingen",
     "HeaderPeople": "Personen",
     "HeaderPhotoAlbums": "Foto-albums",
     "HeaderPinCodeReset": "Reset Pincode",