mirrors/jellyfin-web
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00
Code Activity

Apply suggestions from code review

Browse source 
Co-Authored-By: Vasily <JustAMan@users.noreply.github.com>
This commit is contained in:
Dmitry Lyzo 2019-11-13 00:19:00 +03:00 • committed by GitHub
parent 3896c18e26
commit e090b78d66
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/components/emby-slider/emby-slider.js
View file

@ -202,11 +202,9 @@ define(['browser', 'dom', 'layoutManager', 'css!./emby-slider', 'registerElement
* @param {Object} elem slider itself * @param {Object} elem slider itself
*/ */
function startKeyboardDragging(elem) { function startKeyboardDragging(elem) {
elem.keyboardDragging = true; elem.keyboardDragging = true;
clearTimeout(keyboardDraggingTimer); clearTimeout(keyboardDraggingTimer);
keyboardDraggingTimer = setTimeout(function () { keyboardDraggingTimer = setTimeout(function () {
finishKeyboardDragging(elem); finishKeyboardDragging(elem);
}, KeyboardDraggingTimeout); }, KeyboardDraggingTimeout);
@ -218,7 +216,6 @@ define(['browser', 'dom', 'layoutManager', 'css!./emby-slider', 'registerElement
* @param {Object} elem slider itself * @param {Object} elem slider itself
*/ */
function finishKeyboardDragging(elem) { function finishKeyboardDragging(elem) {
clearTimeout(keyboardDraggingTimer); clearTimeout(keyboardDraggingTimer);
keyboardDraggingTimer = undefined; keyboardDraggingTimer = undefined;
@ -238,7 +235,6 @@ define(['browser', 'dom', 'layoutManager', 'css!./emby-slider', 'registerElement
* @param {number} delta step amount * @param {number} delta step amount
*/ */
function stepKeyboard(elem, delta) { function stepKeyboard(elem, delta) {
startKeyboardDragging(elem); startKeyboardDragging(elem);
elem.value = Math.max(elem.min, Math.min(elem.max, parseFloat(elem.value) + delta)); elem.value = Math.max(elem.min, Math.min(elem.max, parseFloat(elem.value) + delta));
@ -261,14 +257,14 @@ define(['browser', 'dom', 'layoutManager', 'css!./emby-slider', 'registerElement
stepKeyboard(this, -this.keyboardStepDown || -1); stepKeyboard(this, -this.keyboardStepDown || -1);
e.preventDefault(); e.preventDefault();
e.stopPropagation(); e.stopPropagation();
break; break;
case 'ArrowRight': case 'ArrowRight':
case 'Right': case 'Right':
stepKeyboard(this, this.keyboardStepUp || 1); stepKeyboard(this, this.keyboardStepUp || 1);
e.preventDefault(); e.preventDefault();
e.stopPropagation(); e.stopPropagation();
break; break;
} }
} }
@ -276,7 +272,6 @@ define(['browser', 'dom', 'layoutManager', 'css!./emby-slider', 'registerElement
* Enable keyboard dragging. * Enable keyboard dragging.
*/ */
EmbySliderPrototype.enableKeyboardDragging = function () { EmbySliderPrototype.enableKeyboardDragging = function () {
if (!this.keyboardDraggingEnabled) { if (!this.keyboardDraggingEnabled) {
this.addEventListener('keydown', onKeyDown); this.addEventListener('keydown', onKeyDown);
this.keyboardDraggingEnabled = true; this.keyboardDraggingEnabled = true;
@ -290,7 +285,6 @@ define(['browser', 'dom', 'layoutManager', 'css!./emby-slider', 'registerElement
* @param {number} stepUp step to increase * @param {number} stepUp step to increase
*/ */
EmbySliderPrototype.setKeyboardSteps = function (stepDown, stepUp) { EmbySliderPrototype.setKeyboardSteps = function (stepDown, stepUp) {
this.keyboardStepDown = stepDown || stepUp || 1; this.keyboardStepDown = stepDown || stepUp || 1;
this.keyboardStepUp = stepUp || stepDown || 1; this.keyboardStepUp = stepUp || stepDown || 1;
} }