From 3b6fa7e97201a5121975e6280013455e79f26edc Mon Sep 17 00:00:00 2001
From: dkanada <dkanada@users.noreply.github.com>
Date: Sun, 24 May 2020 18:30:35 +0900
Subject: [PATCH 1/4] add display preference for details banner and update some
 defaults

---
 src/components/displaySettings/displaySettings.js   |  2 ++
 .../displaySettings/displaySettings.template.html   |  8 ++++++++
 src/controllers/itemDetails.js                      |  2 +-
 src/scripts/settings/userSettings.js                | 13 +++++++++++--
 src/strings/en-gb.json                              |  2 +-
 src/strings/en-us.json                              |  8 +++++---
 6 files changed, 28 insertions(+), 7 deletions(-)

diff --git a/src/components/displaySettings/displaySettings.js b/src/components/displaySettings/displaySettings.js
index b6938bc95d..4e068960a3 100644
--- a/src/components/displaySettings/displaySettings.js
+++ b/src/components/displaySettings/displaySettings.js
@@ -182,6 +182,7 @@ define(['require', 'browser', 'layoutManager', 'appSettings', 'pluginManager', '
         context.querySelector('#chkThemeVideo').checked = userSettings.enableThemeVideos();
         context.querySelector('#chkFadein').checked = userSettings.enableFastFadein();
         context.querySelector('#chkBackdrops').checked = userSettings.enableBackdrops();
+        context.querySelector('#chkDetailsBanner').checked = userSettings.detailsBanner();
 
         context.querySelector('#selectLanguage').value = userSettings.language() || '';
         context.querySelector('.selectDateTimeLocale').value = userSettings.dateTimeLocale() || '';
@@ -223,6 +224,7 @@ define(['require', 'browser', 'layoutManager', 'appSettings', 'pluginManager', '
 
         userSettingsInstance.enableFastFadein(context.querySelector('#chkFadein').checked);
         userSettingsInstance.enableBackdrops(context.querySelector('#chkBackdrops').checked);
+        userSettingsInstance.detailsBanner(context.querySelector('#chkDetailsBanner').checked);
 
         if (user.Id === apiClient.getCurrentUserId()) {
             skinManager.setTheme(userSettingsInstance.theme());
diff --git a/src/components/displaySettings/displaySettings.template.html b/src/components/displaySettings/displaySettings.template.html
index b8ab1a9ba5..d37c24b49d 100644
--- a/src/components/displaySettings/displaySettings.template.html
+++ b/src/components/displaySettings/displaySettings.template.html
@@ -156,6 +156,14 @@
         <div class="fieldDescription checkboxFieldDescription">${EnableFastImageFadeInHelp}</div>
     </div>
 
+    <div class="checkboxContainer checkboxContainer-withDescription fldDetailsBanner">
+        <label>
+            <input type="checkbox" is="emby-checkbox" id="chkDetailsBanner" />
+            <span>${EnableDetailsBanner}</span>
+        </label>
+        <div class="fieldDescription checkboxFieldDescription">${EnableDetailsBannerHelp}</div>
+    </div>
+
     <div class="checkboxContainer checkboxContainer-withDescription fldBackdrops hide">
         <label>
             <input type="checkbox" is="emby-checkbox" id="chkBackdrops" />
diff --git a/src/controllers/itemDetails.js b/src/controllers/itemDetails.js
index d9eab0ac4d..0fad1ba967 100644
--- a/src/controllers/itemDetails.js
+++ b/src/controllers/itemDetails.js
@@ -475,7 +475,7 @@ define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSetti
             item.Type === 'MusicAlbum' ||
             item.Type === 'Person';
 
-        if (!layoutManager.mobile && !userSettings.enableBackdrops()) {
+        if (!layoutManager.mobile && !userSettings.detailsBanner()) {
             return false;
         }
 
diff --git a/src/scripts/settings/userSettings.js b/src/scripts/settings/userSettings.js
index f922621526..819b7867ca 100644
--- a/src/scripts/settings/userSettings.js
+++ b/src/scripts/settings/userSettings.js
@@ -107,7 +107,7 @@ import events from 'events';
         }
 
         val = this.get('enableThemeSongs', false);
-        return val !== 'false';
+        return val === 'true';
     }
 
     export function enableThemeVideos(val) {
@@ -116,7 +116,7 @@ import events from 'events';
         }
 
         val = this.get('enableThemeVideos', false);
-        return val !== 'false';
+        return val === 'true';
     }
 
     export function enableFastFadein(val) {
@@ -134,6 +134,15 @@ import events from 'events';
         }
 
         val = this.get('enableBackdrops', false);
+        return val === 'true';
+    }
+
+    export function detailsBanner(val) {
+        if (val !== undefined) {
+            return this.set('detailsBanner', val.toString(), false);
+        }
+
+        val = this.get('detailsBanner', false);
         return val !== 'false';
     }
 
diff --git a/src/strings/en-gb.json b/src/strings/en-gb.json
index b111dfa24a..15892056f7 100644
--- a/src/strings/en-gb.json
+++ b/src/strings/en-gb.json
@@ -572,7 +572,7 @@
     "Repeat": "Repeat",
     "RemoveFromPlaylist": "Remove from playlist",
     "RemoveFromCollection": "Remove from collection",
-    "RememberMe": "Remember me",
+    "RememberMe": "Remember Me",
     "ReleaseDate": "Release date",
     "RefreshMetadata": "Refresh metadata",
     "RefreshDialogHelp": "Metadata is refreshed based on settings and internet services that are enabled in the Jellyfin Server dashboard.",
diff --git a/src/strings/en-us.json b/src/strings/en-us.json
index 676d825612..c9a8ff8909 100644
--- a/src/strings/en-us.json
+++ b/src/strings/en-us.json
@@ -239,6 +239,8 @@
     "EnableThemeSongsHelp": "Play theme songs in the background while browsing the library.",
     "EnableThemeVideos": "Theme videos",
     "EnableThemeVideosHelp": "Play theme videos in the background while browsing the library.",
+    "EnableDetailsBanner": "Enable Details Banner",
+    "EnableDetailsBannerHelp": "Display a banner image at the top of the item details page.",
     "Ended": "Ended",
     "EndsAtValue": "Ends at {0}",
     "Episode": "Episode",
@@ -822,8 +824,8 @@
     "LabelSaveLocalMetadataHelp": "Saving artwork into media folders will put them in a place where they can be easily edited.",
     "LabelScheduledTaskLastRan": "Last ran {0}, taking {1}.",
     "LabelScreensaver": "Screensaver:",
-    "EnableFastImageFadeIn": "Fast image fade-in",
-    "EnableFastImageFadeInHelp": "Enable faster fade-in animation for loaded images",
+    "EnableFastImageFadeIn": "Image Fade Animations",
+    "EnableFastImageFadeInHelp": "Show posters and other images with a fade animation once they load.",
     "LabelSeasonNumber": "Season number:",
     "LabelSelectFolderGroups": "Automatically group content from the following folders into views such as Movies, Music and TV:",
     "LabelSelectFolderGroupsHelp": "Folders that are unchecked will be displayed by themselves in their own view.",
@@ -1294,7 +1296,7 @@
     "RefreshQueued": "Refresh queued.",
     "ReleaseDate": "Release date",
     "ReleaseGroup": "Release Group",
-    "RememberMe": "Remember me",
+    "RememberMe": "Remember Me",
     "RemoveFromCollection": "Remove from collection",
     "RemoveFromPlaylist": "Remove from playlist",
     "Repeat": "Repeat",

From a66f40d805c8293f42e44382f3073ad78a500dbe Mon Sep 17 00:00:00 2001
From: dkanada <dkanada@users.noreply.github.com>
Date: Thu, 28 May 2020 02:33:10 +0900
Subject: [PATCH 2/4] invert backdrop default setting

---
 src/scripts/settings/userSettings.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/scripts/settings/userSettings.js b/src/scripts/settings/userSettings.js
index 819b7867ca..06c5fa40a6 100644
--- a/src/scripts/settings/userSettings.js
+++ b/src/scripts/settings/userSettings.js
@@ -134,7 +134,7 @@ import events from 'events';
         }
 
         val = this.get('enableBackdrops', false);
-        return val === 'true';
+        return val !== 'false';
     }
 
     export function detailsBanner(val) {

From 91de4da786f7ca17fd6eadf3c6c14775c436fe80 Mon Sep 17 00:00:00 2001
From: dkanada <dkanada@users.noreply.github.com>
Date: Thu, 28 May 2020 02:34:45 +0900
Subject: [PATCH 3/4] update image fade animation strings

---
 src/strings/en-us.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/strings/en-us.json b/src/strings/en-us.json
index c9a8ff8909..e14678d2f6 100644
--- a/src/strings/en-us.json
+++ b/src/strings/en-us.json
@@ -824,8 +824,8 @@
     "LabelSaveLocalMetadataHelp": "Saving artwork into media folders will put them in a place where they can be easily edited.",
     "LabelScheduledTaskLastRan": "Last ran {0}, taking {1}.",
     "LabelScreensaver": "Screensaver:",
-    "EnableFastImageFadeIn": "Image Fade Animations",
-    "EnableFastImageFadeInHelp": "Show posters and other images with a fade animation once they load.",
+    "EnableFastImageFadeIn": "Fast Image Fade Animations",
+    "EnableFastImageFadeInHelp": "Show posters and other images with a quicker fade animation when they finish loading.",
     "LabelSeasonNumber": "Season number:",
     "LabelSelectFolderGroups": "Automatically group content from the following folders into views such as Movies, Music and TV:",
     "LabelSelectFolderGroupsHelp": "Folders that are unchecked will be displayed by themselves in their own view.",

From 1f2a9d186569edfe0902a496d34aedd4750f5d73 Mon Sep 17 00:00:00 2001
From: dkanada <dkanada@users.noreply.github.com>
Date: Thu, 28 May 2020 03:08:04 +0900
Subject: [PATCH 4/4] fix details banner string

---
 src/strings/en-us.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/strings/en-us.json b/src/strings/en-us.json
index e14678d2f6..9e57106df3 100644
--- a/src/strings/en-us.json
+++ b/src/strings/en-us.json
@@ -239,7 +239,7 @@
     "EnableThemeSongsHelp": "Play theme songs in the background while browsing the library.",
     "EnableThemeVideos": "Theme videos",
     "EnableThemeVideosHelp": "Play theme videos in the background while browsing the library.",
-    "EnableDetailsBanner": "Enable Details Banner",
+    "EnableDetailsBanner": "Details Banner",
     "EnableDetailsBannerHelp": "Display a banner image at the top of the item details page.",
     "Ended": "Ended",
     "EndsAtValue": "Ends at {0}",