Merge pull request #5948 from thornbill/refactor-display-prefs

src/apps/experimental/features/preferences/components/DisplayPreferences.tsx

@@ -15,8 +15,8 @@ import { useApi } from 'hooks/useApi';
 import { useThemes } from 'hooks/useThemes';
 import globalize from 'lib/globalize';
 
-import { DisplaySettingsValues } from './types';
+import { useScreensavers } from '../hooks/useScreensavers';
-import { useScreensavers } from './hooks/useScreensavers';
+import type { DisplaySettingsValues } from '../types/displaySettingsValues';
 
 interface DisplayPreferencesProps {
     onChange: (event: SelectChangeEvent | React.SyntheticEvent) => void;

src/apps/experimental/features/preferences/components/ItemDetailPreferences.tsx

@@ -7,7 +7,8 @@ import Typography from '@mui/material/Typography';
 import React from 'react';
 
 import globalize from 'lib/globalize';
-import { DisplaySettingsValues } from './types';
+
+import type { DisplaySettingsValues } from '../types/displaySettingsValues';
 
 interface ItemDetailPreferencesProps {
     onChange: (event: React.SyntheticEvent) => void;

src/apps/experimental/features/preferences/components/LibraryPreferences.tsx

@@ -8,7 +8,8 @@ import Typography from '@mui/material/Typography';
 import React from 'react';
 
 import globalize from 'lib/globalize';
-import { DisplaySettingsValues } from './types';
+
+import type { DisplaySettingsValues } from '../types/displaySettingsValues';
 
 interface LibraryPreferencesProps {
     onChange: (event: React.SyntheticEvent) => void;

src/apps/experimental/features/preferences/components/LocalizationPreferences.tsx

@@ -8,11 +8,12 @@ import Stack from '@mui/material/Stack';
 import Typography from '@mui/material/Typography';
 import React from 'react';
 
+import { DATE_LOCALE_OPTIONS, LANGUAGE_OPTIONS } from 'apps/experimental/features/preferences/constants/locales';
 import { appHost } from 'components/apphost';
 import datetime from 'scripts/datetime';
 import globalize from 'lib/globalize';
-import { DATE_LOCALE_OPTIONS, LANGUAGE_OPTIONS } from './constants';
+
-import { DisplaySettingsValues } from './types';
+import type { DisplaySettingsValues } from '../types/displaySettingsValues';
 
 interface LocalizationPreferencesProps {
     onChange: (event: SelectChangeEvent) => void;

src/apps/experimental/features/preferences/components/NextUpPreferences.tsx

@@ -8,7 +8,8 @@ import Typography from '@mui/material/Typography';
 import React from 'react';
 
 import globalize from 'lib/globalize';
-import { DisplaySettingsValues } from './types';
+
+import type { DisplaySettingsValues } from '../types/displaySettingsValues';
 
 interface NextUpPreferencesProps {
     onChange: (event: React.SyntheticEvent) => void;

src/apps/experimental/features/preferences/hooks/useDisplaySettingForm.ts

@@ -3,7 +3,8 @@ import { useSearchParams } from 'react-router-dom';
 
 import toast from 'components/toast/toast';
 import globalize from 'lib/globalize';
-import { DisplaySettingsValues } from '../types';
+
+import type { DisplaySettingsValues } from '../types/displaySettingsValues';
 import { useDisplaySettings } from './useDisplaySettings';
 
 type UpdateField = {

src/apps/experimental/features/preferences/hooks/useDisplaySettings.ts

@@ -1,4 +1,4 @@
-import { UserDto } from '@jellyfin/sdk/lib/generated-client';
+import type { UserDto } from '@jellyfin/sdk/lib/generated-client';
 import { ApiClient } from 'jellyfin-apiclient';
 import { useCallback, useEffect, useState } from 'react';
 
@@ -7,7 +7,8 @@ import layoutManager from 'components/layoutManager';
 import { useApi } from 'hooks/useApi';
 import themeManager from 'scripts/themeManager';
 import { currentSettings, UserSettings } from 'scripts/settings/userSettings';
-import { DisplaySettingsValues } from '../types';
+
+import type { DisplaySettingsValues } from '../types/displaySettingsValues';
 
 interface UseDisplaySettingsParams {
     userId?: string | null;

src/apps/experimental/routes/user/display/index.tsx

@@ -3,16 +3,16 @@ import { SelectChangeEvent } from '@mui/material/Select';
 import Stack from '@mui/material/Stack';
 import React, { useCallback } from 'react';
 
+import { DisplayPreferences } from 'apps/experimental/features/preferences/components/DisplayPreferences';
+import { ItemDetailPreferences } from 'apps/experimental/features/preferences/components/ItemDetailPreferences';
+import { LibraryPreferences } from 'apps/experimental/features/preferences/components/LibraryPreferences';
+import { useDisplaySettingForm } from 'apps/experimental/features/preferences/hooks/useDisplaySettingForm';
+import { LocalizationPreferences } from 'apps/experimental/features/preferences/components/LocalizationPreferences';
+import { NextUpPreferences } from 'apps/experimental/features/preferences/components/NextUpPreferences';
+import type { DisplaySettingsValues } from 'apps/experimental/features/preferences/types/displaySettingsValues';
+import LoadingComponent from 'components/loading/LoadingComponent';
 import Page from 'components/Page';
 import globalize from 'lib/globalize';
-import { DisplayPreferences } from './DisplayPreferences';
-import { ItemDetailPreferences } from './ItemDetailPreferences';
-import { LibraryPreferences } from './LibraryPreferences';
-import { LocalizationPreferences } from './LocalizationPreferences';
-import { NextUpPreferences } from './NextUpPreferences';
-import { useDisplaySettingForm } from './hooks/useDisplaySettingForm';
-import { DisplaySettingsValues } from './types';
-import LoadingComponent from 'components/loading/LoadingComponent';
 
 export default function UserDisplayPreferences() {
     const {