diff --git a/src/components/cardbuilder/cardBuilder.js b/src/components/cardbuilder/cardBuilder.js index 6d0c73afe0..6e8e45607e 100644 --- a/src/components/cardbuilder/cardBuilder.js +++ b/src/components/cardbuilder/cardBuilder.js @@ -89,7 +89,7 @@ export function setCardData(items, options) { options.coverImage = true; } else if (primaryImageAspectRatio >= 1.33) { options.shape = getBackdropShape(requestedShape === 'autooverflow'); - } else if (primaryImageAspectRatio > 0.71) { + } else if (primaryImageAspectRatio > 0.8) { options.shape = getSquareShape(requestedShape === 'autooverflow'); } else { options.shape = getPortraitShape(requestedShape === 'autooverflow'); diff --git a/src/components/cardbuilder/cardBuilderUtils.test.ts b/src/components/cardbuilder/cardBuilderUtils.test.ts index 501a395f9a..4bb48e1801 100644 --- a/src/components/cardbuilder/cardBuilderUtils.test.ts +++ b/src/components/cardbuilder/cardBuilderUtils.test.ts @@ -454,15 +454,15 @@ describe('resolveMixedShapeByAspectRatio', () => { expect(resolveMixedShapeByAspectRatio(1.34)).toEqual('mixedBackdrop'); }); - test('primary aspect ratio is > 0.71', () => { - expect(resolveMixedShapeByAspectRatio(0.72)).toEqual('mixedSquare'); - expect(resolveMixedShapeByAspectRatio(0.73)).toEqual('mixedSquare'); + test('primary aspect ratio is > 0.8', () => { + expect(resolveMixedShapeByAspectRatio(0.82)).toEqual('mixedSquare'); + expect(resolveMixedShapeByAspectRatio(0.83)).toEqual('mixedSquare'); expect(resolveMixedShapeByAspectRatio(1.32)).toEqual('mixedSquare'); }); - test('primary aspect ratio is <= 0.71', () => { - expect(resolveMixedShapeByAspectRatio(0.71)).toEqual('mixedPortrait'); - expect(resolveMixedShapeByAspectRatio(0.70)).toEqual('mixedPortrait'); + test('primary aspect ratio is <= 0.8', () => { + expect(resolveMixedShapeByAspectRatio(0.8)).toEqual('mixedPortrait'); + expect(resolveMixedShapeByAspectRatio(0.79)).toEqual('mixedPortrait'); expect(resolveMixedShapeByAspectRatio(0.01)).toEqual('mixedPortrait'); }); diff --git a/src/components/cardbuilder/cardBuilderUtils.ts b/src/components/cardbuilder/cardBuilderUtils.ts index 489d6c8abd..6f652ea99e 100644 --- a/src/components/cardbuilder/cardBuilderUtils.ts +++ b/src/components/cardbuilder/cardBuilderUtils.ts @@ -60,7 +60,7 @@ export const resolveMixedShapeByAspectRatio = (primaryImageAspectRatio: number | if (primaryImageAspectRatio >= 1.33) { return CardShape.MixedBackdrop; - } else if (primaryImageAspectRatio > 0.71) { + } else if (primaryImageAspectRatio > 0.8) { return CardShape.MixedSquare; } else { return CardShape.MixedPortrait;