From 27d1b79f878d6177fef31571288009931ad1640d Mon Sep 17 00:00:00 2001 From: Kalin K Date: Tue, 9 Aug 2022 14:51:43 +0300 Subject: [PATCH 1/2] Add 'no-return-await' rule to eslint --- .eslintrc.js | 1 + 1 file changed, 1 insertion(+) diff --git a/.eslintrc.js b/.eslintrc.js index 5c1c881c9e..7bade7be4b 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -49,6 +49,7 @@ module.exports = { 'no-multi-spaces': ['error'], 'no-multiple-empty-lines': ['error', { 'max': 1 }], 'no-restricted-globals': ['error'].concat(restrictedGlobals), + 'no-return-await': ['error'], 'no-trailing-spaces': ['error'], '@babel/no-unused-expressions': ['error', { 'allowShortCircuit': true, 'allowTernary': true, 'allowTaggedTemplates': true }], 'no-void': ['error', { 'allowAsStatement': true }], From 560583eccfae3ee5101e84c3f625af3fd14a9fc7 Mon Sep 17 00:00:00 2001 From: Kalin K Date: Tue, 9 Aug 2022 14:53:43 +0300 Subject: [PATCH 2/2] Remove redundant await from pluginManager --- src/components/pluginManager.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/pluginManager.js b/src/components/pluginManager.js index 9efaa8b4b4..998e839739 100644 --- a/src/components/pluginManager.js +++ b/src/components/pluginManager.js @@ -34,7 +34,7 @@ class PluginManager { // translations won't be loaded for skins until needed return plugin; } else { - return await this.#loadStrings(plugin); + return this.#loadStrings(plugin); } }