From e870cc733d4ccc96b815e506cadb797668d515ad Mon Sep 17 00:00:00 2001 From: Cyrus Boadway Date: Wed, 29 Jul 2020 23:00:07 +0100 Subject: [PATCH] Skip number key navigation when key is modified Pressing 0-9 seeks playback to the corresponding %. This overloaded browser tab switching when ALT/CTRL modifiers were active. --- src/controllers/playback/video/index.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/controllers/playback/video/index.js b/src/controllers/playback/video/index.js index d2bddfc136..580e331220 100644 --- a/src/controllers/playback/video/index.js +++ b/src/controllers/playback/video/index.js @@ -1131,6 +1131,7 @@ import 'css!assets/css/videoosd'; clickedElement = e.target; const key = keyboardnavigation.getKeyName(e); + const isKeyModified = e.ctrlKey || e.altKey; if (!currentVisibleMenu && 32 === e.keyCode) { playbackManager.playPause(currentPlayer); @@ -1235,8 +1236,10 @@ import 'css!assets/css/videoosd'; case '7': case '8': case '9': { - const percent = parseInt(key, 10) * 10; - playbackManager.seekPercent(percent, currentPlayer); + if (!isKeyModified) { + const percent = parseInt(key, 10) * 10; + playbackManager.seekPercent(percent, currentPlayer); + } break; } }