From eccd79c4e0dc212a8044c4583e9250b23e5153d2 Mon Sep 17 00:00:00 2001 From: Bill Thornton Date: Mon, 4 Oct 2021 11:31:50 -0400 Subject: [PATCH] Fix webpack dev server checks --- src/scripts/settings/webSettings.js | 2 +- src/serviceworker.js | 5 ++--- webpack.dev.js | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/scripts/settings/webSettings.js b/src/scripts/settings/webSettings.js index 8d1e038545..2eb1bcbd4f 100644 --- a/src/scripts/settings/webSettings.js +++ b/src/scripts/settings/webSettings.js @@ -73,7 +73,7 @@ export function getIncludeCorsCredentials() { export function getMultiServer() { return getConfig().then(config => { // Enable multi-server support when served by webpack - if (process.env.WEBPACK_SERVE) { // eslint-disable-line no-undef + if (__WEBPACK_SERVE__) { // eslint-disable-line no-undef return true; } return !!config.multiserver; diff --git a/src/serviceworker.js b/src/serviceworker.js index 1f38e2e5ad..ca4ea5efe8 100644 --- a/src/serviceworker.js +++ b/src/serviceworker.js @@ -44,9 +44,8 @@ self.addEventListener('notificationclick', function (event) { event.waitUntil(executeAction(action, data, serverId)); }, false); -// Do not precache files in development so live reload works as expected -/* eslint-disable-next-line no-undef -- WEBPACK_SERVE is replaced by webpack */ -if (process.env.WEBPACK_SERVE) { +// Do not precache files when running with webpack dev server so live reload works as expected +if (!__WEBPACK_SERVE__) { // eslint-disable-line no-undef // this is needed by the webpack Workbox plugin /* eslint-disable-next-line no-restricted-globals,no-undef */ precacheAndRoute(self.__WB_MANIFEST); diff --git a/webpack.dev.js b/webpack.dev.js index b66c8ddf01..4dc76aee3c 100644 --- a/webpack.dev.js +++ b/webpack.dev.js @@ -26,7 +26,7 @@ module.exports = merge(common, { }, plugins: [ new DefinePlugin({ - 'process.env.WEBPACK_SERVE': true + __WEBPACK_SERVE__: true }) ], devServer: {