mirrors/jellyfin-web
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00
Code Activity

chore: move logic from method to const

Browse source
This commit is contained in:
Ivan Schurawel 2022-11-13 20:40:02 -05:00 • committed by Ivan Schurawel
parent abc663f6f6
commit f3865f0dac
1 changed files with 16 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

34
src/controllers/playback/video/index.js
View file

@ -1035,26 +1035,10 @@ import { setBackdropTransparency, TRANSPARENCY_LEVEL } from '../../../components
setTimeout(resetIdle, 0); setTimeout(resetIdle, 0);
} }
/**
* Only show option if:
* - player has support
* - has more than 1 subtitle track
* - has valid secondary tracks
* - primary subtitle is not off
* - primary subtitle has support (index + 1 because `'Off'` is index 0 in `streams` array)
*/
function currentTrackCanHaveSecondarySubtitle(player, streams, currentIndex) {
const secondaryStreams = playbackManager.secondarySubtitleTracks(player);
return playbackManager.playerHasSecondarySubtitleSupport(player) &&
streams.length > 1 &&
secondaryStreams.length > 0 &&
currentIndex !== -1 &&
playbackManager.trackHasSecondarySubtitleSupport(streams[currentIndex + 1], player);
}
function showSubtitleTrackSelection() { function showSubtitleTrackSelection() {
const player = currentPlayer; const player = currentPlayer;
const streams = playbackManager.subtitleTracks(player); const streams = playbackManager.subtitleTracks(player);
const secondaryStreams = playbackManager.secondarySubtitleTracks(player);
let currentIndex = playbackManager.getSubtitleStreamIndex(player); let currentIndex = playbackManager.getSubtitleStreamIndex(player);
if (currentIndex == null) { if (currentIndex == null) {
@ -1078,7 +1062,21 @@ import { setBackdropTransparency, TRANSPARENCY_LEVEL } from '../../../components
return opt; return opt;
}); });
if (currentTrackCanHaveSecondarySubtitle(player, streams, currentIndex)) { /**
* Only show option if:
* - player has support
* - has more than 1 subtitle track
* - has valid secondary tracks
* - primary subtitle is not off
* - primary subtitle has support (index + 1 because `'Off'` is index 0 in `streams` array)
*/
const currentTrackCanAddSecondarySubtitle = playbackManager.playerHasSecondarySubtitleSupport(player) &&
streams.length > 1 &&
secondaryStreams.length > 0 &&
currentIndex !== -1 &&
playbackManager.trackHasSecondarySubtitleSupport(streams[currentIndex + 1], player);
if (currentTrackCanAddSecondarySubtitle) {
const secondarySubtitleMenuItem = { const secondarySubtitleMenuItem = {
name: globalize.translate('SecondarySubtitles'), name: globalize.translate('SecondarySubtitles'),
id: 'secondarysubtitle' id: 'secondarysubtitle'