Add no-return-assign eslint rule and fix issues

src/controllers/dashboard/apikeys.js

@@ -37,7 +37,8 @@ import { pageIdOn } from '../../utils/dashboard';
             const date = datetime.parseISO8601Date(item.DateCreated, true);
             html += datetime.toLocaleDateString(date) + ' ' + datetime.getDisplayTime(date);
             html += '</td>';
-            return html += '</tr>';
+            html += '</tr>';
+            return html;
         }).join('');
         page.querySelector('.resultBody').innerHTML = rows;
         loading.hide();

src/controllers/dashboard/dlna/profile.js

@@ -149,7 +149,8 @@ import { getParameterByName } from '../../../utils/url.ts';
             li += '<h3 class="listItemBodyText">' + escapeHtml(h.Name + ' = ' + (h.Value || '')) + '</h3>';
             li += '</div>';
             li += '<button type="button" is="paper-icon-button-light" class="btnDeleteXmlAttribute listItemButton" data-index="0"><span class="material-icons delete" aria-hidden="true"></span></button>';
-            return li += '</div>';
+            li += '</div>';
+            return li;
         }).join('') + '</div>';
         const elem = $('.xmlDocumentAttributeList', page).html(html).trigger('create');
         $('.btnDeleteXmlAttribute', elem).on('click', function () {

src/controllers/dashboard/plugins/available/index.js

@@ -129,7 +129,8 @@ function getPluginHtml(plugin, options, installedPlugins) {
     html += '</div>';
     html += '</div>';
     html += '</div>';
-    return html += '</div>';
+    html += '</div>';
+    return html;
 }
 
 function getTabs() {

src/controllers/livetvstatus.js

@@ -49,7 +49,8 @@ function getDeviceHtml(device) {
     html += '</div>';
     html += '</div>';
     html += '</div>';
-    return html += '</div>';
+    html += '</div>';
+    return html;
 }
 
 function renderDevices(page, devices) {