From f60b7686d0339524d6e9b023d6202190fe405e69 Mon Sep 17 00:00:00 2001 From: Bill Thornton Date: Tue, 26 Jan 2021 22:20:12 -0500 Subject: [PATCH] Remove unused variables --- .eslintrc.js | 3 +- src/components/activitylog.js | 4 +-- src/components/appFooter/appFooter.js | 2 +- src/components/backdrop/backdrop.js | 2 +- src/components/dialogHelper/dialogHelper.js | 4 +-- src/components/filtermenu/filtermenu.js | 2 +- src/components/focusManager.js | 2 +- src/components/guide/guide.js | 4 +-- .../homeScreenSettings/homeScreenSettings.js | 2 +- src/components/homesections/homesections.js | 10 +++---- src/components/itemsrefresher.js | 10 +++---- src/components/listview/listview.js | 5 ---- src/components/maintabsmanager.js | 2 +- src/components/mediainfo/mediainfo.js | 4 +-- .../metadataEditor/metadataEditor.js | 12 ++++---- src/components/metadataEditor/personEditor.js | 4 +-- src/components/multiSelect/multiSelect.js | 4 +-- src/components/notifications/notifications.js | 6 ++-- src/components/nowPlayingBar/nowPlayingBar.js | 6 ++-- src/components/playback/brightnessosd.js | 2 +- src/components/playback/playbackmanager.js | 24 +++++++-------- .../playback/playbackorientation.js | 2 +- .../playback/playerSelectionMenu.js | 6 ++-- src/components/playback/playqueuemanager.js | 2 +- src/components/playback/volumeosd.js | 2 +- src/components/playerstats/playerstats.js | 2 +- .../recordingcreator/recordingbutton.js | 2 +- .../recordingcreator/recordingeditor.js | 4 +-- .../recordingcreator/recordingfields.js | 8 ++--- src/components/refreshdialog/refreshdialog.js | 2 +- src/components/remotecontrol/remotecontrol.js | 16 +++++----- src/components/search/searchfields.js | 2 +- src/components/search/searchresults.js | 2 +- src/components/slideshow/slideshow.js | 5 ++-- .../subtitleuploader/subtitleuploader.js | 2 +- src/components/syncPlay/core/Manager.js | 8 ++--- .../syncPlay/core/players/GenericPlayer.js | 11 +++++++ .../syncPlay/ui/players/NoActivePlayer.js | 30 +++++++++---------- .../syncPlay/ui/players/QueueManager.js | 20 ++++++------- src/components/tabbedview/tabbedview.js | 6 ++-- src/components/tunerPicker.js | 2 +- src/components/tvproviders/schedulesdirect.js | 4 +-- src/components/tvproviders/xmltv.js | 2 +- src/controllers/dashboard/dashboard.js | 4 +-- src/controllers/dashboard/devices/device.js | 2 +- src/controllers/dashboard/devices/devices.js | 2 +- src/controllers/dashboard/encodingsettings.js | 4 +-- src/controllers/dashboard/general.js | 11 +------ src/controllers/dashboard/librarydisplay.js | 2 +- src/controllers/dashboard/logs.js | 2 +- src/controllers/dashboard/metadatanfo.js | 2 +- src/controllers/dashboard/networking.js | 4 +-- .../notifications/notification/index.js | 2 +- .../notifications/notifications/index.js | 2 +- .../dashboard/plugins/repositories/index.js | 8 ++--- .../dashboard/scheduledtasks/scheduledtask.js | 2 +- .../scheduledtasks/scheduledtasks.js | 2 +- src/controllers/dashboard/users/useredit.js | 2 +- .../dashboard/users/userlibraryaccess.js | 2 +- src/controllers/dashboard/users/usernew.js | 2 +- .../dashboard/users/userparentalcontrol.js | 2 +- .../dashboard/users/userprofilespage.js | 2 +- src/controllers/edititemmetadata.js | 2 +- src/controllers/list.js | 2 +- src/controllers/livetv/livetvchannels.js | 2 +- src/controllers/livetv/livetvrecordings.js | 2 +- src/controllers/livetvstatus.js | 2 +- src/controllers/livetvtuner.js | 2 +- src/controllers/movies/moviesrecommended.js | 4 +-- src/controllers/music/musicalbums.js | 2 +- src/controllers/music/musicrecommended.js | 6 ++-- src/controllers/playback/queue/index.js | 6 ++-- src/controllers/playback/video/index.js | 18 +++++------ src/controllers/session/addServer/index.js | 2 +- .../session/forgotPassword/index.js | 2 +- src/controllers/session/login/index.js | 4 +-- .../session/resetPassword/index.js | 2 +- src/controllers/shows/tvrecommended.js | 6 ++-- src/controllers/user/display/index.js | 5 ---- src/controllers/user/home/index.js | 5 ---- src/controllers/user/playback/index.js | 5 ---- src/controllers/user/profile/index.js | 4 +-- src/controllers/user/subtitles/index.js | 5 ---- src/controllers/wizard/finish/index.js | 2 +- src/controllers/wizard/remote/index.js | 2 +- src/controllers/wizard/settings/index.js | 2 +- src/controllers/wizard/start/index.js | 2 +- src/controllers/wizard/user/index.js | 2 +- src/elements/emby-collapse/emby-collapse.js | 2 +- .../emby-itemscontainer.js | 2 +- .../emby-playstatebutton.js | 2 +- .../emby-progressring/emby-progressring.js | 2 +- .../emby-ratingbutton/emby-ratingbutton.js | 2 +- .../emby-scrollbuttons/emby-scrollbuttons.js | 4 +-- src/elements/emby-select/emby-select.js | 4 +-- src/elements/emby-slider/emby-slider.js | 6 ++-- src/elements/emby-tabs/emby-tabs.js | 6 ++-- src/plugins/chromecastPlayer/plugin.js | 10 +++---- src/plugins/htmlAudioPlayer/plugin.js | 6 ++-- src/plugins/pdfPlayer/plugin.js | 2 +- src/plugins/photoPlayer/plugin.js | 2 +- src/plugins/sessionPlayer/plugin.js | 8 ++--- src/plugins/youtubePlayer/plugin.js | 12 ++++---- src/scripts/clientUtils.js | 10 ++----- src/scripts/gamepadtokey.js | 4 +-- src/scripts/globalize.js | 2 +- src/scripts/keyboardNavigation.js | 2 +- src/scripts/libraryMenu.js | 16 +++++----- src/scripts/playlists.js | 2 +- src/scripts/themeManager.js | 2 +- 110 files changed, 242 insertions(+), 277 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index d45cc5dd05..8b42edd9e8 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -101,8 +101,7 @@ module.exports = { rules: { // TODO: Fix warnings and remove these rules 'no-redeclare': ['warn'], - 'no-useless-escape': ['warn'], - 'no-unused-vars': ['warn'] + 'no-useless-escape': ['warn'] }, settings: { polyfills: [ diff --git a/src/components/activitylog.js b/src/components/activitylog.js index 976a37dda0..bc5ab586c1 100644 --- a/src/components/activitylog.js +++ b/src/components/activitylog.js @@ -54,7 +54,7 @@ import alert from './alert'; return html; } - function renderList(elem, apiClient, result, startIndex, limit) { + function renderList(elem, apiClient, result) { elem.innerHTML = result.Items.map(function (i) { return getEntryHtml(i, apiClient); }).join(''); @@ -101,7 +101,7 @@ import alert from './alert'; }); } - function onActivityLogUpdate(e, apiClient, data) { + function onActivityLogUpdate(e, apiClient) { const options = this.options; if (options && options.serverId === apiClient.serverId()) { diff --git a/src/components/appFooter/appFooter.js b/src/components/appFooter/appFooter.js index 2dc396371c..5f16e7c7fb 100644 --- a/src/components/appFooter/appFooter.js +++ b/src/components/appFooter/appFooter.js @@ -1,6 +1,6 @@ import './appFooter.scss'; -function render(options) { +function render() { const elem = document.createElement('div'); elem.classList.add('appfooter'); diff --git a/src/components/backdrop/backdrop.js b/src/components/backdrop/backdrop.js index c16d04015d..c91645b574 100644 --- a/src/components/backdrop/backdrop.js +++ b/src/components/backdrop/backdrop.js @@ -7,7 +7,7 @@ import ServerConnections from '../ServerConnections'; /* eslint-disable indent */ - function enableAnimation(elem) { + function enableAnimation() { if (browser.slow) { return false; } diff --git a/src/components/dialogHelper/dialogHelper.js b/src/components/dialogHelper/dialogHelper.js index 1a374aed57..a8410fcf70 100644 --- a/src/components/dialogHelper/dialogHelper.js +++ b/src/components/dialogHelper/dialogHelper.js @@ -48,7 +48,7 @@ import '../../assets/css/scrollstyles.scss'; const activeElement = document.activeElement; let removeScrollLockOnClose = false; - function onHashChange(e) { + function onHashChange() { const isBack = self.originalUrl === window.location.href; if (isBack || !isOpened(dlg)) { @@ -200,7 +200,7 @@ import '../../assets/css/scrollstyles.scss'; dlg.dialogContainer = dialogContainer; document.body.appendChild(dialogContainer); - return new Promise((resolve, reject) => { + return new Promise((resolve) => { new DialogHashHandler(dlg, `dlg${new Date().getTime()}`, resolve); }); } diff --git a/src/components/filtermenu/filtermenu.js b/src/components/filtermenu/filtermenu.js index 7f1cf3dabf..b36145f193 100644 --- a/src/components/filtermenu/filtermenu.js +++ b/src/components/filtermenu/filtermenu.js @@ -210,7 +210,7 @@ function loadDynamicFilters(context, options) { } class FilterMenu { show(options) { - return new Promise( (resolve, reject) => { + return new Promise( (resolve) => { const dialogOptions = { removeOnClose: true, scrollY: false diff --git a/src/components/focusManager.js b/src/components/focusManager.js index b0fc188516..0b0ae06211 100644 --- a/src/components/focusManager.js +++ b/src/components/focusManager.js @@ -8,7 +8,7 @@ import scrollManager from './scrollManager'; scopes.push(elem); } - function popScope(elem) { + function popScope() { if (scopes.length) { scopes.length -= 1; } diff --git a/src/components/guide/guide.js b/src/components/guide/guide.js index 460295b285..2d39183bde 100644 --- a/src/components/guide/guide.js +++ b/src/components/guide/guide.js @@ -1057,7 +1057,7 @@ function Guide(options) { } } - function onSeriesTimerCreated(e, apiClient, data) { + function onSeriesTimerCreated() { } function onTimerCancelled(e, apiClient, data) { @@ -1116,7 +1116,7 @@ function Guide(options) { programGrid.classList.add('noRubberBanding'); } - dom.addEventListener(programGrid, 'scroll', function (e) { + dom.addEventListener(programGrid, 'scroll', function () { onProgramGridScroll(guideContext, this, timeslotHeaders); }, { passive: true diff --git a/src/components/homeScreenSettings/homeScreenSettings.js b/src/components/homeScreenSettings/homeScreenSettings.js index c1823f5398..02d0114b30 100644 --- a/src/components/homeScreenSettings/homeScreenSettings.js +++ b/src/components/homeScreenSettings/homeScreenSettings.js @@ -219,7 +219,7 @@ import template from './homeScreenSettings.template.html'; context.querySelector('.selectTVHomeScreen').value = userSettings.get('tvhome') || ''; } - function getPerLibrarySettingsHtml(item, user, userSettings, apiClient) { + function getPerLibrarySettingsHtml(item, user, userSettings) { let html = ''; let isChecked; diff --git a/src/components/homesections/homesections.js b/src/components/homesections/homesections.js index 6fc2eb7d39..e67f9d7825 100644 --- a/src/components/homesections/homesections.js +++ b/src/components/homesections/homesections.js @@ -335,7 +335,7 @@ import ServerConnections from '../ServerConnections'; } } - export function loadLibraryTiles(elem, apiClient, user, userSettings, shape, userViews, allSections) { + export function loadLibraryTiles(elem, apiClient, user, userSettings, shape, userViews) { let html = ''; if (userViews.length) { html += '

' + globalize.translate('HeaderMyMedia') + '

'; @@ -415,7 +415,7 @@ import ServerConnections from '../ServerConnections'; }); } - function loadResumeVideo(elem, apiClient, userId) { + function loadResumeVideo(elem, apiClient) { let html = ''; html += '

' + globalize.translate('HeaderContinueWatching') + '

'; @@ -488,7 +488,7 @@ import ServerConnections from '../ServerConnections'; }); } - function loadResumeAudio(elem, apiClient, userId) { + function loadResumeAudio(elem, apiClient) { let html = ''; html += '

' + globalize.translate('HeaderContinueListening') + '

'; @@ -688,7 +688,7 @@ import ServerConnections from '../ServerConnections'; }); } - function loadNextUp(elem, apiClient, userId) { + function loadNextUp(elem, apiClient) { let html = ''; html += '
'; @@ -766,7 +766,7 @@ import ServerConnections from '../ServerConnections'; }; } - function loadLatestLiveTvRecordings(elem, activeRecordingsOnly, apiClient, userId) { + function loadLatestLiveTvRecordings(elem, activeRecordingsOnly, apiClient) { const title = activeRecordingsOnly ? globalize.translate('HeaderActiveRecordings') : globalize.translate('HeaderLatestRecordings'); diff --git a/src/components/itemsrefresher.js b/src/components/itemsrefresher.js index b5a73f5c45..5a5d93e15d 100644 --- a/src/components/itemsrefresher.js +++ b/src/components/itemsrefresher.js @@ -2,7 +2,7 @@ import { playbackManager } from './playback/playbackmanager'; import serverNotifications from '../scripts/serverNotifications'; import { Events } from 'jellyfin-apiclient'; -function onUserDataChanged(e, apiClient, userData) { +function onUserDataChanged() { const instance = this; const eventsToMonitor = getEventsToMonitor(instance); @@ -25,7 +25,7 @@ function getEventsToMonitor(instance) { return []; } -function onTimerCreated(e, apiClient, data) { +function onTimerCreated() { const instance = this; if (getEventsToMonitor(instance).indexOf('timers') !== -1) { @@ -34,7 +34,7 @@ function onTimerCreated(e, apiClient, data) { } } -function onSeriesTimerCreated(e, apiClient, data) { +function onSeriesTimerCreated() { const instance = this; if (getEventsToMonitor(instance).indexOf('seriestimers') !== -1) { instance.notifyRefreshNeeded(); @@ -42,7 +42,7 @@ function onSeriesTimerCreated(e, apiClient, data) { } } -function onTimerCancelled(e, apiClient, data) { +function onTimerCancelled() { const instance = this; if (getEventsToMonitor(instance).indexOf('timers') !== -1) { @@ -51,7 +51,7 @@ function onTimerCancelled(e, apiClient, data) { } } -function onSeriesTimerCancelled(e, apiClient, data) { +function onSeriesTimerCancelled() { const instance = this; if (getEventsToMonitor(instance).indexOf('seriestimers') !== -1) { instance.notifyRefreshNeeded(); diff --git a/src/components/listview/listview.js b/src/components/listview/listview.js index 5ca17d137a..c7dc0be3ae 100644 --- a/src/components/listview/listview.js +++ b/src/components/listview/listview.js @@ -163,10 +163,6 @@ import ServerConnections from '../ServerConnections'; return html; } - function getId(item) { - return item.Id; - } - export function getListViewHtml(options) { const items = options.items; @@ -183,7 +179,6 @@ import ServerConnections from '../ServerConnections'; let outerHtml = ''; const enableContentWrapper = options.enableOverview && !layoutManager.tv; - const containerAlbumArtistIds = (options.containerAlbumArtists || []).map(getId); for (let i = 0, length = items.length; i < length; i++) { const item = items[i]; diff --git a/src/components/maintabsmanager.js b/src/components/maintabsmanager.js index 1c63b53bed..995cb5615a 100644 --- a/src/components/maintabsmanager.js +++ b/src/components/maintabsmanager.js @@ -47,7 +47,7 @@ import '../elements/emby-button/emby-button'; return true; } - function configureSwipeTabs(view, tabsElem, getTabContainersFn) { + function configureSwipeTabs(view, tabsElem) { if (!browser.touch) { return; } diff --git a/src/components/mediainfo/mediainfo.js b/src/components/mediainfo/mediainfo.js index 0b09c3dff3..717a297246 100644 --- a/src/components/mediainfo/mediainfo.js +++ b/src/components/mediainfo/mediainfo.js @@ -490,9 +490,7 @@ import '../../elements/emby-button/emby-button'; })[0]; } - export function getMediaInfoStats(item, options) { - options = options || {}; - + export function getMediaInfoStats(item) { const list = []; const mediaSource = (item.MediaSources || [])[0] || {}; diff --git a/src/components/metadataEditor/metadataEditor.js b/src/components/metadataEditor/metadataEditor.js index b020f88e13..f0c3fdc263 100644 --- a/src/components/metadataEditor/metadataEditor.js +++ b/src/components/metadataEditor/metadataEditor.js @@ -31,7 +31,7 @@ import template from './metadataEditor.template.html'; return currentContext.classList.contains('dialog'); } - function closeDialog(isSubmitted) { + function closeDialog() { if (isDialog()) { dialogHelper.close(currentContext); } @@ -298,7 +298,7 @@ import template from './metadataEditor.template.html'; } } - function init(context, apiClient) { + function init(context) { context.querySelector('.externalIds').addEventListener('click', function (e) { const btnOpenExternalId = dom.parentWithClass(e.target, 'btnOpenExternalId'); if (btnOpenExternalId) { @@ -328,7 +328,7 @@ import template from './metadataEditor.template.html'; }); }); - context.querySelector('.btnHeaderSave').addEventListener('click', function (e) { + context.querySelector('.btnHeaderSave').addEventListener('click', function () { context.querySelector('.btnSave').click(); }); @@ -347,7 +347,7 @@ import template from './metadataEditor.template.html'; form.removeEventListener('submit', onSubmit); form.addEventListener('submit', onSubmit); - context.querySelector('#btnAddPerson').addEventListener('click', function (event, data) { + context.querySelector('#btnAddPerson').addEventListener('click', function () { editPerson(context, {}, -1); }); @@ -1026,7 +1026,7 @@ import template from './metadataEditor.template.html'; }); } - function show(itemId, serverId, resolve, reject) { + function show(itemId, serverId, resolve) { loading.show(); const dialogOptions = { @@ -1079,7 +1079,7 @@ import template from './metadataEditor.template.html'; }, embed: function (elem, itemId, serverId) { - return new Promise(function (resolve, reject) { + return new Promise(function () { loading.show(); elem.innerHTML = globalize.translateHtml(template, 'core'); diff --git a/src/components/metadataEditor/personEditor.js b/src/components/metadataEditor/personEditor.js index 0911632748..51f784db4f 100644 --- a/src/components/metadataEditor/personEditor.js +++ b/src/components/metadataEditor/personEditor.js @@ -63,7 +63,7 @@ import template from './personEditor.template.html'; } }); - dlg.querySelector('.selectPersonType').addEventListener('change', function (e) { + dlg.querySelector('.selectPersonType').addEventListener('change', function () { if (this.value === 'Actor') { dlg.querySelector('.fldRole').classList.remove('hide'); } else { @@ -71,7 +71,7 @@ import template from './personEditor.template.html'; } }); - dlg.querySelector('.btnCancel').addEventListener('click', function (e) { + dlg.querySelector('.btnCancel').addEventListener('click', function () { dialogHelper.close(dlg); }); diff --git a/src/components/multiSelect/multiSelect.js b/src/components/multiSelect/multiSelect.js index f2f359ae98..c39690cb89 100644 --- a/src/components/multiSelect/multiSelect.js +++ b/src/components/multiSelect/multiSelect.js @@ -84,7 +84,7 @@ import confirm from '../confirm/confirm'; } } - function onSelectionChange(e) { + function onSelectionChange() { updateItemSelection(this, this.checked); } @@ -459,7 +459,7 @@ import confirm from '../confirm/confirm'; touchStartTimeout = setTimeout(onTouchStartTimerFired, 550); } - function onMouseOut(e) { + function onMouseOut() { if (touchStartTimeout) { clearTimeout(touchStartTimeout); touchStartTimeout = null; diff --git a/src/components/notifications/notifications.js b/src/components/notifications/notifications.js index 0267c378ce..17104cf9bd 100644 --- a/src/components/notifications/notifications.js +++ b/src/components/notifications/notifications.js @@ -41,7 +41,7 @@ function resetRegistration() { resetRegistration(); -function showPersistentNotification(title, options, timeoutMs) { +function showPersistentNotification(title, options) { serviceWorkerRegistration.showNotification(title, options); } @@ -219,7 +219,7 @@ Events.on(serverNotifications, 'PackageInstalling', function (e, apiClient, data showPackageInstallNotification(apiClient, data, 'progress'); }); -Events.on(serverNotifications, 'ServerShuttingDown', function (e, apiClient, data) { +Events.on(serverNotifications, 'ServerShuttingDown', function (e, apiClient) { const serverId = apiClient.serverInfo().Id; const notification = { tag: 'restart' + serverId, @@ -228,7 +228,7 @@ Events.on(serverNotifications, 'ServerShuttingDown', function (e, apiClient, dat showNotification(notification, 0, apiClient); }); -Events.on(serverNotifications, 'ServerRestarting', function (e, apiClient, data) { +Events.on(serverNotifications, 'ServerRestarting', function (e, apiClient) { const serverId = apiClient.serverInfo().Id; const notification = { tag: 'restart' + serverId, diff --git a/src/components/nowPlayingBar/nowPlayingBar.js b/src/components/nowPlayingBar/nowPlayingBar.js index da32640c76..daa2d3bf15 100644 --- a/src/components/nowPlayingBar/nowPlayingBar.js +++ b/src/components/nowPlayingBar/nowPlayingBar.js @@ -648,7 +648,7 @@ import { appRouter } from '../appRouter'; } } - function onPlayPauseStateChanged(e) { + function onPlayPauseStateChanged() { if (!isEnabled) { return; } @@ -682,7 +682,7 @@ import { appRouter } from '../appRouter'; updatePlayerStateInternal(event, state, player); } - function onTimeUpdate(e) { + function onTimeUpdate() { if (!isEnabled) { return; } @@ -718,7 +718,7 @@ import { appRouter } from '../appRouter'; } } - function onVolumeChanged(e) { + function onVolumeChanged() { if (!isEnabled) { return; } diff --git a/src/components/playback/brightnessosd.js b/src/components/playback/brightnessosd.js index fe6ba2e0e2..a23fdc0b18 100644 --- a/src/components/playback/brightnessosd.js +++ b/src/components/playback/brightnessosd.js @@ -127,7 +127,7 @@ function releaseCurrentPlayer() { } } -function onBrightnessChanged(e) { +function onBrightnessChanged() { const player = this; ensureOsdElement(); diff --git a/src/components/playback/playbackmanager.js b/src/components/playback/playbackmanager.js index 2b6c13bb1c..696e323317 100644 --- a/src/components/playback/playbackmanager.js +++ b/src/components/playback/playbackmanager.js @@ -270,7 +270,7 @@ function getIntros(firstItem, apiClient, options) { return apiClient.getIntros(firstItem.Id).then(function (result) { return result; - }, function (err) { + }, function () { return Promise.resolve({ Items: [] }); @@ -619,7 +619,7 @@ function supportsDirectPlay(apiClient, item, mediaSource) { return isHostReachable(mediaSource, apiClient); } } else if (mediaSource.Protocol === 'File') { - return new Promise(function (resolve, reject) { + return new Promise(function (resolve) { // Determine if the file can be accessed directly import('../../scripts/filesystem').then((filesystem) => { const method = isFolderRip ? @@ -1711,7 +1711,7 @@ class PlaybackManager { }); } - function changeStreamToUrl(apiClient, player, playSessionId, streamInfo, newPositionTicks) { + function changeStreamToUrl(apiClient, player, playSessionId, streamInfo) { const playerData = getPlayerData(player); playerData.isChangingStream = true; @@ -2037,7 +2037,7 @@ class PlaybackManager { // Only used internally self.getCurrentTicks = getCurrentTicks; - function playOther(items, options, user) { + function playOther(items, options) { const playStartIndex = options.startIndex || 0; const player = getPlayer(items[playStartIndex], options); @@ -3030,27 +3030,27 @@ class PlaybackManager { } } - function onPlaybackTimeUpdate(e) { + function onPlaybackTimeUpdate() { const player = this; sendProgressUpdate(player, 'timeupdate'); } - function onPlaybackPause(e) { + function onPlaybackPause() { const player = this; sendProgressUpdate(player, 'pause'); } - function onPlaybackUnpause(e) { + function onPlaybackUnpause() { const player = this; sendProgressUpdate(player, 'unpause'); } - function onPlaybackVolumeChange(e) { + function onPlaybackVolumeChange() { const player = this; sendProgressUpdate(player, 'volumechange'); } - function onRepeatModeChange(e) { + function onRepeatModeChange() { const player = this; sendProgressUpdate(player, 'repeatmodechange'); } @@ -3060,17 +3060,17 @@ class PlaybackManager { sendProgressUpdate(player, 'shufflequeuemodechange'); } - function onPlaylistItemMove(e) { + function onPlaylistItemMove() { const player = this; sendProgressUpdate(player, 'playlistitemmove', true); } - function onPlaylistItemRemove(e) { + function onPlaylistItemRemove() { const player = this; sendProgressUpdate(player, 'playlistitemremove', true); } - function onPlaylistItemAdd(e) { + function onPlaylistItemAdd() { const player = this; sendProgressUpdate(player, 'playlistitemadd', true); } diff --git a/src/components/playback/playbackorientation.js b/src/components/playback/playbackorientation.js index d763726b10..66b461738d 100644 --- a/src/components/playback/playbackorientation.js +++ b/src/components/playback/playbackorientation.js @@ -14,7 +14,7 @@ function onOrientationChangeError(err) { console.error('error locking orientation: ' + err); } -Events.on(playbackManager, 'playbackstart', function (e, player, state) { +Events.on(playbackManager, 'playbackstart', function (e, player) { const isLocalVideo = player.isLocalPlayer && !player.isExternalPlayer && playbackManager.isPlayingVideo(player); if (isLocalVideo && layoutManager.mobile) { diff --git a/src/components/playback/playerSelectionMenu.js b/src/components/playback/playerSelectionMenu.js index 35871c1fe8..7e34ca90a3 100644 --- a/src/components/playback/playerSelectionMenu.js +++ b/src/components/playback/playerSelectionMenu.js @@ -301,15 +301,15 @@ Events.on(appSettings, 'change', function (e, name) { } }); -Events.on(playbackManager, 'pairing', function (e) { +Events.on(playbackManager, 'pairing', function () { loading.show(); }); -Events.on(playbackManager, 'paired', function (e) { +Events.on(playbackManager, 'paired', function () { loading.hide(); }); -Events.on(playbackManager, 'pairerror', function (e) { +Events.on(playbackManager, 'pairerror', function () { loading.hide(); }); diff --git a/src/components/playback/playqueuemanager.js b/src/components/playback/playqueuemanager.js index fbe1ceabfe..a1ed503372 100644 --- a/src/components/playback/playqueuemanager.js +++ b/src/components/playback/playqueuemanager.js @@ -114,7 +114,7 @@ class PlayQueueManager { return this._currentPlaylistItemId; } - setPlaylistState(playlistItemId, playlistIndex) { + setPlaylistState(playlistItemId) { this._currentPlaylistItemId = playlistItemId; } diff --git a/src/components/playback/volumeosd.js b/src/components/playback/volumeosd.js index 796030f89f..6412a6e9a5 100644 --- a/src/components/playback/volumeosd.js +++ b/src/components/playback/volumeosd.js @@ -118,7 +118,7 @@ function releaseCurrentPlayer() { } } -function onVolumeChanged(e) { +function onVolumeChanged() { const player = this; ensureOsdElement(); diff --git a/src/components/playerstats/playerstats.js b/src/components/playerstats/playerstats.js index bac81609ef..d93534db09 100644 --- a/src/components/playerstats/playerstats.js +++ b/src/components/playerstats/playerstats.js @@ -196,7 +196,7 @@ import ServerConnections from '../ServerConnections'; } } - function getMediaSourceStats(session, player, displayPlayMethod) { + function getMediaSourceStats(session, player) { const sessionStats = []; const mediaSource = playbackManager.currentMediaSource(player) || {}; diff --git a/src/components/recordingcreator/recordingbutton.js b/src/components/recordingcreator/recordingbutton.js index ebb27595e1..a05a44b2e5 100644 --- a/src/components/recordingcreator/recordingbutton.js +++ b/src/components/recordingcreator/recordingbutton.js @@ -5,7 +5,7 @@ import '../../elements/emby-button/emby-button'; import './recordingfields.scss'; import ServerConnections from '../ServerConnections'; -function onRecordingButtonClick(e) { +function onRecordingButtonClick() { const item = this.item; if (item) { diff --git a/src/components/recordingcreator/recordingeditor.js b/src/components/recordingcreator/recordingeditor.js index c627e9e4ef..5472244656 100644 --- a/src/components/recordingcreator/recordingeditor.js +++ b/src/components/recordingcreator/recordingeditor.js @@ -28,7 +28,7 @@ function deleteTimer(apiClient, timerId) { }); } -function renderTimer(context, item, apiClient) { +function renderTimer(context, item) { context.querySelector('#txtPrePaddingMinutes').value = item.PrePaddingSeconds / 60; context.querySelector('#txtPostPaddingMinutes').value = item.PostPaddingSeconds / 60; @@ -85,7 +85,7 @@ function reload(context, id) { } function showEditor(itemId, serverId, options) { - return new Promise(function (resolve, reject) { + return new Promise(function (resolve) { recordingDeleted = false; currentServerId = serverId; loading.show(); diff --git a/src/components/recordingcreator/recordingfields.js b/src/components/recordingcreator/recordingfields.js index ae2742d77a..35f92d02ea 100644 --- a/src/components/recordingcreator/recordingfields.js +++ b/src/components/recordingcreator/recordingfields.js @@ -14,7 +14,7 @@ import template from './recordingfields.template.html'; /*eslint prefer-const: "error"*/ -function loadData(parent, program, apiClient) { +function loadData(parent, program) { if (program.IsSeries) { parent.querySelector('.recordSeriesContainer').classList.remove('hide'); } else { @@ -119,7 +119,7 @@ class RecordingEditor { embed() { const self = this; - return new Promise(function (resolve, reject) { + return new Promise(function (resolve) { const options = self.options; const context = options.parent; context.innerHTML = globalize.translateHtml(template, 'core'); @@ -156,7 +156,7 @@ class RecordingEditor { } } -function onManageRecordingClick(e) { +function onManageRecordingClick() { const options = this.options; if (!this.TimerId || this.Status === 'Cancelled') { return; @@ -172,7 +172,7 @@ function onManageRecordingClick(e) { }); } -function onManageSeriesRecordingClick(e) { +function onManageSeriesRecordingClick() { const options = this.options; if (!this.SeriesTimerId) { diff --git a/src/components/refreshdialog/refreshdialog.js b/src/components/refreshdialog/refreshdialog.js index fe5756af3d..bffafa163a 100644 --- a/src/components/refreshdialog/refreshdialog.js +++ b/src/components/refreshdialog/refreshdialog.js @@ -155,7 +155,7 @@ class RefreshDialog { centerFocus(dlg.querySelector('.formDialogContent'), false, true); } - return new Promise(function (resolve, reject) { + return new Promise(function (resolve) { if (layoutManager.tv) { centerFocus(dlg.querySelector('.formDialogContent'), false, false); } diff --git a/src/components/remotecontrol/remotecontrol.js b/src/components/remotecontrol/remotecontrol.js index d502d017e7..543c453071 100644 --- a/src/components/remotecontrol/remotecontrol.js +++ b/src/components/remotecontrol/remotecontrol.js @@ -24,7 +24,7 @@ import { appRouter } from '../appRouter'; let showMuteButton = true; let showVolumeSlider = true; -function showAudioMenu(context, player, button, item) { +function showAudioMenu(context, player, button) { const currentIndex = playbackManager.getAudioStreamIndex(player); const streams = playbackManager.audioTracks(player); const menuItems = streams.map(function (s) { @@ -51,7 +51,7 @@ function showAudioMenu(context, player, button, item) { }); } -function showSubtitleMenu(context, player, button, item) { +function showSubtitleMenu(context, player, button) { const currentIndex = playbackManager.getSubtitleStreamIndex(player); const streams = playbackManager.subtitleTracks(player); const menuItems = streams.map(function (s) { @@ -572,7 +572,7 @@ export default function () { } } - function onPlaylistUpdate(e) { + function onPlaylistUpdate() { loadPlaylist(dlg, this); } @@ -603,7 +603,7 @@ export default function () { } } - function onPlayPauseStateChanged(e) { + function onPlayPauseStateChanged() { updatePlayPauseState(this.paused(), true); } @@ -613,7 +613,7 @@ export default function () { onPlaylistUpdate(); } - function onTimeUpdate(e) { + function onTimeUpdate() { const now = new Date().getTime(); if (!(now - lastUpdateTime < 700)) { @@ -624,7 +624,7 @@ export default function () { } } - function onVolumeChanged(e) { + function onVolumeChanged() { const player = this; updatePlayerVolumeState(dlg, player.isMuted(), player.getVolume()); } @@ -922,13 +922,13 @@ export default function () { } } - function onDialogClosed(e) { + function onDialogClosed() { releaseCurrentPlayer(); Events.off(playbackManager, 'playerchange', onPlayerChange); lastPlayerState = null; } - function onShow(context, tab) { + function onShow(context) { bindToPlayer(context, playbackManager.getCurrentPlayer()); } diff --git a/src/components/search/searchfields.js b/src/components/search/searchfields.js index 601966db40..0b5de52576 100644 --- a/src/components/search/searchfields.js +++ b/src/components/search/searchfields.js @@ -61,7 +61,7 @@ import template from './searchfields.template.html'; triggerSearch(searchFieldsInstance, value); } - function embed(elem, instance, options) { + function embed(elem, instance) { let html = globalize.translateHtml(template, 'core'); if (browser.tizen || browser.orsay) { diff --git a/src/components/search/searchresults.js b/src/components/search/searchresults.js index 367132ef9d..7a9f1d49f7 100644 --- a/src/components/search/searchresults.js +++ b/src/components/search/searchresults.js @@ -585,7 +585,7 @@ import template from './searchresults.template.html'; return originalString.replace(reg, strWith); } - function embed(elem, instance, options) { + function embed(elem, instance) { let workingTemplate = template; if (!enableScrollX()) { workingTemplate = replaceAll(workingTemplate, 'data-horizontal="true"', 'data-horizontal="false"'); diff --git a/src/components/slideshow/slideshow.js b/src/components/slideshow/slideshow.js index 6ae0c26f0a..acef913e0d 100644 --- a/src/components/slideshow/slideshow.js +++ b/src/components/slideshow/slideshow.js @@ -210,7 +210,7 @@ export default function (options) { dialog.innerHTML = html; if (options.interactive && !layoutManager.tv) { - dialog.querySelector('.btnSlideshowExit').addEventListener('click', function (e) { + dialog.querySelector('.btnSlideshowExit').addEventListener('click', function () { dialogHelper.close(dialog); }); @@ -381,10 +381,9 @@ export default function (options) { /** * Renders the HTML markup of a slide for an item or a slide. * @param {Object} item - The item used to render the slide. - * @param {number} index - The index of the item in the Swiper instance. * @returns {string} The HTML markup of the slide. */ - function getSwiperSlideHtml(item, index) { + function getSwiperSlideHtml(item) { if (currentOptions.slides) { return getSwiperSlideHtmlFromSlide(item); } else { diff --git a/src/components/subtitleuploader/subtitleuploader.js b/src/components/subtitleuploader/subtitleuploader.js index 8d94a8ff39..76b595dbb9 100644 --- a/src/components/subtitleuploader/subtitleuploader.js +++ b/src/components/subtitleuploader/subtitleuploader.js @@ -108,7 +108,7 @@ function initEditor(page) { }); } -function showEditor(options, resolve, reject) { +function showEditor(options, resolve) { options = options || {}; currentItemId = options.itemId; currentServerId = options.serverId; diff --git a/src/components/syncPlay/core/Manager.js b/src/components/syncPlay/core/Manager.js index 18f4844bae..f792fee094 100644 --- a/src/components/syncPlay/core/Manager.js +++ b/src/components/syncPlay/core/Manager.js @@ -130,7 +130,7 @@ class Manager { /** * Called when the player changes. */ - onPlayerChange(newPlayer, newTarget, oldPlayer) { + onPlayerChange(newPlayer) { this.bindToPlayer(newPlayer); } @@ -228,9 +228,8 @@ class Manager { /** * Handles a playback command from the server. * @param {Object} cmd The playback command. - * @param {Object} apiClient The ApiClient. */ - processCommand(cmd, apiClient) { + processCommand(cmd) { if (cmd === null) return; if (typeof cmd.When === 'string') { @@ -277,9 +276,8 @@ class Manager { /** * Handles a group state change. * @param {Object} update The group state update. - * @param {Object} apiClient The ApiClient. */ - processStateChange(update, apiClient) { + processStateChange(update) { if (update === null || update.State === null || update.Reason === null) return; if (!this.isSyncPlayEnabled()) { diff --git a/src/components/syncPlay/core/players/GenericPlayer.js b/src/components/syncPlay/core/players/GenericPlayer.js index ac922387b8..f3f2e9715c 100644 --- a/src/components/syncPlay/core/players/GenericPlayer.js +++ b/src/components/syncPlay/core/players/GenericPlayer.js @@ -158,6 +158,7 @@ class GenericPlayer { * Sets the playback rate, if supported. * @param {number} value The playback rate. */ + // eslint-disable-next-line no-unused-vars setPlaybackRate(value) { // Do nothing. } @@ -196,6 +197,7 @@ class GenericPlayer { * Seeks the player to the specified position. * @param {number} positionTicks The new position. */ + // eslint-disable-next-line no-unused-vars localSeek(positionTicks) { } @@ -211,6 +213,7 @@ class GenericPlayer { * Sends a command to the player. * @param {Object} command The command. */ + // eslint-disable-next-line no-unused-vars localSendCommand(command) { } @@ -219,6 +222,7 @@ class GenericPlayer { * Starts playback. * @param {Object} options Playback data. */ + // eslint-disable-next-line no-unused-vars localPlay(options) { } @@ -227,6 +231,7 @@ class GenericPlayer { * Sets playing item from playlist. * @param {string} playlistItemId The item to play. */ + // eslint-disable-next-line no-unused-vars localSetCurrentPlaylistItem(playlistItemId) { } @@ -235,6 +240,7 @@ class GenericPlayer { * Removes items from playlist. * @param {Array} playlistItemIds The items to remove. */ + // eslint-disable-next-line no-unused-vars localRemoveFromPlaylist(playlistItemIds) { } @@ -244,6 +250,7 @@ class GenericPlayer { * @param {string} playlistItemId The item to move. * @param {number} newIndex The new position. */ + // eslint-disable-next-line no-unused-vars localMovePlaylistItem(playlistItemId, newIndex) { } @@ -252,6 +259,7 @@ class GenericPlayer { * Queues in the playlist. * @param {Object} options Queue data. */ + // eslint-disable-next-line no-unused-vars localQueue(options) { } @@ -260,6 +268,7 @@ class GenericPlayer { * Queues after the playing item in the playlist. * @param {Object} options Queue data. */ + // eslint-disable-next-line no-unused-vars localQueueNext(options) { } @@ -282,6 +291,7 @@ class GenericPlayer { * Sets repeat mode. * @param {string} value The repeat mode. */ + // eslint-disable-next-line no-unused-vars localSetRepeatMode(value) { } @@ -290,6 +300,7 @@ class GenericPlayer { * Sets shuffle mode. * @param {string} value The shuffle mode. */ + // eslint-disable-next-line no-unused-vars localSetQueueShuffleMode(value) { } diff --git a/src/components/syncPlay/ui/players/NoActivePlayer.js b/src/components/syncPlay/ui/players/NoActivePlayer.js index 48dfe953ba..92d58b2583 100644 --- a/src/components/syncPlay/ui/players/NoActivePlayer.js +++ b/src/components/syncPlay/ui/players/NoActivePlayer.js @@ -135,7 +135,7 @@ class NoActivePlayer extends SyncPlay.Players.GenericPlayer { /** * Overrides PlaybackManager's seek method. */ - seekRequest(positionTicks, player) { + seekRequest(positionTicks) { const controller = syncPlayManager.getController(); controller.seek(positionTicks); } @@ -148,19 +148,19 @@ class NoActivePlayer extends SyncPlay.Players.GenericPlayer { const controller = syncPlayManager.getController(); const playerWrapper = syncPlayManager.getPlayerWrapper(); - const defaultAction = (_command, _player) => { + const defaultAction = (_command) => { playerWrapper.localSendCommand(_command); }; - const ignoreCallback = (_command, _player) => { + const ignoreCallback = () => { // Do nothing. }; - const SetRepeatModeCallback = (_command, _player) => { + const SetRepeatModeCallback = (_command) => { controller.setRepeatMode(_command.Arguments.RepeatMode); }; - const SetShuffleQueueCallback = (_command, _player) => { + const SetShuffleQueueCallback = (_command) => { controller.setShuffleMode(_command.Arguments.ShuffleMode); }; @@ -242,7 +242,7 @@ class NoActivePlayer extends SyncPlay.Players.GenericPlayer { /** * Overrides PlaybackManager's setCurrentPlaylistItem method. */ - setCurrentPlaylistItemRequest(playlistItemId, player) { + setCurrentPlaylistItemRequest(playlistItemId) { const controller = syncPlayManager.getController(); controller.setCurrentPlaylistItem(playlistItemId); } @@ -250,7 +250,7 @@ class NoActivePlayer extends SyncPlay.Players.GenericPlayer { /** * Overrides PlaybackManager's removeFromPlaylist method. */ - removeFromPlaylistRequest(playlistItemIds, player) { + removeFromPlaylistRequest(playlistItemIds) { const controller = syncPlayManager.getController(); controller.removeFromPlaylist(playlistItemIds); } @@ -258,7 +258,7 @@ class NoActivePlayer extends SyncPlay.Players.GenericPlayer { /** * Overrides PlaybackManager's movePlaylistItem method. */ - movePlaylistItemRequest(playlistItemId, newIndex, player) { + movePlaylistItemRequest(playlistItemId, newIndex) { const controller = syncPlayManager.getController(); controller.movePlaylistItem(playlistItemId, newIndex); } @@ -266,7 +266,7 @@ class NoActivePlayer extends SyncPlay.Players.GenericPlayer { /** * Overrides PlaybackManager's queue method. */ - queueRequest(options, player) { + queueRequest(options) { const controller = syncPlayManager.getController(); controller.queue(options); } @@ -274,7 +274,7 @@ class NoActivePlayer extends SyncPlay.Players.GenericPlayer { /** * Overrides PlaybackManager's queueNext method. */ - queueNextRequest(options, player) { + queueNextRequest(options) { const controller = syncPlayManager.getController(); controller.queueNext(options); } @@ -282,7 +282,7 @@ class NoActivePlayer extends SyncPlay.Players.GenericPlayer { /** * Overrides PlaybackManager's nextTrack method. */ - nextTrackRequest(player) { + nextTrackRequest() { const controller = syncPlayManager.getController(); controller.nextItem(); } @@ -290,7 +290,7 @@ class NoActivePlayer extends SyncPlay.Players.GenericPlayer { /** * Overrides PlaybackManager's previousTrack method. */ - previousTrackRequest(player) { + previousTrackRequest() { const controller = syncPlayManager.getController(); controller.previousItem(); } @@ -298,7 +298,7 @@ class NoActivePlayer extends SyncPlay.Players.GenericPlayer { /** * Overrides PlaybackManager's setRepeatMode method. */ - setRepeatModeRequest(mode, player) { + setRepeatModeRequest(mode) { const controller = syncPlayManager.getController(); controller.setRepeatMode(mode); } @@ -306,7 +306,7 @@ class NoActivePlayer extends SyncPlay.Players.GenericPlayer { /** * Overrides PlaybackManager's setQueueShuffleMode method. */ - setQueueShuffleModeRequest(mode, player) { + setQueueShuffleModeRequest(mode) { const controller = syncPlayManager.getController(); controller.setShuffleMode(mode); } @@ -314,7 +314,7 @@ class NoActivePlayer extends SyncPlay.Players.GenericPlayer { /** * Overrides PlaybackManager's toggleQueueShuffleMode method. */ - toggleQueueShuffleModeRequest(player) { + toggleQueueShuffleModeRequest() { const controller = syncPlayManager.getController(); controller.toggleShuffleMode(); } diff --git a/src/components/syncPlay/ui/players/QueueManager.js b/src/components/syncPlay/ui/players/QueueManager.js index bcc6c1c2b3..a588109158 100644 --- a/src/components/syncPlay/ui/players/QueueManager.js +++ b/src/components/syncPlay/ui/players/QueueManager.js @@ -21,14 +21,14 @@ class QueueManager { /** * Placeholder for original PlayQueueManager method. */ - setPlaylist(items) { + setPlaylist() { // Do nothing. } /** * Placeholder for original PlayQueueManager method. */ - queue(items) { + queue() { // Do nothing. } @@ -49,14 +49,14 @@ class QueueManager { /** * Placeholder for original PlayQueueManager method. */ - clearPlaylist(clearCurrentItem = false) { + clearPlaylist() { // Do nothing. } /** * Placeholder for original PlayQueueManager method. */ - queueNext(items) { + queueNext() { // Do nothing. } @@ -90,28 +90,28 @@ class QueueManager { /** * Placeholder for original PlayQueueManager method. */ - setPlaylistState(playlistItemId, playlistIndex) { + setPlaylistState() { // Do nothing. } /** * Placeholder for original PlayQueueManager method. */ - setPlaylistIndex(playlistIndex) { + setPlaylistIndex() { // Do nothing. } /** * Placeholder for original PlayQueueManager method. */ - removeFromPlaylist(playlistItemIds) { + removeFromPlaylist() { // Do nothing. } /** * Placeholder for original PlayQueueManager method. */ - movePlaylistItem(playlistItemId, newIndex) { + movePlaylistItem() { // Do nothing. return { result: 'noop' @@ -128,7 +128,7 @@ class QueueManager { /** * Placeholder for original PlayQueueManager method. */ - setRepeatMode(value) { + setRepeatMode() { // Do nothing. } @@ -142,7 +142,7 @@ class QueueManager { /** * Placeholder for original PlayQueueManager method. */ - setShuffleMode(value) { + setShuffleMode() { // Do nothing. } diff --git a/src/components/tabbedview/tabbedview.js b/src/components/tabbedview/tabbedview.js index efc9fb37c5..833b42cc02 100644 --- a/src/components/tabbedview/tabbedview.js +++ b/src/components/tabbedview/tabbedview.js @@ -4,7 +4,7 @@ import layoutManager from '../layoutManager'; import '../../elements/emby-tabs/emby-tabs'; import { appRouter } from '../appRouter'; -function onViewDestroy(e) { +function onViewDestroy() { const tabControllers = this.tabControllers; if (tabControllers) { @@ -78,7 +78,7 @@ class TabbedView { view.addEventListener('viewbeforehide', this.onPause.bind(this)); - view.addEventListener('viewbeforeshow', function (e) { + view.addEventListener('viewbeforeshow', function () { mainTabsManager.setTabs(view, currentTabIndex, self.getTabs, getTabContainers, onBeforeTabChange, onTabChange, false); }); @@ -89,7 +89,7 @@ class TabbedView { view.addEventListener('viewdestroy', onViewDestroy.bind(this)); } - onResume(options) { + onResume() { this.setTitle(); backdrop.clearBackdrop(); diff --git a/src/components/tunerPicker.js b/src/components/tunerPicker.js index d652f2ad3b..74b1a767bb 100644 --- a/src/components/tunerPicker.js +++ b/src/components/tunerPicker.js @@ -106,7 +106,7 @@ function renderDevices(view, devices) { } } -function discoverDevices(view, apiClient) { +function discoverDevices(view) { loading.show(); view.querySelector('.loadingContent').classList.remove('hide'); return ApiClient.getJSON(ApiClient.getUrl('LiveTv/Tuners/Discvover', { diff --git a/src/components/tvproviders/schedulesdirect.js b/src/components/tvproviders/schedulesdirect.js index f005492493..1d0e8a49f2 100644 --- a/src/components/tvproviders/schedulesdirect.js +++ b/src/components/tvproviders/schedulesdirect.js @@ -149,7 +149,7 @@ export default function (page, providerId, options) { }), data: JSON.stringify(info), contentType: 'application/json' - }).then(function (result) { + }).then(function () { loading.hide(); if (options.showConfirmation) { @@ -190,7 +190,7 @@ export default function (page, providerId, options) { } loading.hide(); - }, function (result) { + }, function () { Dashboard.alert({ message: globalize.translate('ErrorGettingTvLineups') }); diff --git a/src/components/tvproviders/xmltv.js b/src/components/tvproviders/xmltv.js index 1b7c7c7063..853f9975cb 100644 --- a/src/components/tvproviders/xmltv.js +++ b/src/components/tvproviders/xmltv.js @@ -88,7 +88,7 @@ export default function (page, providerId, options) { }), data: JSON.stringify(info), contentType: 'application/json' - }).then(function (result) { + }).then(function () { loading.hide(); if (options.showConfirmation !== false) { diff --git a/src/controllers/dashboard/dashboard.js b/src/controllers/dashboard/dashboard.js index ae0061bc12..16a5b6a40d 100644 --- a/src/controllers/dashboard/dashboard.js +++ b/src/controllers/dashboard/dashboard.js @@ -218,7 +218,7 @@ import confirm from '../../components/confirm/confirm'; }); } - function renderInfo(view, sessions, forceUpdate) { + function renderInfo(view, sessions) { sessions = filterSessions(sessions); renderActiveConnections(view, sessions); loading.hide(); @@ -730,7 +730,7 @@ import confirm from '../../components/confirm/confirm'; }); } }; - export default function (view, params) { + export default function (view) { function onRestartRequired(evt, apiClient) { console.debug('onRestartRequired not implemented', evt, apiClient); } diff --git a/src/controllers/dashboard/devices/device.js b/src/controllers/dashboard/devices/device.js index 18404d605f..ab9b5a664c 100644 --- a/src/controllers/dashboard/devices/device.js +++ b/src/controllers/dashboard/devices/device.js @@ -48,7 +48,7 @@ import Dashboard from '../../../scripts/clientUtils'; return false; } - export default function (view, params) { + export default function (view) { view.querySelector('form').addEventListener('submit', onSubmit); view.addEventListener('viewshow', loadData); } diff --git a/src/controllers/dashboard/devices/devices.js b/src/controllers/dashboard/devices/devices.js index 7042c8f8b7..58c1406241 100644 --- a/src/controllers/dashboard/devices/devices.js +++ b/src/controllers/dashboard/devices/devices.js @@ -149,7 +149,7 @@ import confirm from '../../../components/confirm/confirm'; } const canEdit = ApiClient.isMinServerVersion('3.4.1.31'); - export default function (view, params) { + export default function (view) { view.querySelector('.devicesList').addEventListener('click', function (e) { const btnDeviceMenu = dom.parentWithClass(e.target, 'btnDeviceMenu'); diff --git a/src/controllers/dashboard/encodingsettings.js b/src/controllers/dashboard/encodingsettings.js index 83c965880b..88f1e975cd 100644 --- a/src/controllers/dashboard/encodingsettings.js +++ b/src/controllers/dashboard/encodingsettings.js @@ -48,13 +48,13 @@ import alert from '../../components/alert'; loading.hide(); } - function onSaveEncodingPathFailure(response) { + function onSaveEncodingPathFailure() { loading.hide(); alert(globalize.translate('FFmpegSavePathNotFound')); } function updateEncoder(form) { - return ApiClient.getSystemInfo().then(function (systemInfo) { + return ApiClient.getSystemInfo().then(function () { return ApiClient.ajax({ url: ApiClient.getUrl('System/MediaEncoder/Path'), type: 'POST', diff --git a/src/controllers/dashboard/general.js b/src/controllers/dashboard/general.js index a780f35e19..d919dbf119 100644 --- a/src/controllers/dashboard/general.js +++ b/src/controllers/dashboard/general.js @@ -19,7 +19,6 @@ import alert from '../../components/alert'; $('#selectLocalizationLanguage', page).html(languageOptions.map(function (language) { return ''; })).val(config.UICulture); - currentLanguage = config.UICulture; loading.hide(); } @@ -34,16 +33,11 @@ import alert from '../../components/alert'; config.CachePath = form.querySelector('#txtCachePath').value; config.MetadataPath = $('#txtMetadataPath', form).val(); config.MetadataNetworkPath = $('#txtMetadataNetworkPath', form).val(); - let requiresReload = config.UICulture !== currentLanguage; ApiClient.updateServerConfiguration(config).then(function() { ApiClient.getNamedConfiguration(brandingConfigKey).then(function(brandingConfig) { brandingConfig.LoginDisclaimer = form.querySelector('#txtLoginDisclaimer').value; brandingConfig.CustomCss = form.querySelector('#txtCustomCss').value; - if (currentBrandingOptions && brandingConfig.CustomCss !== currentBrandingOptions.CustomCss) { - requiresReload = true; - } - ApiClient.updateNamedConfiguration(brandingConfigKey, brandingConfig).then(function () { Dashboard.processServerConfigurationUpdateResult(); }); @@ -56,10 +50,8 @@ import alert from '../../components/alert'; return false; } - let currentBrandingOptions; - let currentLanguage; const brandingConfigKey = 'branding'; - export default function (view, params) { + export default function (view) { $('#btnSelectCachePath', view).on('click.selectDirectory', function () { import('../../components/directorybrowser/directorybrowser').then(({default: directoryBrowser}) => { const picker = new directoryBrowser(); @@ -110,7 +102,6 @@ import alert from '../../components/alert'; loadPage(view, responses[0], responses[1], responses[2]); }); ApiClient.getNamedConfiguration(brandingConfigKey).then(function (config) { - currentBrandingOptions = config; view.querySelector('#txtLoginDisclaimer').value = config.LoginDisclaimer || ''; view.querySelector('#txtCustomCss').value = config.CustomCss || ''; }); diff --git a/src/controllers/dashboard/librarydisplay.js b/src/controllers/dashboard/librarydisplay.js index 75abfe308f..3eb56004e0 100644 --- a/src/controllers/dashboard/librarydisplay.js +++ b/src/controllers/dashboard/librarydisplay.js @@ -23,7 +23,7 @@ import Dashboard from '../../scripts/clientUtils'; }]; } - export default function(view, params) { + export default function(view) { function loadData() { ApiClient.getServerConfiguration().then(function(config) { view.querySelector('.chkFolderView').checked = config.EnableFolderView; diff --git a/src/controllers/dashboard/logs.js b/src/controllers/dashboard/logs.js index dac9a6eff9..2f9882c228 100644 --- a/src/controllers/dashboard/logs.js +++ b/src/controllers/dashboard/logs.js @@ -6,7 +6,7 @@ import '../../assets/css/flexstyles.scss'; /* eslint-disable indent */ - export default function(view, params) { + export default function(view) { view.addEventListener('viewbeforeshow', function() { loading.show(); const apiClient = ApiClient; diff --git a/src/controllers/dashboard/metadatanfo.js b/src/controllers/dashboard/metadatanfo.js index a8500f2735..311ff54567 100644 --- a/src/controllers/dashboard/metadatanfo.js +++ b/src/controllers/dashboard/metadatanfo.js @@ -37,7 +37,7 @@ import alert from '../../components/alert'; return false; } - function showConfirmMessage(config) { + function showConfirmMessage() { const msg = []; msg.push(globalize.translate('MetadataSettingChangeHelp')); alert({ diff --git a/src/controllers/dashboard/networking.js b/src/controllers/dashboard/networking.js index b314e1ea8b..5cfab50938 100644 --- a/src/controllers/dashboard/networking.js +++ b/src/controllers/dashboard/networking.js @@ -131,7 +131,7 @@ import alert from '../../components/alert'; } } - export default function (view, params) { + export default function (view) { function loadPage(page, config) { page.querySelector('#txtPortNumber').value = config.HttpServerPortNumber; page.querySelector('#txtPublicPort').value = config.PublicPort; @@ -198,7 +198,7 @@ import alert from '../../components/alert'; }); }); view.querySelector('.dashboardHostingForm').addEventListener('submit', onSubmit); - view.addEventListener('viewshow', function (e) { + view.addEventListener('viewshow', function () { loading.show(); ApiClient.getNamedConfiguration('network').then(function (config) { loadPage(view, config); diff --git a/src/controllers/dashboard/notifications/notification/index.js b/src/controllers/dashboard/notifications/notification/index.js index eda0004420..1bd5100c96 100644 --- a/src/controllers/dashboard/notifications/notification/index.js +++ b/src/controllers/dashboard/notifications/notification/index.js @@ -91,7 +91,7 @@ function save(page) { }).map(function (c) { return c.getAttribute('data-itemid'); }); - ApiClient.updateNamedConfiguration(notificationsConfigurationKey, notificationOptions).then(function (r) { + ApiClient.updateNamedConfiguration(notificationsConfigurationKey, notificationOptions).then(function () { Dashboard.processServerConfigurationUpdateResult(); Dashboard.navigate('notificationsettings.html'); }); diff --git a/src/controllers/dashboard/notifications/notifications/index.js b/src/controllers/dashboard/notifications/notifications/index.js index fc2eb0c2dd..befb64c383 100644 --- a/src/controllers/dashboard/notifications/notifications/index.js +++ b/src/controllers/dashboard/notifications/notifications/index.js @@ -54,7 +54,7 @@ function reload(page) { }); } -export default function (view, params) { +export default function (view) { view.addEventListener('viewshow', function () { reload(view); }); diff --git a/src/controllers/dashboard/plugins/repositories/index.js b/src/controllers/dashboard/plugins/repositories/index.js index dfe11c0c99..0b761df169 100644 --- a/src/controllers/dashboard/plugins/repositories/index.js +++ b/src/controllers/dashboard/plugins/repositories/index.js @@ -19,7 +19,7 @@ function reloadList(page) { noneElement: page.querySelector('#none'), repositories: repositories }); - }).catch(error => { + }).catch(() => { console.error('error loading repositories'); page.querySelector('#none').classList.remove('hide'); loading.hide(); @@ -33,9 +33,9 @@ function saveList(page) { url: ApiClient.getUrl('Repositories'), data: JSON.stringify(repositories), contentType: 'application/json' - }).then(response => { + }).then(() => { reloadList(page); - }).catch(error => { + }).catch(() => { console.error('error saving repositories'); loading.hide(); }); @@ -90,7 +90,7 @@ function getTabs() { }]; } -export default function(view, params) { +export default function(view) { view.addEventListener('viewshow', function () { libraryMenu.setTabs('plugins', 2, getTabs); reloadList(this); diff --git a/src/controllers/dashboard/scheduledtasks/scheduledtask.js b/src/controllers/dashboard/scheduledtasks/scheduledtask.js index 149b1d20a6..db6847dcd3 100644 --- a/src/controllers/dashboard/scheduledtasks/scheduledtask.js +++ b/src/controllers/dashboard/scheduledtasks/scheduledtask.js @@ -207,7 +207,7 @@ import confirm from '../../../components/confirm/confirm'; return trigger; } }; - export default function (view, params) { + export default function (view) { function onSubmit(e) { loading.show(); const id = getParameterByName('id'); diff --git a/src/controllers/dashboard/scheduledtasks/scheduledtasks.js b/src/controllers/dashboard/scheduledtasks/scheduledtasks.js index 8792c4f5b0..a7139ca02e 100644 --- a/src/controllers/dashboard/scheduledtasks/scheduledtasks.js +++ b/src/controllers/dashboard/scheduledtasks/scheduledtasks.js @@ -123,7 +123,7 @@ import '../../../elements/emby-button/emby-button'; $(elem).parents('.listItem')[0].setAttribute('data-status', state); } - export default function(view, params) { + export default function(view) { function updateTasks(tasks) { for (let i = 0; i < tasks.length; i++) { const task = tasks[i]; diff --git a/src/controllers/dashboard/users/useredit.js b/src/controllers/dashboard/users/useredit.js index 6466827021..cbf8c3f4b5 100644 --- a/src/controllers/dashboard/users/useredit.js +++ b/src/controllers/dashboard/users/useredit.js @@ -108,7 +108,7 @@ import toast from '../../../components/toast/toast'; loading.hide(); } - function onSaveComplete(page, user) { + function onSaveComplete() { Dashboard.navigate('userprofiles.html'); loading.hide(); toast(globalize.translate('SettingsSaved')); diff --git a/src/controllers/dashboard/users/userlibraryaccess.js b/src/controllers/dashboard/users/userlibraryaccess.js index d3407de5b6..da569a5e79 100644 --- a/src/controllers/dashboard/users/userlibraryaccess.js +++ b/src/controllers/dashboard/users/userlibraryaccess.js @@ -91,7 +91,7 @@ import toast from '../../../components/toast/toast'; loading.hide(); } - function onSaveComplete(page) { + function onSaveComplete() { loading.hide(); toast(globalize.translate('SettingsSaved')); } diff --git a/src/controllers/dashboard/users/usernew.js b/src/controllers/dashboard/users/usernew.js index 95138a5125..406bf55c86 100644 --- a/src/controllers/dashboard/users/usernew.js +++ b/src/controllers/dashboard/users/usernew.js @@ -89,7 +89,7 @@ import toast from '../../../components/toast/toast'; ApiClient.updateUserPolicy(user.Id, user.Policy).then(function () { Dashboard.navigate('useredit.html?userId=' + user.Id); }); - }, function (response) { + }, function () { toast(globalize.translate('ErrorDefault')); loading.hide(); }); diff --git a/src/controllers/dashboard/users/userparentalcontrol.js b/src/controllers/dashboard/users/userparentalcontrol.js index 262e24b289..d455861c14 100644 --- a/src/controllers/dashboard/users/userparentalcontrol.js +++ b/src/controllers/dashboard/users/userparentalcontrol.js @@ -161,7 +161,7 @@ import toast from '../../../components/toast/toast'; }); } - function onSaveComplete(page) { + function onSaveComplete() { loading.hide(); toast(globalize.translate('SettingsSaved')); } diff --git a/src/controllers/dashboard/users/userprofilespage.js b/src/controllers/dashboard/users/userprofilespage.js index 91499a40a8..0b01907952 100644 --- a/src/controllers/dashboard/users/userprofilespage.js +++ b/src/controllers/dashboard/users/userprofilespage.js @@ -82,7 +82,7 @@ import cardBuilder from '../../../components/cardbuilder/cardBuilder'; }); } - function getUserHtml(user, addConnectIndicator) { + function getUserHtml(user) { let html = ''; let cssClass = 'card squareCard scalableCard squareCard-scalable'; diff --git a/src/controllers/edititemmetadata.js b/src/controllers/edititemmetadata.js index a371e6161a..a5ac202cc7 100644 --- a/src/controllers/edititemmetadata.js +++ b/src/controllers/edititemmetadata.js @@ -14,7 +14,7 @@ function reload(context, itemId) { } } -export default function (view, params) { +export default function (view) { view.addEventListener('viewshow', function () { reload(this, MetadataEditor.getCurrentItemId()); }); diff --git a/src/controllers/list.js b/src/controllers/list.js index 6305a95a26..d055f9e747 100644 --- a/src/controllers/list.js +++ b/src/controllers/list.js @@ -817,7 +817,7 @@ class ItemsView { itemsContainer: self.itemsContainer }); }); - view.addEventListener('viewhide', function (e) { + view.addEventListener('viewhide', function () { const itemsContainer = self.itemsContainer; if (itemsContainer) { diff --git a/src/controllers/livetv/livetvchannels.js b/src/controllers/livetv/livetvchannels.js index ebf17def54..cd7b50dd44 100644 --- a/src/controllers/livetv/livetvchannels.js +++ b/src/controllers/livetv/livetvchannels.js @@ -104,7 +104,7 @@ export default function (view, params, tabContent) { }); } - function reloadItems(context, save) { + function reloadItems(context) { loading.show(); isLoading = true; const query = getQuery(); diff --git a/src/controllers/livetv/livetvrecordings.js b/src/controllers/livetv/livetvrecordings.js index 8ca3530d10..508e8b44a7 100644 --- a/src/controllers/livetv/livetvrecordings.js +++ b/src/controllers/livetv/livetvrecordings.js @@ -64,7 +64,7 @@ function renderRecordingFolders(context, promise) { }); } -function onMoreClick(e) { +function onMoreClick() { const type = this.getAttribute('data-type'); const serverId = ApiClient.serverId(); diff --git a/src/controllers/livetvstatus.js b/src/controllers/livetvstatus.js index bcf9ba577e..5d49e57c36 100644 --- a/src/controllers/livetvstatus.js +++ b/src/controllers/livetvstatus.js @@ -246,7 +246,7 @@ function addProvider(button) { }); } -function addDevice(button) { +function addDevice() { Dashboard.navigate('livetvtuner.html'); } diff --git a/src/controllers/livetvtuner.js b/src/controllers/livetvtuner.js index 65933b03fb..261fbae345 100644 --- a/src/controllers/livetvtuner.js +++ b/src/controllers/livetvtuner.js @@ -91,7 +91,7 @@ function submitForm(page) { url: ApiClient.getUrl('LiveTv/TunerHosts'), data: JSON.stringify(info), contentType: 'application/json' - }).then(function (result) { + }).then(function () { Dashboard.processServerConfigurationUpdateResult(); Dashboard.navigate('livetvstatus.html'); }, function () { diff --git a/src/controllers/movies/moviesrecommended.js b/src/controllers/movies/moviesrecommended.js index 7de4cb4559..918698b860 100644 --- a/src/controllers/movies/moviesrecommended.js +++ b/src/controllers/movies/moviesrecommended.js @@ -155,7 +155,7 @@ import Dashboard from '../../scripts/clientUtils'; return html; } - function loadSuggestions(page, userId, parentId) { + function loadSuggestions(page, userId) { const screenWidth = dom.getWindowSize().innerWidth; const url = ApiClient.getUrl('Movies/Recommendations', { userId: userId, @@ -389,7 +389,7 @@ import Dashboard from '../../scripts/clientUtils'; const tabControllers = []; let renderedTabs = []; - view.addEventListener('viewshow', function (e) { + view.addEventListener('viewshow', function () { initTabs(); if (!view.getAttribute('data-title')) { const parentId = params.topParentId; diff --git a/src/controllers/music/musicalbums.js b/src/controllers/music/musicalbums.js index fe885b09a3..b9c8161b6f 100644 --- a/src/controllers/music/musicalbums.js +++ b/src/controllers/music/musicalbums.js @@ -185,7 +185,7 @@ import '../../elements/emby-itemscontainer/emby-itemscontainer'; }); }; - const updateFilterControls = (tabContent) => { + const updateFilterControls = () => { const query = getQuery(); if (this.alphaPicker) { diff --git a/src/controllers/music/musicrecommended.js b/src/controllers/music/musicrecommended.js index fdfa2cf6da..e08bece779 100644 --- a/src/controllers/music/musicrecommended.js +++ b/src/controllers/music/musicrecommended.js @@ -373,7 +373,7 @@ import Dashboard from '../../scripts/clientUtils'; const tabControllers = []; const renderedTabs = []; - view.addEventListener('viewshow', function (e) { + view.addEventListener('viewshow', function () { initTabs(); if (!view.getAttribute('data-title')) { const parentId = params.topParentId; @@ -391,10 +391,10 @@ import Dashboard from '../../scripts/clientUtils'; inputManager.on(window, onInputCommand); }); - view.addEventListener('viewbeforehide', function (e) { + view.addEventListener('viewbeforehide', function () { inputManager.off(window, onInputCommand); }); - view.addEventListener('viewdestroy', function (e) { + view.addEventListener('viewdestroy', function () { tabControllers.forEach(function (t) { if (t.destroy) { t.destroy(); diff --git a/src/controllers/playback/queue/index.js b/src/controllers/playback/queue/index.js index 8bece4eb3f..cf39aa145b 100644 --- a/src/controllers/playback/queue/index.js +++ b/src/controllers/playback/queue/index.js @@ -2,17 +2,17 @@ import remotecontrolFactory from '../../../components/remotecontrol/remotecontro import libraryMenu from '../../../scripts/libraryMenu'; import '../../../elements/emby-button/emby-button'; -export default function (view, params) { +export default function (view) { const remoteControl = new remotecontrolFactory(); remoteControl.init(view, view.querySelector('.remoteControlContent')); - view.addEventListener('viewshow', function (e) { + view.addEventListener('viewshow', function () { libraryMenu.setTransparentMenu(true); if (remoteControl) { remoteControl.onShow(); } }); - view.addEventListener('viewbeforehide', function (e) { + view.addEventListener('viewbeforehide', function () { libraryMenu.setTransparentMenu(false); if (remoteControl) { diff --git a/src/controllers/playback/video/index.js b/src/controllers/playback/video/index.js index d74bc103e7..d981153b7d 100644 --- a/src/controllers/playback/video/index.js +++ b/src/controllers/playback/video/index.js @@ -28,7 +28,7 @@ import { appRouter } from '../../../components/appRouter'; return document.querySelector('.dialogContainer .dialog.opened'); } - export default function (view, params) { + export default function (view) { function getDisplayItem(item) { if (item.Type === 'TvChannel') { const apiClient = ServerConnections.getApiClient(item.ServerId); @@ -431,13 +431,13 @@ import { appRouter } from '../../../components/appRouter'; } } - function onPlayPauseStateChanged(e) { + function onPlayPauseStateChanged() { if (isEnabled) { updatePlayPauseState(this.paused()); } } - function onVolumeChanged(e) { + function onVolumeChanged() { if (isEnabled) { const player = this; updatePlayerVolumeState(player, player.isMuted(), player.getVolume()); @@ -472,7 +472,7 @@ import { appRouter } from '../../../components/appRouter'; } } - function onMediaStreamsChanged(e) { + function onMediaStreamsChanged() { const player = this; const state = playbackManager.getPlayerState(player); onStateChanged.call(player, { @@ -534,7 +534,7 @@ import { appRouter } from '../../../components/appRouter'; } } - function onTimeUpdate(e) { + function onTimeUpdate() { // Test for 'currentItem' is required for Firefox since its player spams 'timeupdate' events even being at breakpoint if (isEnabled && currentItem) { const now = new Date().getTime(); @@ -794,7 +794,7 @@ import { appRouter } from '../../../components/appRouter'; } } - function updatePlaylist(player) { + function updatePlaylist() { const btnPreviousTrack = view.querySelector('.btnPreviousTrack'); const btnNextTrack = view.querySelector('.btnNextTrack'); btnPreviousTrack.classList.remove('hide'); @@ -818,7 +818,7 @@ import { appRouter } from '../../../components/appRouter'; elem.innerHTML = html; } - function onSettingsButtonClick(e) { + function onSettingsButtonClick() { const btn = this; import('../../../components/playback/playersettingsmenu').then((playerSettingsMenu) => { @@ -1261,11 +1261,11 @@ import { appRouter } from '../../../components/appRouter'; nowPlayingPositionSlider.classList.add('focusable'); } - view.addEventListener('viewbeforeshow', function (e) { + view.addEventListener('viewbeforeshow', function () { headerElement.classList.add('osdHeader'); appRouter.setTransparency('full'); }); - view.addEventListener('viewshow', function (e) { + view.addEventListener('viewshow', function () { try { Events.on(playbackManager, 'playerchange', onPlayerChange); bindToPlayer(playbackManager.getCurrentPlayer()); diff --git a/src/controllers/session/addServer/index.js b/src/controllers/session/addServer/index.js index aabfdbcca8..3b11caa8e9 100644 --- a/src/controllers/session/addServer/index.js +++ b/src/controllers/session/addServer/index.js @@ -49,7 +49,7 @@ import ServerConnections from '../../../components/ServerConnections'; }); } - export default function(view, params) { + export default function(view) { view.querySelector('.addServerForm').addEventListener('submit', onServerSubmit); view.querySelector('.btnCancel').addEventListener('click', goBack); diff --git a/src/controllers/session/forgotPassword/index.js b/src/controllers/session/forgotPassword/index.js index 203605b8bb..0b165b65f5 100644 --- a/src/controllers/session/forgotPassword/index.js +++ b/src/controllers/session/forgotPassword/index.js @@ -36,7 +36,7 @@ import Dashboard from '../../../scripts/clientUtils'; } } - export default function (view, params) { + export default function (view) { function onSubmit(e) { ApiClient.ajax({ type: 'POST', diff --git a/src/controllers/session/login/index.js b/src/controllers/session/login/index.js index c87d2dd710..38135dde53 100644 --- a/src/controllers/session/login/index.js +++ b/src/controllers/session/login/index.js @@ -250,7 +250,7 @@ import cardBuilder from '../../../components/cardbuilder/cardBuilder'; Dashboard.selectServer(); }); - view.addEventListener('viewshow', function (e) { + view.addEventListener('viewshow', function () { loading.show(); libraryMenu.setTransparentMenu(true); @@ -285,7 +285,7 @@ import cardBuilder from '../../../components/cardbuilder/cardBuilder'; view.querySelector('.disclaimer').textContent = options.LoginDisclaimer || ''; }); }); - view.addEventListener('viewhide', function (e) { + view.addEventListener('viewhide', function () { libraryMenu.setTransparentMenu(false); }); } diff --git a/src/controllers/session/resetPassword/index.js b/src/controllers/session/resetPassword/index.js index cc84d76fae..9697e386a7 100644 --- a/src/controllers/session/resetPassword/index.js +++ b/src/controllers/session/resetPassword/index.js @@ -24,7 +24,7 @@ import Dashboard from '../../../scripts/clientUtils'; }); } - export default function (view, params) { + export default function (view) { function onSubmit(e) { ApiClient.ajax({ type: 'POST', diff --git a/src/controllers/shows/tvrecommended.js b/src/controllers/shows/tvrecommended.js index 8d8f0fc82d..82baff8eb5 100644 --- a/src/controllers/shows/tvrecommended.js +++ b/src/controllers/shows/tvrecommended.js @@ -354,7 +354,7 @@ import autoFocuser from '../../components/autoFocuser'; const tabControllers = []; let renderedTabs = []; - view.addEventListener('viewshow', function (e) { + view.addEventListener('viewshow', function () { initTabs(); if (!view.getAttribute('data-title')) { const parentId = params.topParentId; @@ -374,12 +374,12 @@ import autoFocuser from '../../components/autoFocuser'; Events.on(ApiClient, 'message', onWebSocketMessage); inputManager.on(window, onInputCommand); }); - view.addEventListener('viewbeforehide', function (e) { + view.addEventListener('viewbeforehide', function () { inputManager.off(window, onInputCommand); Events.off(playbackManager, 'playbackstop', onPlaybackStop); Events.off(ApiClient, 'message', onWebSocketMessage); }); - view.addEventListener('viewdestroy', function (e) { + view.addEventListener('viewdestroy', function () { tabControllers.forEach(function (t) { if (t.destroy) { t.destroy(); diff --git a/src/controllers/user/display/index.js b/src/controllers/user/display/index.js index 322da73772..5d34539c35 100644 --- a/src/controllers/user/display/index.js +++ b/src/controllers/user/display/index.js @@ -9,7 +9,6 @@ import autoFocuser from '../../../components/autoFocuser'; export default function (view, params) { let settingsInstance; - let hasChanges; const userId = params.userId || ApiClient.getCurrentUserId(); const currentSettings = userId === ApiClient.getCurrentUserId() ? userSettings : new UserSettings(); @@ -30,10 +29,6 @@ import autoFocuser from '../../../components/autoFocuser'; } }); - view.addEventListener('change', function () { - hasChanges = true; - }); - view.addEventListener('viewdestroy', function () { if (settingsInstance) { settingsInstance.destroy(); diff --git a/src/controllers/user/home/index.js b/src/controllers/user/home/index.js index 37a2374b0d..45b0fd2f80 100644 --- a/src/controllers/user/home/index.js +++ b/src/controllers/user/home/index.js @@ -10,7 +10,6 @@ import '../../../components/listview/listview.scss'; export default function (view, params) { let homescreenSettingsInstance; - let hasChanges; const userId = params.userId || ApiClient.getCurrentUserId(); const currentSettings = userId === ApiClient.getCurrentUserId() ? userSettings : new UserSettings(); @@ -31,10 +30,6 @@ import '../../../components/listview/listview.scss'; } }); - view.addEventListener('change', function () { - hasChanges = true; - }); - view.addEventListener('viewdestroy', function () { if (homescreenSettingsInstance) { homescreenSettingsInstance.destroy(); diff --git a/src/controllers/user/playback/index.js b/src/controllers/user/playback/index.js index 793208cb6a..f0b4be6a25 100644 --- a/src/controllers/user/playback/index.js +++ b/src/controllers/user/playback/index.js @@ -11,7 +11,6 @@ import '../../../components/listview/listview.scss'; export default function (view, params) { let settingsInstance; - let hasChanges; const userId = params.userId || ApiClient.getCurrentUserId(); const currentSettings = userId === ApiClient.getCurrentUserId() ? userSettings : new UserSettings(); @@ -32,10 +31,6 @@ import '../../../components/listview/listview.scss'; } }); - view.addEventListener('change', function () { - hasChanges = true; - }); - view.addEventListener('viewdestroy', function () { if (settingsInstance) { settingsInstance.destroy(); diff --git a/src/controllers/user/profile/index.js b/src/controllers/user/profile/index.js index 4398de36e2..750bacab90 100644 --- a/src/controllers/user/profile/index.js +++ b/src/controllers/user/profile/index.js @@ -54,7 +54,7 @@ function onFileReaderError(evt) { } } -function onFileReaderAbort(evt) { +function onFileReaderAbort() { loading.hide(); toast(globalize.translate('FileReadCancelled')); } @@ -95,7 +95,7 @@ export default function (view, params) { }); }); }); - view.querySelector('#btnAddImage').addEventListener('click', function (evt) { + view.querySelector('#btnAddImage').addEventListener('click', function () { view.querySelector('#uploadImage').click(); }); view.querySelector('#uploadImage').addEventListener('change', function (evt) { diff --git a/src/controllers/user/subtitles/index.js b/src/controllers/user/subtitles/index.js index deb86535df..87676df65f 100644 --- a/src/controllers/user/subtitles/index.js +++ b/src/controllers/user/subtitles/index.js @@ -9,7 +9,6 @@ import autoFocuser from '../../../components/autoFocuser'; export default function (view, params) { let subtitleSettingsInstance; - let hasChanges; const userId = params.userId || ApiClient.getCurrentUserId(); const currentSettings = userId === ApiClient.getCurrentUserId() ? userSettings : new UserSettings(); @@ -30,10 +29,6 @@ import autoFocuser from '../../../components/autoFocuser'; } }); - view.addEventListener('change', function () { - hasChanges = true; - }); - view.addEventListener('viewdestroy', function () { if (subtitleSettingsInstance) { subtitleSettingsInstance.destroy(); diff --git a/src/controllers/wizard/finish/index.js b/src/controllers/wizard/finish/index.js index 446d01e61c..e60653fd73 100644 --- a/src/controllers/wizard/finish/index.js +++ b/src/controllers/wizard/finish/index.js @@ -11,6 +11,6 @@ function onFinish() { }); } -export default function (view, params) { +export default function (view) { view.querySelector('.btnWizardNext').addEventListener('click', onFinish); } diff --git a/src/controllers/wizard/remote/index.js b/src/controllers/wizard/remote/index.js index c5689e73bb..2b07bf89d1 100644 --- a/src/controllers/wizard/remote/index.js +++ b/src/controllers/wizard/remote/index.js @@ -31,7 +31,7 @@ function onSubmit(e) { return false; } -export default function (view, params) { +export default function (view) { view.querySelector('.wizardSettingsForm').addEventListener('submit', onSubmit); view.addEventListener('viewshow', function () { document.querySelector('.skinHeader').classList.add('noHomeButtonHeader'); diff --git a/src/controllers/wizard/settings/index.js b/src/controllers/wizard/settings/index.js index 4a88e861f0..ac84c9ab1d 100644 --- a/src/controllers/wizard/settings/index.js +++ b/src/controllers/wizard/settings/index.js @@ -75,7 +75,7 @@ function onSubmit(e) { return false; } -export default function (view, params) { +export default function (view) { view.querySelector('.wizardSettingsForm').addEventListener('submit', onSubmit); view.addEventListener('viewshow', function () { document.querySelector('.skinHeader').classList.add('noHomeButtonHeader'); diff --git a/src/controllers/wizard/start/index.js b/src/controllers/wizard/start/index.js index 3f524a870a..807804cb7a 100644 --- a/src/controllers/wizard/start/index.js +++ b/src/controllers/wizard/start/index.js @@ -32,7 +32,7 @@ function onSubmit() { return false; } -export default function (view, params) { +export default function (view) { $('.wizardStartForm', view).on('submit', onSubmit); view.addEventListener('viewshow', function () { document.querySelector('.skinHeader').classList.add('noHomeButtonHeader'); diff --git a/src/controllers/wizard/user/index.js b/src/controllers/wizard/user/index.js index 693b3e02d7..b6b7618042 100644 --- a/src/controllers/wizard/user/index.js +++ b/src/controllers/wizard/user/index.js @@ -58,7 +58,7 @@ function onViewShow() { }); } -export default function (view, params) { +export default function (view) { view.querySelector('.wizardUserForm').addEventListener('submit', onSubmit); view.addEventListener('viewshow', function () { document.querySelector('.skinHeader').classList.add('noHomeButtonHeader'); diff --git a/src/elements/emby-collapse/emby-collapse.js b/src/elements/emby-collapse/emby-collapse.js index 3694d020f3..c4dfeeb5af 100644 --- a/src/elements/emby-collapse/emby-collapse.js +++ b/src/elements/emby-collapse/emby-collapse.js @@ -54,7 +54,7 @@ import '../emby-button/emby-button'; }); } - function onButtonClick(e) { + function onButtonClick() { const button = this; const collapseContent = button.parentNode.querySelector('.collapseContent'); diff --git a/src/elements/emby-itemscontainer/emby-itemscontainer.js b/src/elements/emby-itemscontainer/emby-itemscontainer.js index 3d84ea6bed..37edb8224c 100644 --- a/src/elements/emby-itemscontainer/emby-itemscontainer.js +++ b/src/elements/emby-itemscontainer/emby-itemscontainer.js @@ -188,7 +188,7 @@ import Sortable from 'sortablejs'; }); } - function onSeriesTimerCreated(e, apiClient, data) { + function onSeriesTimerCreated() { const itemsContainer = this; if (getEventsToMonitor(itemsContainer).indexOf('seriestimers') !== -1) { itemsContainer.notifyRefreshNeeded(); diff --git a/src/elements/emby-playstatebutton/emby-playstatebutton.js b/src/elements/emby-playstatebutton/emby-playstatebutton.js index d177ed0df6..c55abd01f1 100644 --- a/src/elements/emby-playstatebutton/emby-playstatebutton.js +++ b/src/elements/emby-playstatebutton/emby-playstatebutton.js @@ -20,7 +20,7 @@ import ServerConnections from '../../components/ServerConnections'; } } - function onClick(e) { + function onClick() { const button = this; const id = button.getAttribute('data-id'); const serverId = button.getAttribute('data-serverid'); diff --git a/src/elements/emby-progressring/emby-progressring.js b/src/elements/emby-progressring/emby-progressring.js index 2a1b18d442..3572abca7e 100644 --- a/src/elements/emby-progressring/emby-progressring.js +++ b/src/elements/emby-progressring/emby-progressring.js @@ -15,7 +15,7 @@ import template from './emby-progressring.template.html'; if (window.MutationObserver) { // create an observer instance const observer = new MutationObserver(function (mutations) { - mutations.forEach(function (mutation) { + mutations.forEach(function () { instance.setProgress(parseFloat(instance.getAttribute('data-progress') || '0')); }); }); diff --git a/src/elements/emby-ratingbutton/emby-ratingbutton.js b/src/elements/emby-ratingbutton/emby-ratingbutton.js index 18ab1aa9a1..5e279616e4 100644 --- a/src/elements/emby-ratingbutton/emby-ratingbutton.js +++ b/src/elements/emby-ratingbutton/emby-ratingbutton.js @@ -24,7 +24,7 @@ import ServerConnections from '../../components/ServerConnections'; return apiClient.updateFavoriteStatus(apiClient.getCurrentUserId(), itemId, !isFavorite); } - function onClick(e) { + function onClick() { const button = this; const id = button.getAttribute('data-id'); const serverId = button.getAttribute('data-serverid'); diff --git a/src/elements/emby-scrollbuttons/emby-scrollbuttons.js b/src/elements/emby-scrollbuttons/emby-scrollbuttons.js index f174186259..d1cb4705bc 100644 --- a/src/elements/emby-scrollbuttons/emby-scrollbuttons.js +++ b/src/elements/emby-scrollbuttons/emby-scrollbuttons.js @@ -57,7 +57,7 @@ const EmbyScrollButtonsPrototype = Object.create(HTMLDivElement.prototype); } } - function onScroll(e) { + function onScroll() { const scrollButtons = this; const scroller = this.scroller; @@ -117,7 +117,7 @@ const EmbyScrollButtonsPrototype = Object.create(HTMLDivElement.prototype); return scrollSize; } - function onScrollButtonClick(e) { + function onScrollButtonClick() { const scroller = this.parentNode.nextSibling; const direction = this.getAttribute('data-direction'); diff --git a/src/elements/emby-select/emby-select.js b/src/elements/emby-select/emby-select.js index af71b1a77d..6a04a7af29 100644 --- a/src/elements/emby-select/emby-select.js +++ b/src/elements/emby-select/emby-select.js @@ -63,14 +63,14 @@ import 'webcomponents.js/webcomponents-lite'; return elem; } - function onFocus(e) { + function onFocus() { const label = getLabel(this); if (label) { label.classList.add('selectLabelFocused'); } } - function onBlur(e) { + function onBlur() { const label = getLabel(this); if (label) { label.classList.remove('selectLabelFocused'); diff --git a/src/elements/emby-slider/emby-slider.js b/src/elements/emby-slider/emby-slider.js index 269f7a2962..5c05a393ef 100644 --- a/src/elements/emby-slider/emby-slider.js +++ b/src/elements/emby-slider/emby-slider.js @@ -105,7 +105,7 @@ import '../emby-input/emby-input'; }); } - function updateBubble(range, value, bubble, bubbleText) { + function updateBubble(range, value, bubble) { requestAnimationFrame(function () { const bubbleTrackRect = range.sliderBubbleTrack.getBoundingClientRect(); const bubbleRect = bubble.getBoundingClientRect(); @@ -189,7 +189,7 @@ import '../emby-input/emby-input'; let hasHideClass = sliderBubble.classList.contains('hide'); - dom.addEventListener(this, 'input', function (e) { + dom.addEventListener(this, 'input', function () { this.dragging = true; if (this.dataset.sliderKeepProgress !== 'true') { @@ -284,7 +284,7 @@ import '../emby-input/emby-input'; passive: true }); - dom.addEventListener(this, 'touchend', function (e) { + dom.addEventListener(this, 'touchend', function () { const range = this; setTimeout(function () { diff --git a/src/elements/emby-tabs/emby-tabs.js b/src/elements/emby-tabs/emby-tabs.js index 45e3270c1f..be80aa55d5 100644 --- a/src/elements/emby-tabs/emby-tabs.js +++ b/src/elements/emby-tabs/emby-tabs.js @@ -15,7 +15,7 @@ import '../../assets/css/scrollstyles.scss'; newButton.classList.add(activeButtonClass); } - function getTabPanel(tabs, index) { + function getTabPanel() { return null; } @@ -291,13 +291,13 @@ import '../../assets/css/scrollstyles.scss'; } }; - EmbyTabs.triggerBeforeTabChange = function (selected) { + EmbyTabs.triggerBeforeTabChange = function () { const tabs = this; triggerBeforeTabChange(tabs, tabs.selectedIndex()); }; - EmbyTabs.triggerTabChange = function (selected) { + EmbyTabs.triggerTabChange = function () { const tabs = this; tabs.dispatchEvent(new CustomEvent('tabchange', { diff --git a/src/plugins/chromecastPlayer/plugin.js b/src/plugins/chromecastPlayer/plugin.js index 41341066b3..e597075907 100644 --- a/src/plugins/chromecastPlayer/plugin.js +++ b/src/plugins/chromecastPlayer/plugin.js @@ -428,7 +428,7 @@ class CastPlayer { /** * Callback function for media command success */ - mediaCommandSuccessCallback(info, e) { + mediaCommandSuccessCallback(info) { console.debug(info); } } @@ -507,7 +507,7 @@ function initializeChromecast() { } })); - Events.on(instance._castPlayer, 'connect', function (e) { + Events.on(instance._castPlayer, 'connect', function () { if (currentResolve) { sendConnectionResult(true); } else { @@ -579,7 +579,7 @@ class ChromecastPlayer { new castSenderApiLoader().load().then(initializeChromecast.bind(this)); } - tryPair(target) { + tryPair() { const castPlayer = this._castPlayer; if (castPlayer.deviceState !== DEVICE_STATE.ACTIVE && castPlayer.isInitialized) { @@ -1058,11 +1058,11 @@ class ChromecastPlayer { getCurrentPlaylistItemId() { } - setCurrentPlaylistItem(playlistItemId) { + setCurrentPlaylistItem() { return Promise.resolve(); } - removeFromPlaylist(playlistItemIds) { + removeFromPlaylist() { return Promise.resolve(); } diff --git a/src/plugins/htmlAudioPlayer/plugin.js b/src/plugins/htmlAudioPlayer/plugin.js index fcabde15e5..446829a03e 100644 --- a/src/plugins/htmlAudioPlayer/plugin.js +++ b/src/plugins/htmlAudioPlayer/plugin.js @@ -135,7 +135,7 @@ class HtmlAudioPlayer { const hls = new Hls({ manifestLoadingTimeOut: 20000, - xhrSetup: function (xhr, url) { + xhrSetup: function (xhr) { xhr.withCredentials = includeCorsCredentials; } }); @@ -280,7 +280,7 @@ class HtmlAudioPlayer { Events.trigger(self, 'playing'); } - function onPlay(e) { + function onPlay() { Events.trigger(self, 'unpause'); } @@ -365,7 +365,7 @@ class HtmlAudioPlayer { } } - duration(val) { + duration() { const mediaElement = this._mediaElement; if (mediaElement) { const duration = mediaElement.duration; diff --git a/src/plugins/pdfPlayer/plugin.js b/src/plugins/pdfPlayer/plugin.js index 2b0d69ca36..40d6041ad6 100644 --- a/src/plugins/pdfPlayer/plugin.js +++ b/src/plugins/pdfPlayer/plugin.js @@ -189,7 +189,7 @@ export class PdfPlayer { const serverId = item.ServerId; const apiClient = ServerConnections.getApiClient(serverId); - return new Promise((resolve, reject) => { + return new Promise((resolve) => { const downloadHref = apiClient.getItemDownloadUrl(item.Id); this.bindEvents(); diff --git a/src/plugins/photoPlayer/plugin.js b/src/plugins/photoPlayer/plugin.js index 2324ef8932..42ffd3c7dd 100644 --- a/src/plugins/photoPlayer/plugin.js +++ b/src/plugins/photoPlayer/plugin.js @@ -9,7 +9,7 @@ export default class PhotoPlayer { } play(options) { - return new Promise(function (resolve, reject) { + return new Promise(function (resolve) { import('../../components/slideshow/slideshow').then(({default: Slideshow}) => { const index = options.startIndex || 0; diff --git a/src/plugins/sessionPlayer/plugin.js b/src/plugins/sessionPlayer/plugin.js index 2f9b6f926f..0d93f4d235 100644 --- a/src/plugins/sessionPlayer/plugin.js +++ b/src/plugins/sessionPlayer/plugin.js @@ -114,7 +114,7 @@ function processUpdatedSessions(instance, sessions, apiClient) { } } -function getChangedEvents(state1, state2) { +function getChangedEvents(state1) { const names = []; if (!state1) { @@ -490,15 +490,15 @@ class SessionPlayer { getCurrentPlaylistItemId() { } - setCurrentPlaylistItem(playlistItemId) { + setCurrentPlaylistItem() { return Promise.resolve(); } - removeFromPlaylist(playlistItemIds) { + removeFromPlaylist() { return Promise.resolve(); } - tryPair(target) { + tryPair() { return Promise.resolve(); } } diff --git a/src/plugins/youtubePlayer/plugin.js b/src/plugins/youtubePlayer/plugin.js index f04022a52c..50edabccf2 100644 --- a/src/plugins/youtubePlayer/plugin.js +++ b/src/plugins/youtubePlayer/plugin.js @@ -24,7 +24,7 @@ function zoomIn(elem, iterations) { } function createMediaElement(instance, options) { - return new Promise(function (resolve, reject) { + return new Promise(function (resolve) { const dlg = document.querySelector('.youtubePlayerContainer'); if (!dlg) { @@ -111,7 +111,7 @@ function onPlayerReady(event) { event.target.playVideo(); } -function onTimeUpdate(e) { +function onTimeUpdate() { Events.trigger(this, 'timeupdate'); } @@ -242,7 +242,7 @@ class YoutubePlayer { return mediaType === 'audio' || mediaType === 'video'; } - canPlayItem(item) { + canPlayItem() { // Does not play server items return false; } @@ -255,12 +255,12 @@ class YoutubePlayer { currentSrc() { return this._currentSrc; } - setSubtitleStreamIndex(index) { + setSubtitleStreamIndex() { } canSetAudioStreamIndex() { return false; } - setAudioStreamIndex(index) { + setAudioStreamIndex() { } // Save this for when playback stops, because querying the time at that point might return 0 currentTime(val) { @@ -275,7 +275,7 @@ class YoutubePlayer { return currentYoutubePlayer.getCurrentTime() * 1000; } } - duration(val) { + duration() { const currentYoutubePlayer = this.currentYoutubePlayer; if (currentYoutubePlayer) { diff --git a/src/scripts/clientUtils.js b/src/scripts/clientUtils.js index a7941d88c6..cc51bc1b81 100644 --- a/src/scripts/clientUtils.js +++ b/src/scripts/clientUtils.js @@ -19,12 +19,6 @@ export async function serverAddress() { return Promise.resolve(apiClient.serverAddress()); } - const current = await ServerConnections.getAvailableServers().then(servers => { - if (servers.length !== 0) { - return Promise.resolve(servers[0].ManualAddress); - } - }); - // TODO this makes things faster but it also blocks the wizard in some scenarios // if (current) return Promise.resolve(current); @@ -50,7 +44,7 @@ export async function serverAddress() { url: url, response: resp }; - }).catch(error => { + }).catch(() => { return Promise.resolve(); }); }); @@ -117,7 +111,7 @@ export function processPluginConfigurationUpdateResult() { toast(globalize.translate('SettingsSaved')); } -export function processServerConfigurationUpdateResult(result) { +export function processServerConfigurationUpdateResult() { loading.hide(); toast(globalize.translate('SettingsSaved')); } diff --git a/src/scripts/gamepadtokey.js b/src/scripts/gamepadtokey.js index e8c2d36677..d7916f1fef 100644 --- a/src/scripts/gamepadtokey.js +++ b/src/scripts/gamepadtokey.js @@ -365,7 +365,7 @@ function isGamepadConnected() { return false; } -function onFocusOrGamepadAttach(e) { +function onFocusOrGamepadAttach() { /* eslint-disable-next-line compat/compat */ if (isGamepadConnected() && document.hasFocus()) { console.log('Gamepad connected! Starting input loop'); @@ -373,7 +373,7 @@ function onFocusOrGamepadAttach(e) { } } -function onFocusOrGamepadDetach(e) { +function onFocusOrGamepadDetach() { /* eslint-disable-next-line compat/compat */ if (!isGamepadConnected() || !document.hasFocus()) { console.log('Gamepad disconnected! No other gamepads are connected, stopping input loop'); diff --git a/src/scripts/globalize.js b/src/scripts/globalize.js index e3e70ada1d..dfd9071957 100644 --- a/src/scripts/globalize.js +++ b/src/scripts/globalize.js @@ -155,7 +155,7 @@ import { Events } from 'jellyfin-apiclient'; }); } - return new Promise(function (resolve, reject) { + return new Promise(function (resolve) { if (!filtered.length) { resolve(); return; diff --git a/src/scripts/keyboardNavigation.js b/src/scripts/keyboardNavigation.js index e10110d5c5..ff011f387c 100644 --- a/src/scripts/keyboardNavigation.js +++ b/src/scripts/keyboardNavigation.js @@ -152,7 +152,7 @@ export function enable() { // Gamepad initialisation. No script is required if no gamepads are present at init time, saving a bit of resources. // Whenever the gamepad is connected, we hand all the control of the gamepad to gamepadtokey.js by removing the event handler -function attachGamepadScript(e) { +function attachGamepadScript() { console.log('Gamepad connected! Attaching gamepadtokey.js script'); window.removeEventListener('gamepadconnected', attachGamepadScript); /* eslint-disable-next-line @babel/no-unused-expressions */ diff --git a/src/scripts/libraryMenu.js b/src/scripts/libraryMenu.js index c9ad29ddff..e3087cded3 100644 --- a/src/scripts/libraryMenu.js +++ b/src/scripts/libraryMenu.js @@ -164,7 +164,7 @@ import Headroom from 'headroom.js'; inputManager.handleCommand('search'); } - function onHeaderUserButtonClick(e) { + function onHeaderUserButtonClick() { Dashboard.navigate('mypreferencesmenu.html'); } @@ -206,7 +206,7 @@ import Headroom from 'headroom.js'; Events.on(playbackManager, 'playbackstop', onPlaybackStop); } - function onPlaybackStart(e) { + function onPlaybackStart() { if (playbackManager.isPlayingAudio() && layoutManager.tv) { headerAudioPlayerButton.classList.remove('hide'); } else { @@ -243,7 +243,7 @@ import Headroom from 'headroom.js'; } } - function onSyncPlaySyncing(event, is_syncing, syncMethod) { + function onSyncPlaySyncing(event, is_syncing) { const icon = headerSyncButton.querySelector('span'); icon.classList.remove('sync', 'sync_disabled', 'sync_problem'); if (is_syncing) { @@ -281,7 +281,7 @@ import Headroom from 'headroom.js'; navDrawerInstance.close(); } - function onMainDrawerSelect(e) { + function onMainDrawerSelect() { if (navDrawerInstance.isVisible) { onMainDrawerOpened(); } else { @@ -289,7 +289,7 @@ import Headroom from 'headroom.js'; } } - function refreshLibraryInfoInDrawer(user, drawer) { + function refreshLibraryInfoInDrawer(user) { let html = ''; html += '
'; html += '' + globalize.translate('Home') + ''; @@ -538,7 +538,7 @@ import Headroom from 'headroom.js'; } function getToolsMenuLinks(apiClient) { - return apiClient.getJSON(apiClient.getUrl('web/configurationpages') + '?pageType=PluginConfiguration&EnableInMainMenu=true').then(createToolsMenuList, function (err) { + return apiClient.getJSON(apiClient.getUrl('web/configurationpages') + '?pageType=PluginConfiguration&EnableInMainMenu=true').then(createToolsMenuList, function () { return createToolsMenuList([]); }); } @@ -862,7 +862,7 @@ import Headroom from 'headroom.js'; navDrawerElement = document.querySelector('.mainDrawer'); navDrawerScrollContainer = navDrawerElement.querySelector('.scrollContainer'); navDrawerScrollContainer.addEventListener('click', onMainDrawerClick); - return new Promise(function (resolve, reject) { + return new Promise(function (resolve) { import('../libraries/navdrawer/navdrawer').then(({ NavigationDrawer }) => { navDrawerInstance = new NavigationDrawer(getNavDrawerOptions()); @@ -955,7 +955,7 @@ import Headroom from 'headroom.js'; } let currentPageType; - pageClassOn('pagebeforeshow', 'page', function (e) { + pageClassOn('pagebeforeshow', 'page', function () { if (!this.classList.contains('withTabs')) { LibraryMenu.setTabs(null); } diff --git a/src/scripts/playlists.js b/src/scripts/playlists.js index 3886d929cf..b8e5d746e0 100644 --- a/src/scripts/playlists.js +++ b/src/scripts/playlists.js @@ -8,7 +8,7 @@ import * as userSettings from './settings/userSettings'; import '../elements/emby-itemscontainer/emby-itemscontainer'; import Dashboard from './clientUtils'; -export default function (view, params) { +export default function (view) { function getPageData(context) { const key = getSavedQueryKey(context); let pageData = data[key]; diff --git a/src/scripts/themeManager.js b/src/scripts/themeManager.js index fb2792fbd9..ad7f7887a9 100644 --- a/src/scripts/themeManager.js +++ b/src/scripts/themeManager.js @@ -37,7 +37,7 @@ function getThemeStylesheetInfo(id) { } function setTheme(id) { - return new Promise(function (resolve, reject) { + return new Promise(function (resolve) { if (currentThemeId && currentThemeId === id) { resolve(); return;