mirrors/jellyfin-web
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin-web synced 2025-03-30 19:56:21 +00:00
Code Activity

Apply suggestions from code review

Browse source
This commit is contained in:
Matt Montgomery 2020-09-10 15:04:06 -05:00
parent 723472aca5
commit fa7d8bf4da
3 changed files with 45 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/components/quickConnectSettings/quickConnectSettings.js
View file

@ -36,10 +36,6 @@ export class QuickConnectSettings {
throw e; throw e;
}); });
} }
submit() {
return false;
}
} }
export default QuickConnectSettings; export default QuickConnectSettings;

30
src/controllers/dashboard/quickconnect.js
View file

@ -2,31 +2,33 @@ import loading from 'loading';
import toast from 'toast'; import toast from 'toast';
import globalize from 'globalize'; import globalize from 'globalize';
/* eslint-disable indent */ const unavailable = 'Unavailable';
const available = 'Available';
const active = 'Active';
let page;
let page; export default function(view) {
export default function(view) {
view.addEventListener('viewshow', function () { view.addEventListener('viewshow', function () {
page = this; page = this;
loading.show(); loading.show();
page.querySelector('#btnQuickConnectSubmit').onclick = onSubmit; page.querySelector('#btnQuickConnectSubmit').onclick = onSubmit;
updatePage(); updatePage();
}); });
} }
function loadPage(status) { function loadPage(status) {
let available = status === 'Available' || status === 'Active'; let check = status === available || status === active;
page.querySelector('#quickConnectStatus').textContent = status.toLocaleLowerCase(); page.querySelector('#quickConnectStatus').textContent = status.toLocaleLowerCase();
page.querySelector('#chkQuickConnectAvailable').checked = available; page.querySelector('#chkQuickConnectAvailable').checked = check;
loading.hide(); loading.hide();
} }
function onSubmit() { function onSubmit() {
loading.show(); loading.show();
let newStatus = page.querySelector('#chkQuickConnectAvailable').checked ? 'Available' : 'Unavailable'; let newStatus = page.querySelector('#chkQuickConnectAvailable').checked ? available : unavailable;
let url = ApiClient.getUrl('/QuickConnect/Available?Status=' + newStatus); let url = ApiClient.getUrl('/QuickConnect/Available?Status=' + newStatus);
@ -44,15 +46,13 @@ import globalize from 'globalize';
loading.hide(); loading.hide();
return false; return false;
} }
function updatePage() { function updatePage() {
ApiClient.getQuickConnect('Status').then((response) => { ApiClient.getQuickConnect('Status').then((response) => {
loadPage(response); loadPage(response);
return true; return true;
}).catch((e) => { }).catch((e) => {
console.error('Unable to get quick connect status. error:', e); console.error('Unable to get quick connect status. error:', e);
}); });
} }
/* eslint-enable indent */

5
src/controllers/user/quickConnect/index.js
View file

@ -33,11 +33,6 @@ export default function (view) {
renderPage(); renderPage();
}); });
view.addEventListener('viewbeforehide', function () {
if (quickConnectSettingsInstance) {
quickConnectSettingsInstance.submit();
}
});
function renderPage(forceActive = false) { function renderPage(forceActive = false) {
ApiClient.getQuickConnect('Status').then((status) => { ApiClient.getQuickConnect('Status').then((status) => {