Apply suggestions from code review

src/components/quickConnectSettings/quickConnectSettings.js

@@ -36,10 +36,6 @@ export class QuickConnectSettings {
             throw e;
         });
     }
-
-    submit() {
-        return false;
-    }
 }
 
 export default QuickConnectSettings;

src/controllers/dashboard/quickconnect.js

@@ -2,31 +2,33 @@ import loading from 'loading';
 import toast from 'toast';
 import globalize from 'globalize';
 
-/* eslint-disable indent */
+const unavailable = 'Unavailable';
+const available = 'Available';
+const active = 'Active';
+let page;
 
-    let page;
-    export default function(view) {
+export default function(view) {
     view.addEventListener('viewshow', function () {
         page = this;
         loading.show();
         page.querySelector('#btnQuickConnectSubmit').onclick = onSubmit;
         updatePage();
     });
-    }
+}
 
-    function loadPage(status) {
-        let available = status === 'Available' || status === 'Active';
+function loadPage(status) {
+    let check = status === available || status === active;
 
     page.querySelector('#quickConnectStatus').textContent = status.toLocaleLowerCase();
-        page.querySelector('#chkQuickConnectAvailable').checked = available;
+    page.querySelector('#chkQuickConnectAvailable').checked = check;
 
     loading.hide();
-    }
+}
 
-    function onSubmit() {
+function onSubmit() {
     loading.show();
 
-        let newStatus = page.querySelector('#chkQuickConnectAvailable').checked ? 'Available' : 'Unavailable';
+    let newStatus = page.querySelector('#chkQuickConnectAvailable').checked ? available : unavailable;
 
     let url = ApiClient.getUrl('/QuickConnect/Available?Status=' + newStatus);
 
@@ -44,15 +46,13 @@ import globalize from 'globalize';
 
     loading.hide();
     return false;
-    }
+}
 
-    function updatePage() {
+function updatePage() {
     ApiClient.getQuickConnect('Status').then((response) => {
         loadPage(response);
         return true;
     }).catch((e) => {
         console.error('Unable to get quick connect status. error:', e);
     });
-    }
-
-/* eslint-enable indent */
+}

src/controllers/user/quickConnect/index.js

@@ -33,11 +33,6 @@ export default function (view) {
 
         renderPage();
     });
-    view.addEventListener('viewbeforehide', function () {
-        if (quickConnectSettingsInstance) {
-            quickConnectSettingsInstance.submit();
-        }
-    });
 
     function renderPage(forceActive = false) {
         ApiClient.getQuickConnect('Status').then((status) => {