Merge pull request #6277 from thornbill/no-self-cast-target

src/apps/experimental/components/AppToolbar/menus/RemotePlayMenu.tsx

@@ -65,17 +65,20 @@ const RemotePlayMenu: FC<RemotePlayMenuProps> = ({
             open={open}
             onClose={onMenuClose}
         >
-            {!isChromecastPluginLoaded && ([
+            {!isChromecastPluginLoaded && (
-                <MenuItem key='cast-unsupported-item' disabled>
+                <MenuItem disabled>
                     <ListItemIcon>
                         <Warning />
                     </ListItemIcon>
                     <ListItemText>
                         {globalize.translate('GoogleCastUnsupported')}
                     </ListItemText>
-                </MenuItem>,
+                </MenuItem>
-                <Divider key='cast-unsupported-divider' />
+            )}
-            ])}
+
+            {!isChromecastPluginLoaded && playbackTargets.length > 0 && (
+                <Divider />
+            )}
 
             {playbackTargets.map(target => (
                 <MenuItem

src/components/playback/playbackmanager.js

@@ -852,31 +852,8 @@ export class PlaybackManager {
         self.getTargets = function () {
             const promises = players.filter(displayPlayerIndividually).map(getPlayerTargets);
 
-            return Promise.all(promises).then(function (responses) {
+            return Promise.all(promises)
-                return ServerConnections.currentApiClient().getCurrentUser().then(function (user) {
+                .then(responses => responses.flat().sort(sortPlayerTargets));
-                    const targets = [];
-
-                    targets.push({
-                        name: globalize.translate('HeaderMyDevice'),
-                        id: 'localplayer',
-                        playerName: 'localplayer',
-                        playableMediaTypes: ['Audio', 'Video', 'Photo', 'Book'],
-                        isLocalPlayer: true,
-                        supportedCommands: self.getSupportedCommands({
-                            isLocalPlayer: true
-                        }),
-                        user: user
-                    });
-
-                    for (const subTargets of responses) {
-                        for (const subTarget of subTargets) {
-                            targets.push(subTarget);
-                        }
-                    }
-
-                    return targets.sort(sortPlayerTargets);
-                });
-            });
         };
 
         self.playerHasSecondarySubtitleSupport = function (player = self._currentPlayer) {

src/strings/en-us.json

@@ -452,7 +452,6 @@
     "HeaderMetadataSettings": "Metadata Settings",
     "HeaderMoreLikeThis": "More Like This",
     "HeaderMusicQuality": "Music Quality",
-    "HeaderMyDevice": "My Device",
     "HeaderMyMedia": "My Media",
     "HeaderMyMediaSmall": "My Media (small)",
     "HeaderNavigation": "Navigation",